49dfad942970459297f72632ed8dfd353e0c86de
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 42
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method package getActiveNNAddress() : URL renamed to package getActiveNNAddresses() : List<URL> in class org.apache.hadoop.hdfs.server.namenode.ha.StandbyCheckpointer | From | To | |
| Rename Method public setFailoverConfigurations(conf Configuration, logicalName String, nnAddr1 InetSocketAddress, nnAddr2 InetSocketAddress) : void renamed to public apply(addr InetSocketAddress) : String in class org.apache.hadoop.hdfs.server.namenode.ha.HATestUtil.setFailoverConfigurations.setFailoverConfigurations.transform | From | To | |
| Rename Method public getNameNodeIdOfOtherNode(conf Configuration, nsId String) : String renamed to public getNameNodeIdOfOtherNodes(conf Configuration, nsId String) : List<String> in class org.apache.hadoop.hdfs.HAUtil | From | To | |
| Rename Method public getConfForOtherNode(myConf Configuration) : Configuration renamed to public getConfForOtherNodes(myConf Configuration) : List<Configuration> in class org.apache.hadoop.hdfs.HAUtil | From | To | |
| Rename Variable | 8 | ||
| Rename Variable otherNnConf : Configuration to otherNnConfs : List<Configuration> in method package isValidRequestor(context ServletContext, remoteUser String, conf Configuration) : boolean in class org.apache.hadoop.hdfs.server.namenode.ImageServlet | From | To | |
| Rename Variable nnAddr1 : InetSocketAddress to nnAddresses : List<InetSocketAddress> in method public setFailoverConfigurations(cluster MiniDFSCluster, conf Configuration, logicalName String, nsIndex int) : void in class org.apache.hadoop.hdfs.server.namenode.ha.HATestUtil | From | To | |
| Rename Variable i : int to nsCounter : int in method private createNameNodesAndSetConf(nnTopology MiniDFSNNTopology, manageNameDfsDirs boolean, manageNameDfsSharedDirs boolean, enableManagedDfsDirsRedundancy boolean, format boolean, operation StartupOption, clusterId String) : void in class org.apache.hadoop.hdfs.MiniDFSCluster | From | To | |
| Rename Variable thisNnId : String to nnId : String in method private createBlockTokenSecretManager(conf Configuration) : BlockTokenSecretManager in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Rename Variable nnSet : ArrayList<String> to namenodes : ArrayList<String> in method public getNameNodeIdOfOtherNodes(conf Configuration, nsId String) : List<String> in class org.apache.hadoop.hdfs.HAUtil | From | To | |
| Rename Variable nnCounterForFormat : int to nnIndex : int in method private configureNameService(nameservice MiniDFSNNTopology.NSConf, nsCounter int, manageNameDfsSharedDirs boolean, manageNameDfsDirs boolean, enableManagedDfsDirsRedundancy boolean, format boolean, operation StartupOption, clusterId String, nnCounter int) : void in class org.apache.hadoop.hdfs.MiniDFSCluster | From | To | |
| Rename Variable confNN1 : Configuration to otherNNConf : Configuration in method private bootstrapStandbys() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM | From | To | |
| Change Return Type | 7 | ||
| Change Return Type void to NameNodeInfo in method private createNameNode(conf Configuration, format boolean, operation StartupOption, clusterId String, nameserviceId String, nnId String) : NameNodeInfo in class org.apache.hadoop.hdfs.MiniDFSCluster | From | To | |
| Change Return Type void to TransferResult in method public uploadImageFromStorage(fsName URL, conf Configuration, storage NNStorage, nnf NameNodeFile, txid long, canceler Canceler) : TransferResult in class org.apache.hadoop.hdfs.server.namenode.TransferFsImage | From | To | |
| Change Return Type void to String in method public apply(addr InetSocketAddress) : String in class org.apache.hadoop.hdfs.server.namenode.ha.HATestUtil.setFailoverConfigurations.setFailoverConfigurations.transform | From | To | |
| Change Return Type void to TransferResult in method public uploadImageFromStorage(fsName URL, conf Configuration, storage NNStorage, nnf NameNodeFile, txid long) : TransferResult in class org.apache.hadoop.hdfs.server.namenode.TransferFsImage | From | To | |
| Change Return Type Configuration to List<Configuration> in method public getConfForOtherNodes(myConf Configuration) : List<Configuration> in class org.apache.hadoop.hdfs.HAUtil | From | To | |
| Change Return Type String to List<String> in method public getNameNodeIdOfOtherNodes(conf Configuration, nsId String) : List<String> in class org.apache.hadoop.hdfs.HAUtil | From | To | |
| Change Return Type URL to List<URL> in method package getActiveNNAddresses() : List<URL> in class org.apache.hadoop.hdfs.server.namenode.ha.StandbyCheckpointer | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable oldActive : HAServiceTarget to remote : HAServiceTarget in method private cedeRemoteActive(remote HAServiceTarget, timeout int) : ZKFCProtocol in class org.apache.hadoop.ha.ZKFailoverController | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute activeNNAddress : URL to activeNNAddresses : List<URL> in class org.apache.hadoop.hdfs.server.namenode.ha.StandbyCheckpointer | From | To | |
| Rename Attribute otherNNId : String to remoteNNs : List<RemoteNameNodeInfo> in class org.apache.hadoop.hdfs.server.namenode.ha.BootstrapStandby | From | To | |
| Extract Variable | 3 | ||
| Extract Variable numNNs : int in method private configureNameService(nameservice MiniDFSNNTopology.NSConf, nsCounter int, manageNameDfsSharedDirs boolean, manageNameDfsDirs boolean, enableManagedDfsDirsRedundancy boolean, format boolean, operation StartupOption, clusterId String, nnCounter int) : void from class org.apache.hadoop.hdfs.MiniDFSCluster | From | To | |
| Extract Variable ie : InterruptedException in method private doCheckpoint(sendCheckpoint boolean) : void from class org.apache.hadoop.hdfs.server.namenode.ha.StandbyCheckpointer | From | To | |
| Extract Variable currentDir : File in method public testSharedEditsMissingLogs() : void from class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type otherNn : String to otherNn : List<String> in method public getConfForOtherNodes(myConf Configuration) : List<Configuration> in class org.apache.hadoop.hdfs.HAUtil | From | To | |
| Change Variable Type confForActive : Configuration to confForActive : List<Configuration> in method private setNameNodeAddresses(conf Configuration) : void in class org.apache.hadoop.hdfs.server.namenode.ha.StandbyCheckpointer | From | To | |
| Change Variable Type upload : Future<Void> to upload : Future<TransferFsImage.TransferResult> in method private doCheckpoint(sendCheckpoint boolean) : void in class org.apache.hadoop.hdfs.server.namenode.ha.StandbyCheckpointer | From | To | |
| Change Variable Type otherNnConf : Configuration to otherNnConfs : List<Configuration> in method package isValidRequestor(context ServletContext, remoteUser String, conf Configuration) : boolean in class org.apache.hadoop.hdfs.server.namenode.ImageServlet | From | To | |
| Change Variable Type nnAddr1 : InetSocketAddress to nnAddresses : List<InetSocketAddress> in method public setFailoverConfigurations(cluster MiniDFSCluster, conf Configuration, logicalName String, nsIndex int) : void in class org.apache.hadoop.hdfs.server.namenode.ha.HATestUtil | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type otherNNId : String to remoteNNs : List<RemoteNameNodeInfo> in class org.apache.hadoop.hdfs.server.namenode.ha.BootstrapStandby | From | To | |
| Change Attribute Type activeNNAddress : URL to activeNNAddresses : List<URL> in class org.apache.hadoop.hdfs.server.namenode.ha.StandbyCheckpointer | From | To | |
| Change Attribute Type svcs : DummyHAService[] to svcs : List<DummyHAService> in class org.apache.hadoop.ha.MiniZKFCCluster | From | To | |
| Extract Method | 24 | ||
| Extract Method public setFailoverConfigurations(conf Configuration, logicalName String, nnAddresses InetSocketAddress...) : void extracted from public setFailoverConfigurations(cluster MiniDFSCluster, conf Configuration, logicalName String, nsIndex int) : void in class org.apache.hadoop.hdfs.server.namenode.ha.HATestUtil | From | To | |
| Extract Method private forceBootstrap(i int) : int extracted from public testDownloadingLaterCheckpoint() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby | From | To | |
| Extract Method public start(count int) : void extracted from public start() : void in class org.apache.hadoop.ha.MiniZKFCCluster | From | To | |
| Extract Method private assertAddressMatches(address String, url URL) : void extracted from public testGetOtherNNHttpAddress() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestHAConfiguration | From | To | |
| Extract Method public testCheckpoint(nnCount int) : void extracted from public testCheckpoint() : void in class org.apache.hadoop.hdfs.TestRollingUpgrade | From | To | |
| Extract Method private newMiniCluster(conf Configuration, dnCount int) : MiniDFSCluster extracted from public testLeaseRecoveryAfterFailover() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover | From | To | |
| Extract Method private bootstrapStandbys() : void extracted from public testBootstrapStandbyWithStandbyNN() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM | From | To | |
| Extract Method private testFinalize(nnCount int) : void extracted from public testFinalize() : void in class org.apache.hadoop.hdfs.TestRollingUpgrade | From | To | |
| Extract Method private newMiniCluster(conf Configuration, dnCount int) : MiniDFSCluster extracted from public testFailoverRightBeforeCommitSynchronization() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover | From | To | |
| Extract Method private cedeRemoteActive(remote HAServiceTarget, timeout int) : ZKFCProtocol extracted from private doGracefulFailover() : void in class org.apache.hadoop.ha.ZKFailoverController | From | To | |
| Extract Method private bootstrapStandbys() : void extracted from public testBootstrapStandbyWithActiveNN() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandbyWithQJM | From | To | |
| Extract Method public setFailoverConfigurations(conf Configuration, logicalName String, nnAddresses List<InetSocketAddress>) : void extracted from public setFailoverConfigurations(cluster MiniDFSCluster, conf Configuration, logicalName String, nsIndex int) : void in class org.apache.hadoop.hdfs.server.namenode.ha.HATestUtil | From | To | |
| Extract Method public configureNameNodes(nnTopology MiniDFSNNTopology, federation boolean, conf Configuration) : void extracted from private createNameNodesAndSetConf(nnTopology MiniDFSNNTopology, manageNameDfsDirs boolean, manageNameDfsSharedDirs boolean, enableManagedDfsDirsRedundancy boolean, format boolean, operation StartupOption, clusterId String, conf Configuration) : void in class org.apache.hadoop.hdfs.MiniDFSCluster | From | To | |
| Extract Method private forceBootstrap(i int) : int extracted from public testOtherNodeNotActive() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby | From | To | |
| Extract Method private forceBootstrap(i int) : int extracted from public testStandbyDirsAlreadyExist() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby | From | To | |
| Extract Method protected setNNs() : void extracted from public testCheckpointCancellationDuringUpload() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints | From | To | |
| Extract Method private assertSuccessfulBootstrapFromIndex(start int) : void extracted from public testOtherNodeNotActive() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby | From | To | |
| Extract Method protected setNNs() : void extracted from public setupCluster() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints | From | To | |
| Extract Method private verifyNNCheckpoint(dfsCluster MiniDFSCluster, txid long, nnIndex int) : void extracted from public testCheckpoint() : void in class org.apache.hadoop.hdfs.TestRollingUpgrade | From | To | |
| Extract Method private newMiniCluster(conf Configuration, dnCount int) : MiniDFSCluster extracted from private doWriteOverFailoverTest(scenario TestScenario, methodToTest MethodToTestIdempotence) : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover | From | To | |
| Extract Method private configureNameService(nameservice MiniDFSNNTopology.NSConf, nsCounter int, manageNameDfsSharedDirs boolean, manageNameDfsDirs boolean, enableManagedDfsDirsRedundancy boolean, format boolean, operation StartupOption, clusterId String, nnCounter int) : void extracted from private createNameNodesAndSetConf(nnTopology MiniDFSNNTopology, manageNameDfsDirs boolean, manageNameDfsSharedDirs boolean, enableManagedDfsDirsRedundancy boolean, format boolean, operation StartupOption, clusterId String, conf Configuration) : void in class org.apache.hadoop.hdfs.MiniDFSCluster | From | To | |
| Extract Method private testQuery(nnCount int) : void extracted from public testQuery() : void in class org.apache.hadoop.hdfs.TestRollingUpgrade | From | To | |
| Extract Method private newMiniCluster(conf Configuration, dnCount int) : MiniDFSCluster extracted from private doTestWriteOverFailoverWithDnFail(scenario TestScenario) : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestPipelinesFailover | From | To | |
| Extract Method private forceBootstrap(i int) : int extracted from public testSharedEditsMissingLogs() : void in class org.apache.hadoop.hdfs.server.namenode.ha.TestBootstrapStandby | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected setNNs() : void extracted from public setupCluster() : void in class org.apache.hadoop.contrib.bkjournal.TestBookKeeperHACheckpoints & moved to class org.apache.hadoop.hdfs.server.namenode.ha.TestStandbyCheckpoints | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter nnAddr1 : InetSocketAddress to addr : InetSocketAddress in method public apply(addr InetSocketAddress) : String in class org.apache.hadoop.hdfs.server.namenode.ha.HATestUtil.setFailoverConfigurations.setFailoverConfigurations.transform | From | To |