4a7369b09547a78f532af66c763c6994a38b5d68
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 39
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private createServiceClient(applicationId ApplicationId) : ServiceClient from class org.apache.hadoop.yarn.service.client.TestServiceClient to package create(rule ServiceTestUtils.ServiceFSWatcher, service Service) : MockServiceClient from class org.apache.hadoop.yarn.service.client.TestServiceClient.MockServiceClient | From | To | |
| Change Parameter Type | 1 | ||
| Change Parameter Type component : Component to compLaunchContext : ContainerLaunchService.ComponentLaunchContext in method public createConfigFileAndAddLocalResource(launcher AbstractLauncher, fs SliderFileSystem, compLaunchContext ContainerLaunchService.ComponentLaunchContext, tokensForSubstitution Map<String,String>, instance ComponentInstance, context ServiceContext) : void in class org.apache.hadoop.yarn.service.provider.ProviderUtils | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.hadoop.yarn.service.ServiceManager.StopUpgradeTransition renamed to org.apache.hadoop.yarn.service.ServiceManager.CheckStableTransition | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type compSpec : Component to componentLaunchContext : ComponentLaunchContext in method public run() : void in class org.apache.hadoop.yarn.service.containerlaunch.ContainerLaunchService.ContainerLauncher | From | To | |
| Change Variable Type component : Component to compLaunchContext : ContainerLaunchService.ComponentLaunchContext in method public buildContainerLaunchContext(launcher AbstractLauncher, service Service, instance ComponentInstance, fileSystem SliderFileSystem, yarnConf Configuration, container Container, compLaunchContext ContainerLaunchService.ComponentLaunchContext) : void in class org.apache.hadoop.yarn.service.provider.AbstractProviderService | From | To | |
| Extract Method | 1 | ||
| Extract Method private getServiceFromClient(ugi UserGroupInformation, serviceName String) : Service extracted from public getService(request HttpServletRequest, appName String) : Response in class org.apache.hadoop.yarn.service.webapp.ApiServer | From | To | |
| Rename Method | 5 | ||
| Rename Method public testUpgradeService() : void renamed to public testUpgrade() : void in class org.apache.hadoop.yarn.service.TestYarnNativeServices | From | To | |
| Rename Method public abstract actionUpgrade(appName String, fileName String) : int renamed to public abstract initiateUpgrade(appName String, fileName String, autoFinalize boolean) : int in class org.apache.hadoop.yarn.client.api.AppAdminClient | From | To | |
| Rename Method public actionUpgrade(service Service) : int renamed to public initiateUpgrade(service Service) : int in class org.apache.hadoop.yarn.service.client.ServiceClient | From | To | |
| Rename Method private getApiUrl(appName String) : String renamed to private getServicePath(appName String) : String in class org.apache.hadoop.yarn.service.client.ApiServiceClient | From | To | |
| Rename Method public actionUpgrade(appName String, fileName String) : int renamed to public initiateUpgrade(appName String, fileName String, autoFinalize boolean) : int in class org.apache.hadoop.yarn.service.client.ApiServiceClient | From | To | |
| Inline Method | 2 | ||
| Inline Method private runCLI(args String[]) : void inlined to private buildApp(serviceName String, appDef String, lifetime String, queue String) : void in class org.apache.hadoop.yarn.service.client.TestServiceCLI | From | To | |
| Inline Method private runCLI(args String[]) : void inlined to private buildApp(serviceName String, appDef String) : void in class org.apache.hadoop.yarn.service.client.TestServiceCLI | From | To | |
| Rename Variable | 2 | ||
| Rename Variable app : Service to app1 : Service in method private getServiceFromClient(ugi UserGroupInformation, serviceName String) : Service in class org.apache.hadoop.yarn.service.webapp.ApiServer | From | To | |
| Rename Variable upgradeSpec : Service to targetSpec : Service in method private finalizeUpgrade() : boolean in class org.apache.hadoop.yarn.service.ServiceManager | From | To | |
| Change Return Type | 1 | ||
| Change Return Type ServiceClient to MockServiceClient in method package create(rule ServiceTestUtils.ServiceFSWatcher, service Service) : MockServiceClient in class org.apache.hadoop.yarn.service.client.TestServiceClient.MockServiceClient | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable component : Component to compLaunchContext : ContainerLaunchService.ComponentLaunchContext in method public buildContainerLaunchContext(launcher AbstractLauncher, service Service, instance ComponentInstance, fileSystem SliderFileSystem, yarnConf Configuration, container Container, compLaunchContext ContainerLaunchService.ComponentLaunchContext) : void in class org.apache.hadoop.yarn.service.provider.AbstractProviderService | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute compSpec : Component to componentLaunchContext : ComponentLaunchContext in method public run() : void in class org.apache.hadoop.yarn.service.containerlaunch.ContainerLaunchService.ContainerLauncher | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method package processUpgradeRequest(upgradeVersion String, autoFinalize boolean) : void extracted from public upgrade(request UpgradeServiceRequestProto) : UpgradeServiceResponseProto in class org.apache.hadoop.yarn.service.ClientAMService & moved to class org.apache.hadoop.yarn.service.ServiceManager | From | To | |
| Extract And Move Method package buildGoodService() : Service extracted from public testGoodCreateService() : void in class org.apache.hadoop.yarn.service.TestApiServer & moved to class org.apache.hadoop.yarn.service.ServiceClientTest | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter appName : String to requestPath : String in method private getApiClient(requestPath String) : Builder in class org.apache.hadoop.yarn.service.client.ApiServiceClient | From | To | |
| Rename Parameter component : Component to compLaunchContext : ContainerLaunchService.ComponentLaunchContext in method public createConfigFileAndAddLocalResource(launcher AbstractLauncher, fs SliderFileSystem, compLaunchContext ContainerLaunchService.ComponentLaunchContext, tokensForSubstitution Map<String,String>, instance ComponentInstance, context ServiceContext) : void in class org.apache.hadoop.yarn.service.provider.ProviderUtils | From | To | |
| Rename Parameter appName : String to serviceName : String in method private getServiceFromClient(ugi UserGroupInformation, serviceName String) : Service in class org.apache.hadoop.yarn.service.webapp.ApiServer | From | To | |
| Rename Parameter service : ServiceManager to serviceManager : ServiceManager in method private upgrade(serviceManager ServiceManager, version String, upgradeArtifact boolean, autoFinalize boolean) : void in class org.apache.hadoop.yarn.service.TestServiceManager | From | To |