51432779588fdd741b4840601f5db637ec783d92
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method public getExecutionType() : ExecutionType renamed to public getExecutionTypeRequest() : ExecutionTypeRequest in class org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest | From | To | |
Pull Up Method | 3 | ||
Pull Up Method protected createAllocateRequest(listNode List<NodeReport>) : AllocateRequest from class org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy to protected createAllocateRequest(listNode List<NodeReport>) : AllocateRequest from class org.apache.hadoop.yarn.client.api.impl.BaseAMRMProxyE2ETest | From | To | |
Pull Up Method protected createApp(yarnClient YarnClient, yarnCluster MiniYARNCluster) : ApplicationId from class org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy to protected createApp(yarnClient YarnClient, yarnCluster MiniYARNCluster, conf Configuration) : ApplicationAttemptId from class org.apache.hadoop.yarn.client.api.impl.BaseAMRMProxyE2ETest | From | To | |
Pull Up Method protected createAMRMProtocol(rmClient YarnClient, appId ApplicationId, cluster MiniYARNCluster, yarnConf Configuration) : ApplicationMasterProtocol from class org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy to protected createAMRMProtocol(rmClient YarnClient, appId ApplicationId, cluster MiniYARNCluster, yarnConf Configuration) : ApplicationMasterProtocol from class org.apache.hadoop.yarn.client.api.impl.BaseAMRMProxyE2ETest | From | To | |
Move And Rename Method | 1 | ||
Move And Rename Method private addResourceRequest(priority Priority, resourceName String, capability Resource, req T, relaxLocality boolean, labelExpression String) : void from class org.apache.hadoop.yarn.client.api.impl.AMRMClientImpl to package put(priority Priority, resourceName String, execType ExecutionType, capability Resource, resReqInfo ResourceRequestInfo) : void from class org.apache.hadoop.yarn.client.api.impl.RemoteRequestsTable | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type executionType : ExecutionType to executionTypeRequest : ExecutionTypeRequest in method public ContainerRequest(capability Resource, nodes String[], racks String[], priority Priority, relaxLocality boolean, nodeLabelsExpression String, executionTypeRequest ExecutionTypeRequest) in class org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest | From | To | |
Rename Variable | 1 | ||
Rename Variable entry : Map.Entry<Resource,ResourceRequestInfo> to resReqInfo : ResourceRequestInfo<T> in method public getMatchingRequests(priority Priority, resourceName String, executionType ExecutionType, capability Resource) : List<? extends Collection<T>> in class org.apache.hadoop.yarn.client.api.impl.AMRMClientImpl | From | To | |
Change Return Type | 2 | ||
Change Return Type ExecutionType to ExecutionTypeRequest in method public getExecutionTypeRequest() : ExecutionTypeRequest in class org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest | From | To | |
Change Return Type ApplicationId to ApplicationAttemptId in method protected createApp(yarnClient YarnClient, yarnCluster MiniYARNCluster, conf Configuration) : ApplicationAttemptId in class org.apache.hadoop.yarn.client.api.impl.BaseAMRMProxyE2ETest | From | To | |
Extract Superclass | 1 | ||
Extract Superclass org.apache.hadoop.yarn.client.api.impl.BaseAMRMProxyE2ETest from classes [org.apache.hadoop.yarn.client.api.impl.TestAMRMProxy, org.apache.hadoop.yarn.client.api.impl.TestDistributedScheduling] | From | To | |
Rename Attribute | 1 | ||
Rename Attribute executionType : ExecutionType to executionTypeRequest : ExecutionTypeRequest in class org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest | From | To | |
Change Variable Type | 1 | ||
Change Variable Type entry : Map.Entry<Resource,ResourceRequestInfo> to resReqInfo : ResourceRequestInfo<T> in method public getMatchingRequests(priority Priority, resourceName String, executionType ExecutionType, capability Resource) : List<? extends Collection<T>> in class org.apache.hadoop.yarn.client.api.impl.AMRMClientImpl | From | To | |
Extract Method | 2 | ||
Extract Method public getMatchingRequests(priority Priority, resourceName String, executionType ExecutionType, capability Resource) : List<? extends Collection<T>> extracted from public getMatchingRequests(priority Priority, resourceName String, capability Resource) : List<? extends Collection<T>> in class org.apache.hadoop.yarn.client.api.impl.AMRMClientImpl | From | To | |
Extract Method private verifyResourceRequest(client AMRMClientImpl<ContainerRequest>, request ContainerRequest, location String, expectedRelaxLocality boolean, executionType ExecutionType) : void extracted from private verifyResourceRequest(client AMRMClientImpl<ContainerRequest>, request ContainerRequest, location String, expectedRelaxLocality boolean) : void in class org.apache.hadoop.yarn.client.api.impl.TestAMRMClientContainerRequest | From | To | |
Change Attribute Type | 2 | ||
Change Attribute Type executionType : ExecutionType to executionTypeRequest : ExecutionTypeRequest in class org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest | From | To | |
Change Attribute Type remoteRequestsTable : Map<Priority,Map<String,TreeMap<Resource,ResourceRequestInfo>>> to remoteRequestsTable : RemoteRequestsTable in class org.apache.hadoop.yarn.client.api.impl.AMRMClientImpl | From | To | |
Rename Parameter | 1 | ||
Rename Parameter executionType : ExecutionType to executionTypeRequest : ExecutionTypeRequest in method public ContainerRequest(capability Resource, nodes String[], racks String[], priority Priority, relaxLocality boolean, nodeLabelsExpression String, executionTypeRequest ExecutionTypeRequest) in class org.apache.hadoop.yarn.client.api.AMRMClient.ContainerRequest | From | To |