52d1d9603ecc03dbe3ef5fafa60377ef461ecca3
Files Diff
- Added: 4
- Removed: 2
- Renamed: 0
- Modified: 37
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method private deleteContainerBlocks(delTX DeletedBlocksTransaction, config Configuration) : void renamed to private deleteKeyValueContainerBlocks(containerData KeyValueContainerData, delTX DeletedBlocksTransaction) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.DeleteBlocksCommandHandler | From | To | |
| Rename Method public getHandlerForContainerType(type ContainerType) : Handler renamed to public getHandler(containerType ContainerProtos.ContainerType) : Handler in class org.apache.hadoop.ozone.container.common.impl.HddsDispatcher | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type containerManager : ContainerManager to cset : ContainerSet in method public DeleteBlocksCommandHandler(cset ContainerSet, conf Configuration) in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.DeleteBlocksCommandHandler | From | To | |
| Change Parameter Type type : ContainerType to containerType : ContainerProtos.ContainerType in method public getHandler(containerType ContainerProtos.ContainerType) : Handler in class org.apache.hadoop.ozone.container.common.impl.HddsDispatcher | From | To | |
| Move Method | 1 | ||
| Move Method private computeCheckSum(containerFile File) : String from class org.apache.hadoop.ozone.container.keyvalue.KeyValueContainer to public computeCheckSum(containerId long, containerFile File) : String from class org.apache.hadoop.ozone.container.keyvalue.helpers.KeyValueContainerUtil | From | To | |
| Change Return Type | 3 | ||
| Change Return Type NodeReportProto to StorageContainerDatanodeProtocolProtos.NodeReportProto in method public getNodeReport() : StorageContainerDatanodeProtocolProtos.NodeReportProto in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Change Return Type Configuration to OzoneConfiguration in method public getConf() : OzoneConfiguration in class org.apache.hadoop.ozone.container.common.SCMTestUtils | From | To | |
| Change Return Type ContainerReportsProto to StorageContainerDatanodeProtocolProtos.ContainerReportsProto in method public getContainerReport() : StorageContainerDatanodeProtocolProtos.ContainerReportsProto in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.hadoop.ozone.container.common.impl.TestKeyValueYaml renamed to org.apache.hadoop.ozone.container.common.impl.TestContainerDataYaml | From | To | |
| Move And Rename Class | 2 | ||
| Move And Rename Class org.apache.hadoop.ozone.container.keyvalue.KeyValueYaml.KeyValueDataConstructor moved and renamed to org.apache.hadoop.ozone.container.common.impl.ContainerDataYaml.ContainerDataConstructor | From | To | |
| Move And Rename Class org.apache.hadoop.ozone.container.keyvalue.KeyValueYaml.KeyValueContainerDataRepresenter moved and renamed to org.apache.hadoop.ozone.container.common.impl.ContainerDataYaml.ContainerDataRepresenter | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute config : Configuration to conf : Configuration in method private deleteKeyValueContainerBlocks(containerData KeyValueContainerData, delTX DeletedBlocksTransaction) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.DeleteBlocksCommandHandler | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable containerInfo : ContainerData to containerData : KeyValueContainerData in method private deleteKeyValueContainerBlocks(containerData KeyValueContainerData, delTX DeletedBlocksTransaction) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.DeleteBlocksCommandHandler | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute containerManager : ContainerManager to containerSet : ContainerSet in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.DeleteBlocksCommandHandler | From | To | |
| Rename Attribute dispatcher : ContainerDispatcher to hddsDispatcher : HddsDispatcher in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Extract Variable | 1 | ||
| Extract Variable response : VersionResponse in method public call() : EndpointStateMachine.EndPointStates from class org.apache.hadoop.ozone.container.common.states.endpoint.VersionEndpointTask | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type containerInfo : ContainerData to containerData : KeyValueContainerData in method private deleteKeyValueContainerBlocks(containerData KeyValueContainerData, delTX DeletedBlocksTransaction) : void in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.DeleteBlocksCommandHandler | From | To | |
| Change Variable Type conf : Configuration to conf : OzoneConfiguration in method public testGetVersionAssertRpcTimeOut() : void in class org.apache.hadoop.ozone.container.common.TestEndPoint | From | To | |
| Change Variable Type conf : Configuration to conf : OzoneConfiguration in method public testGetVersionToInvalidEndpoint() : void in class org.apache.hadoop.ozone.container.common.TestEndPoint | From | To | |
| Change Variable Type containerManager : ContainerManager to containerManager : ContainerSet in method private getContainerData(containerID long) : ContainerData in class org.apache.hadoop.ozone.ksm.TestContainerReportWithKeys | From | To | |
| Change Variable Type conf : Configuration to conf : OzoneConfiguration in method public testGetVersionTask() : void in class org.apache.hadoop.ozone.container.common.TestEndPoint | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type containerManager : ContainerManager to containerSet : ContainerSet in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.DeleteBlocksCommandHandler | From | To | |
| Change Attribute Type dispatcher : ContainerDispatcher to hddsDispatcher : HddsDispatcher in class org.apache.hadoop.ozone.container.ozoneimpl.OzoneContainer | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter type : ContainerType to containerType : ContainerProtos.ContainerType in method public getHandler(containerType ContainerProtos.ContainerType) : Handler in class org.apache.hadoop.ozone.container.common.impl.HddsDispatcher | From | To | |
| Rename Parameter containerManager : ContainerManager to cset : ContainerSet in method public DeleteBlocksCommandHandler(cset ContainerSet, conf Configuration) in class org.apache.hadoop.ozone.container.common.statemachine.commandhandler.DeleteBlocksCommandHandler | From | To |