547f18cb96aeda55cc19b38be2be4d631b3a5f4f
Files Diff
- Added: 11
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private parseTaskProto(proto DeletionServiceDeleteTaskProto) : DeletionTaskRecoveryInfo from class org.apache.hadoop.yarn.server.nodemanager.DeletionService to public convertProtoToFileDeletionTask(proto DeletionServiceDeleteTaskProto, deletionService DeletionService, taskId int) : FileDeletionTask from class org.apache.hadoop.yarn.server.nodemanager.api.impl.pb.NMProtoUtils | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public createFileDeletionTask(user String, subDir Path, baseDirs Path[]) : FileDeletionTask moved from class org.apache.hadoop.yarn.server.nodemanager.DeletionService to class org.apache.hadoop.yarn.server.nodemanager.TestDeletionService & inlined to public testFileDeletionTaskDependency() : void | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type subDirIncludes : String to subDirIncludes : Path in method public FileDeletionMatcher(delService DeletionService, user String, subDirIncludes Path, baseDirIncludes List<Path>) in class org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task.FileDeletionMatcher | From | To | |
| Change Parameter Type state : RecoveredDeletionServiceState to state : NMStateStoreService.RecoveredDeletionServiceState in method private recover(state NMStateStoreService.RecoveredDeletionServiceState) : void in class org.apache.hadoop.yarn.server.nodemanager.DeletionService | From | To | |
| Change Parameter Type baseDirIncludes : String[] to baseDirIncludes : List<Path> in method public FileDeletionMatcher(delService DeletionService, user String, subDirIncludes Path, baseDirIncludes List<Path>) in class org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task.FileDeletionMatcher | From | To | |
| Change Parameter Type fileDeletionTask : FileDeletionTask to deletionTask : DeletionTask in method public delete(deletionTask DeletionTask) : void in class org.apache.hadoop.yarn.server.nodemanager.DeletionService | From | To | |
| Move Method | 1 | ||
| Move Method package getLfs() : FileContext from class org.apache.hadoop.yarn.server.nodemanager.DeletionService to private getLfs() : FileContext from class org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task.FileDeletionTask | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private lfs : FileContext from class org.apache.hadoop.yarn.server.nodemanager.DeletionService to private lfs : FileContext from class org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task.FileDeletionTask | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.hadoop.yarn.server.nodemanager.TestNodeManagerReboot.FileDeletionInclude moved and renamed to org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task.FileDeletionMatcher | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type baseDirs : Path to deletionTask : DeletionTask in method protected createDeletionService() : DeletionService in class org.apache.hadoop.yarn.server.nodemanager.containermanager.BaseContainerManagerTest | From | To | |
| Change Variable Type path : Path to task : FileDeletionTask in method public answer(invocationOnMock InvocationOnMock) : Void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl.createDeletionServiceWithExpectedFile2Delete.delete.when.doNothing.doAnswer | From | To | |
| Extract Method | 2 | ||
| Extract Method private getRenamedPath(currentTime long) : Path extracted from private uploadLogsForContainers(appFinished boolean) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl | From | To | |
| Extract Method private addCredentials() : void extracted from private uploadLogsForContainers(appFinished boolean) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.AppLogAggregatorImpl | From | To | |
| Rename Method | 1 | ||
| Rename Method public scheduleFileDeletionTask(fileDeletionTask FileDeletionTask) : void renamed to public delete(deletionTask DeletionTask) : void in class org.apache.hadoop.yarn.server.nodemanager.DeletionService | From | To | |
| Rename Variable | 2 | ||
| Rename Variable args : Object[] to tasks : Object[] in method public answer(invocationOnMock InvocationOnMock) : Void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestAppLogAggregatorImpl.createDeletionServiceWithExpectedFile2Delete.delete.when.doNothing.doAnswer | From | To | |
| Rename Variable baseDirs : Path to deletionTask : DeletionTask in method protected createDeletionService() : DeletionService in class org.apache.hadoop.yarn.server.nodemanager.containermanager.BaseContainerManagerTest | From | To | |
| Change Return Type | 1 | ||
| Change Return Type DeletionTaskRecoveryInfo to FileDeletionTask in method public convertProtoToFileDeletionTask(proto DeletionServiceDeleteTaskProto, deletionService DeletionService, taskId int) : FileDeletionTask in class org.apache.hadoop.yarn.server.nodemanager.api.impl.pb.NMProtoUtils | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute exec : ContainerExecutor to containerExecutor : ContainerExecutor in class org.apache.hadoop.yarn.server.nodemanager.DeletionService | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type baseDirIncludes : String[] to baseDirIncludes : List<Path> in class org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task.FileDeletionMatcher | From | To | |
| Change Attribute Type subDirIncludes : String to subDirIncludes : Path in class org.apache.hadoop.yarn.server.nodemanager.containermanager.deletion.task.FileDeletionMatcher | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter fileDeletionTask : FileDeletionTask to deletionTask : DeletionTask in method public delete(deletionTask DeletionTask) : void in class org.apache.hadoop.yarn.server.nodemanager.DeletionService | From | To | |
| Rename Parameter exec : ContainerExecutor to containerExecutor : ContainerExecutor in method public DeletionService(containerExecutor ContainerExecutor, stateStore NMStateStoreService) in class org.apache.hadoop.yarn.server.nodemanager.DeletionService | From | To |