57a84c0d149b693c913416975cafe6de4e23c321
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method package computeReplicationWork(blocksToProcess int) : int renamed to package computeBlockRecoveryWork(blocksToProcess int) : int in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Rename Method package chooseSourceDatanode(block Block, containingNodes List<DatanodeDescriptor>, nodesContainingLiveReplicas List<DatanodeStorageInfo>, numReplicas NumberReplicas, priority int) : DatanodeDescriptor renamed to package chooseSourceDatanodes(block BlockInfo, containingNodes List<DatanodeDescriptor>, nodesContainingLiveReplicas List<DatanodeStorageInfo>, numReplicas NumberReplicas, missingBlockIndices List<Short>, numSourceNodes int, priority int) : DatanodeDescriptor[] in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Rename Method package computeReplicationWorkForBlocks(blocksToReplicate List<List<BlockInfo>>) : int renamed to package computeRecoveryWorkForBlocks(blocksToRecover List<List<BlockInfo>>) : int in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Pull Up Method | 1 | ||
| Pull Up Method public ReplicationWork(block BlockInfo, bc BlockCollection, srcNode DatanodeDescriptor, containingNodes List<DatanodeDescriptor>, liveReplicaStorages List<DatanodeStorageInfo>, additionalReplRequired int, priority int) from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork to public BlockRecoveryWork(block BlockInfo, bc BlockCollection, srcNodes DatanodeDescriptor[], containingNodes List<DatanodeDescriptor>, liveReplicaStorages List<DatanodeStorageInfo>, additionalReplRequired int, priority int) from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type block : Block to block : BlockInfo in method package chooseSourceDatanodes(block BlockInfo, containingNodes List<DatanodeDescriptor>, nodesContainingLiveReplicas List<DatanodeStorageInfo>, numReplicas NumberReplicas, missingBlockIndices List<Short>, numSourceNodes int, priority int) : DatanodeDescriptor[] in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Change Parameter Type srcNode : DatanodeDescriptor to srcNodes : DatanodeDescriptor[] in method public BlockRecoveryWork(block BlockInfo, bc BlockCollection, srcNodes DatanodeDescriptor[], containingNodes List<DatanodeDescriptor>, liveReplicaStorages List<DatanodeStorageInfo>, additionalReplRequired int, priority int) in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Rename Variable | 2 | ||
| Rename Variable srcNode : DatanodeDescriptor to srcNodes : DatanodeDescriptor[] in method package computeRecoveryWorkForBlocks(blocksToRecover List<List<BlockInfo>>) : int in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Rename Variable work : List<ReplicationWork> to recovWork : List<BlockRecoveryWork> in method package computeRecoveryWorkForBlocks(blocksToRecover List<List<BlockInfo>>) : int in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Pull Up Attribute | 7 | ||
| Pull Up Attribute private bc : BlockCollection from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork to protected bc : BlockCollection from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Pull Up Attribute private containingNodes : List<DatanodeDescriptor> from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork to protected containingNodes : List<DatanodeDescriptor> from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Pull Up Attribute private additionalReplRequired : int from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork to protected additionalReplRequired : int from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Pull Up Attribute private block : BlockInfo from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork to protected block : BlockInfo from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Pull Up Attribute private priority : int from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork to protected priority : int from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Pull Up Attribute private targets : DatanodeStorageInfo[] from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork to protected targets : DatanodeStorageInfo[] from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Pull Up Attribute private liveReplicaStorages : List<DatanodeStorageInfo> from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork to protected liveReplicaStorages : List<DatanodeStorageInfo> from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To | |
| Change Return Type | 1 | ||
| Change Return Type DatanodeDescriptor to DatanodeDescriptor[] in method package chooseSourceDatanodes(block BlockInfo, containingNodes List<DatanodeDescriptor>, nodesContainingLiveReplicas List<DatanodeStorageInfo>, numReplicas NumberReplicas, missingBlockIndices List<Short>, numSourceNodes int, priority int) : DatanodeDescriptor[] in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork from classes [org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.ReplicationWork] | From | To | |
| Change Variable Type | 5 | ||
| Change Variable Type work : List<ReplicationWork> to recovWork : List<BlockRecoveryWork> in method package computeRecoveryWorkForBlocks(blocksToRecover List<List<BlockInfo>>) : int in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Change Variable Type rw : ReplicationWork to rw : BlockRecoveryWork in method package computeRecoveryWorkForBlocks(blocksToRecover List<List<BlockInfo>>) : int in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Change Variable Type srcNode : DatanodeDescriptor to srcNodes : DatanodeDescriptor[] in method package computeRecoveryWorkForBlocks(blocksToRecover List<List<BlockInfo>>) : int in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Extract Variable | 1 | ||
| Extract Variable ecw : ErasureCodingWork in method package computeRecoveryWorkForBlocks(blocksToRecover List<List<BlockInfo>>) : int from class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter blocksToReplicate : List<List<BlockInfo>> to blocksToRecover : List<List<BlockInfo>> in method package computeRecoveryWorkForBlocks(blocksToRecover List<List<BlockInfo>>) : int in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Rename Parameter srcNode : DatanodeDescriptor to srcNodes : DatanodeDescriptor[] in method public BlockRecoveryWork(block BlockInfo, bc BlockCollection, srcNodes DatanodeDescriptor[], containingNodes List<DatanodeDescriptor>, liveReplicaStorages List<DatanodeStorageInfo>, additionalReplRequired int, priority int) in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager.BlockRecoveryWork | From | To |