580b63990825163739437a76d5e8096c4980197b
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 19
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type storageTypeProto : StorageTypeProto to storageTypeProto : OzoneManagerProtocolProtos.StorageTypeProto in method public createBucketRequest(bucketName String, volumeName String, isVersionEnabled boolean, storageTypeProto OzoneManagerProtocolProtos.StorageTypeProto) : OzoneManagerProtocolProtos.OMRequest in class org.apache.hadoop.ozone.om.request.TestOMRequestUtils | From | To | |
| Move Method | 2 | ||
| Move Method public getMetadataList() : List<HddsProtos.KeyValue> from class org.apache.hadoop.ozone.om.request.bucket.TestOMBucketCreateRequest to public getMetadataList() : List<HddsProtos.KeyValue> from class org.apache.hadoop.ozone.om.request.TestOMRequestUtils | From | To | |
| Move Method public createBucketRequest(bucketName String, volumeName String, isVersionEnabled boolean, storageTypeProto StorageTypeProto) : OMRequest from class org.apache.hadoop.ozone.om.request.bucket.TestOMBucketCreateRequest to public createBucketRequest(bucketName String, volumeName String, isVersionEnabled boolean, storageTypeProto OzoneManagerProtocolProtos.StorageTypeProto) : OzoneManagerProtocolProtos.OMRequest from class org.apache.hadoop.ozone.om.request.TestOMRequestUtils | From | To | |
| Change Return Type | 1 | ||
| Change Return Type OMRequest to OzoneManagerProtocolProtos.OMRequest in method public createBucketRequest(bucketName String, volumeName String, isVersionEnabled boolean, storageTypeProto OzoneManagerProtocolProtos.StorageTypeProto) : OzoneManagerProtocolProtos.OMRequest in class org.apache.hadoop.ozone.om.request.TestOMRequestUtils | From | To | |
| Extract Method | 1 | ||
| Extract Method public checkAcls(resType ResourceType, storeType StoreType, aclType ACLType, vol String, bucket String, key String, ugi UserGroupInformation, remoteAddress InetAddress) : void extracted from private checkAcls(resType ResourceType, store StoreType, acl ACLType, vol String, bucket String, key String) : void in class org.apache.hadoop.ozone.om.OzoneManager | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method protected createErrorOMResponse(omResponse OMResponse.Builder, ex IOException) : OMResponse extracted from public validateAndUpdateCache(ozoneManager OzoneManager, transactionLogIndex long) : OMClientResponse in class org.apache.hadoop.ozone.om.request.bucket.OMBucketCreateRequest & moved to class org.apache.hadoop.ozone.om.request.OMClientRequest | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter acl : ACLType to aclType : ACLType in method public checkAcls(resType ResourceType, storeType StoreType, aclType ACLType, vol String, bucket String, key String, ugi UserGroupInformation, remoteAddress InetAddress) : void in class org.apache.hadoop.ozone.om.OzoneManager | From | To | |
| Rename Parameter store : StoreType to storeType : StoreType in method public checkAcls(resType ResourceType, storeType StoreType, aclType ACLType, vol String, bucket String, key String, ugi UserGroupInformation, remoteAddress InetAddress) : void in class org.apache.hadoop.ozone.om.OzoneManager | From | To |