5bbca80428ffbe776650652de86a3bba885edb31
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 4 | ||
| Change Parameter Type request : ListObjectsRequest to request : S3ListRequest in method package createFileStatusListingIterator(listPath Path, request S3ListRequest, filter PathFilter, acceptor Listing.FileStatusAcceptor) : FileStatusListingIterator in class org.apache.hadoop.fs.s3a.Listing | From | To | |
| Change Parameter Type request : ListObjectsRequest to request : S3ListRequest in method package createFileStatusListingIterator(listPath Path, request S3ListRequest, filter PathFilter, acceptor Listing.FileStatusAcceptor, providedStatus RemoteIterator<FileStatus>) : FileStatusListingIterator in class org.apache.hadoop.fs.s3a.Listing | From | To | |
| Change Parameter Type objects : ObjectListing to objects : S3ListResult in method private buildNextStatusBatch(objects S3ListResult) : boolean in class org.apache.hadoop.fs.s3a.Listing.FileStatusListingIterator | From | To | |
| Change Parameter Type request : ListObjectsRequest to request : S3ListRequest in method package ObjectListingIterator(listPath Path, request S3ListRequest) in class org.apache.hadoop.fs.s3a.Listing.ObjectListingIterator | From | To | |
| Change Return Type | 2 | ||
| Change Return Type ObjectListing to S3ListResult in method public next() : S3ListResult in class org.apache.hadoop.fs.s3a.Listing.ObjectListingIterator | From | To | |
| Change Return Type ListObjectsRequest to S3ListRequest in method package createListObjectsRequest(key String, delimiter String) : S3ListRequest in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable recursiveObjectList : boolean to recursive : boolean in method private restoreDeleted(summaries List<S3ObjectSummary>, prefixes List<String>, recursive boolean, prefix String) : void in class org.apache.hadoop.fs.s3a.InconsistentAmazonS3Client | From | To | |
| Parameterize Variable outputPrefixes : List<String> to prefixes : List<String> in method private restoreDeleted(summaries List<S3ObjectSummary>, prefixes List<String>, recursive boolean, prefix String) : void in class org.apache.hadoop.fs.s3a.InconsistentAmazonS3Client | From | To | |
| Parameterize Variable outputList : List<S3ObjectSummary> to summaries : List<S3ObjectSummary> in method private restoreDeleted(summaries List<S3ObjectSummary>, prefixes List<String>, recursive boolean, prefix String) : void in class org.apache.hadoop.fs.s3a.InconsistentAmazonS3Client | From | To | |
| Change Variable Type | 4 | ||
| Change Variable Type objects : ObjectListing to objects : S3ListResult in method private s3GetFileStatus(path Path, key String, tombstones Set<Path>) : S3AFileStatus in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Variable Type objects : ObjectListing to objects : S3ListResult in method private innerDelete(status S3AFileStatus, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Variable Type request : ListObjectsRequest to request : S3ListRequest in method private innerDelete(status S3AFileStatus, recursive boolean) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Variable Type request : ListObjectsRequest to request : S3ListRequest in method public innerListStatus(f Path) : FileStatus[] in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type objects : ObjectListing to objects : S3ListResult in class org.apache.hadoop.fs.s3a.Listing.ObjectListingIterator | From | To | |
| Extract Method | 8 | ||
| Extract Method private setupListMocks(prefixes List<String>, summaries List<S3ObjectSummary>) : void extracted from public testImplicitDirectory() : void in class org.apache.hadoop.fs.s3a.TestS3AGetFileStatus | From | To | |
| Extract Method private filterPrefixes(prefixes List<String>) : List<String> extracted from private filterListObjects(request ListObjectsRequest, rawListing ObjectListing) : ObjectListing in class org.apache.hadoop.fs.s3a.InconsistentAmazonS3Client | From | To | |
| Extract Method private createListObjectsRequest(key String, delimiter String, overrideMaxKeys Integer) : S3ListRequest extracted from private s3GetFileStatus(path Path, key String, tombstones Set<Path>) : S3AFileStatus in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private setupListMocks(prefixes List<String>, summaries List<S3ObjectSummary>) : void extracted from public testRoot() : void in class org.apache.hadoop.fs.s3a.TestS3AGetFileStatus | From | To | |
| Extract Method private restoreDeleted(summaries List<S3ObjectSummary>, prefixes List<String>, recursive boolean, prefix String) : void extracted from private restoreListObjects(request ListObjectsRequest, rawListing ObjectListing) : ObjectListing in class org.apache.hadoop.fs.s3a.InconsistentAmazonS3Client | From | To | |
| Extract Method private setupListMocks(prefixes List<String>, summaries List<S3ObjectSummary>) : void extracted from public testNotFound() : void in class org.apache.hadoop.fs.s3a.TestS3AGetFileStatus | From | To | |
| Extract Method private createListObjectsRequest(key String, delimiter String, overrideMaxKeys Integer) : S3ListRequest extracted from package createListObjectsRequest(key String, delimiter String) : ListObjectsRequest in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private filterSummaries(summaries List<S3ObjectSummary>) : List<S3ObjectSummary> extracted from private filterListObjects(request ListObjectsRequest, rawListing ObjectListing) : ObjectListing in class org.apache.hadoop.fs.s3a.InconsistentAmazonS3Client | From | To |