5ec86b445cc492f52c33639efb6a09a0d2f27475
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 16
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public addDelegationTokens(renewer String, credentials Credentials) : Token<?>[] renamed to public getDelegationToken(renewer String) : Token<?> in class org.apache.hadoop.crypto.key.KeyProviderDelegationTokenExtension | From | To | |
| Rename Method public addDelegationTokens(renewer String, credentials Credentials) : Token<?>[] renamed to public getDelegationToken(renewer String) : Token<?> in class org.apache.hadoop.crypto.key.kms.KMSClientProvider | From | To | |
| Rename Method private createProvider(conf Configuration, origUrl URL, port int, hostsPart String) : KeyProvider renamed to private createProviders(conf Configuration, origUrl URL, port int, hostsPart String) : KMSClientProvider[] in class org.apache.hadoop.crypto.key.kms.KMSClientProvider.Factory | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method private collectDelegationTokens(renewer String, credentials Credentials, tokens List<Token<?>>) : void from class org.apache.hadoop.fs.FileSystem to public collectDelegationTokens(issuer DelegationTokenIssuer, renewer String, credentials Credentials, tokens List<Token<?>>) : void from class org.apache.hadoop.security.token.org.apache.hadoop.security.token.DelegationTokenIssuer | From | To | |
| Pull Up Method public addDelegationTokens(renewer String, credentials Credentials) : Token<?>[] from class org.apache.hadoop.fs.FileSystem to public addDelegationTokens(renewer String, credentials Credentials) : Token<?>[] from class org.apache.hadoop.security.token.org.apache.hadoop.security.token.DelegationTokenIssuer | From | To | |
| Change Return Type | 3 | ||
| Change Return Type KeyProvider to KMSClientProvider[] in method private createProviders(conf Configuration, origUrl URL, port int, hostsPart String) : KMSClientProvider[] in class org.apache.hadoop.crypto.key.kms.KMSClientProvider.Factory | From | To | |
| Change Return Type Token<?>[] to Token<?> in method public getDelegationToken(renewer String) : Token<?> in class org.apache.hadoop.crypto.key.kms.KMSClientProvider | From | To | |
| Change Return Type Token<?>[] to Token<?> in method public getDelegationToken(renewer String) : Token<?> in class org.apache.hadoop.crypto.key.KeyProviderDelegationTokenExtension | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable c : KMSCallable<KeyProvider> to callable : KMSCallable<T> in method private runServerWithZooKeeper(zkDTSM boolean, zkSigner boolean, callable KMSCallable<T>, kmsSize int) : T in class org.apache.hadoop.crypto.key.kms.server.TestKMS | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type c : KMSCallable<KeyProvider> to callable : KMSCallable<T> in method private runServerWithZooKeeper(zkDTSM boolean, zkSigner boolean, callable KMSCallable<T>, kmsSize int) : T in class org.apache.hadoop.crypto.key.kms.server.TestKMS | From | To | |
| Extract Variable | 2 | ||
| Extract Variable credsKey : Text in method public getKeyProviderUri(ugi UserGroupInformation, namenodeUri URI, keyProviderUriStr String, conf Configuration) : URI from class org.apache.hadoop.hdfs.HdfsKMSUtil | From | To | |
| Extract Variable tokens : Token<?>[] in method public testCreateExtension() : void from class org.apache.hadoop.crypto.key.TestKeyProviderDelegationTokenExtension | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.apache.hadoop.security.token.org.apache.hadoop.security.token.DelegationTokenIssuer from classes [org.apache.hadoop.crypto.key.KeyProviderDelegationTokenExtension, org.apache.hadoop.crypto.key.KeyProviderDelegationTokenExtension.DelegationTokenExtension, org.apache.hadoop.fs.FileSystem] | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type kmsUrl : URL to kmsUrl : List<URL> in class org.apache.hadoop.crypto.key.kms.server.TestKMS.KMSCallable | From | To | |
| Extract Method | 6 | ||
| Extract Method public getKeyProviderUri(conf Configuration, configKeyName String) : URI extracted from public createKeyProvider(conf Configuration, configKeyName String) : KeyProvider in class org.apache.hadoop.util.KMSUtil | From | To | |
| Extract Method package createAuthenticatedURL() : DelegationTokenAuthenticatedURL extracted from public renewDelegationToken(dToken Token<?>) : long in class org.apache.hadoop.crypto.key.kms.KMSClientProvider | From | To | |
| Extract Method protected runServer(ports int[], keystore String, password String, confDir File, callable KMSCallable<T>) : T extracted from protected runServer(port int, keystore String, password String, confDir File, callable KMSCallable<T>) : T in class org.apache.hadoop.crypto.key.kms.server.TestKMS | From | To | |
| Extract Method public selectDelegationToken(url URL, creds Credentials) : Token<? extends TokenIdentifier> extracted from public openConnection(url URL, token Token, doAs String) : HttpURLConnection in class org.apache.hadoop.security.token.delegation.web.DelegationTokenAuthenticatedURL | From | To | |
| Extract Method private runServerWithZooKeeper(zkDTSM boolean, zkSigner boolean, callable KMSCallable<T>) : T extracted from public doKMSWithZK(zkDTSM boolean, zkSigner boolean) : void in class org.apache.hadoop.crypto.key.kms.server.TestKMS | From | To | |
| Extract Method package createAuthenticatedURL() : DelegationTokenAuthenticatedURL extracted from public cancelDelegationToken(dToken Token<?>) : Void in class org.apache.hadoop.crypto.key.kms.KMSClientProvider | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public getKeyProviderUri(conf Configuration, configKeyName String) : URI extracted from public getKeyProviderUri(ugi UserGroupInformation, namenodeUri URI, keyProviderUriStr String, conf Configuration) : URI in class org.apache.hadoop.hdfs.HdfsKMSUtil & moved to class org.apache.hadoop.util.KMSUtil | From | To |