hadoop 5fb723bb77722d41df6959eee23e1b0cfeb5584e

5fb723bb77722d41df6959eee23e1b0cfeb5584e

Files Diff

Added: 2
Removed: 0
Renamed: 0
Modified: 22

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Merge Attribute	1
Merge Attribute [userLimit : int, userLimitFactor : float] to usersManager : UsersManager in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue	From	To
Move And Rename Method	3
Move And Rename Method private updateQueueUsageRatio(nodePartition String, delta float) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private incQueueUsageRatio(nodePartition String, delta float) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Move And Rename Method public getUsers() : ArrayList<UserInfo> from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public getUsersInfo() : ArrayList<UserInfo> from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Move And Rename Method private calculateUserUsageRatio(clusterResource Resource, nodePartition String) : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public updateUsageRatio(partition String, clusterResource Resource) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Change Parameter Type	6
Change Parameter Type activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public FiCaSchedulerApp(applicationAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, rmContext RMContext, appPriority Priority, isAttemptRecovering boolean, activitiesManager ActivitiesManager) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Change Parameter Type activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public FiCaSchedulerApp(applicationAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, rmContext RMContext, appPriority Priority, isAttemptRecovering boolean) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Change Parameter Type activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public SchedulerApplicationAttempt(applicationAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, rmContext RMContext) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt	From	To
Change Parameter Type activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public FiCaSchedulerApp(applicationAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, rmContext RMContext) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Change Parameter Type activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public AppSchedulingInfo(appAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, epoch long, appResourceUsage ResourceUsage) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo	From	To
Change Parameter Type user : LeafQueue.User to user : UsersManager.User in method public CapacityHeadroomProvider(user UsersManager.User, queue LeafQueue, application FiCaSchedulerApp, queueResourceLimitsInfo LeafQueue.QueueResourceLimitsInfo) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityHeadroomProvider	From	To
Move Method	3
Move Method public getUsageRatio(label String) : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public getUsageRatio(label String) : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Move Method private computeUserLimit(userName String, clusterResource Resource, user User, nodePartition String, schedulingMode SchedulingMode) : Resource from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private computeUserLimit(userName String, clusterResource Resource, nodePartition String, schedulingMode SchedulingMode, activeUser boolean) : Resource from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Move Method private getUserAndAddIfAbsent(userName String) : User from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public getUserAndAddIfAbsent(userName String) : User from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Move Attribute	4
Move Attribute private qUsageRatios : UsageRatios from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private qUsageRatios : UsageRatios from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Move Attribute private userLimitFactor : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private userLimitFactor : float from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Move Attribute private users : Map<String,User> from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private users : Map<String,User> from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Move Attribute private userLimit : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private userLimit : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Extract Class	1
Extract Class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue	From	To
Move Class	2
Move Class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue.UsageRatios moved to org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager.UsageRatios	From	To
Move Class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue.User moved to org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager.User	From	To
Change Variable Type	2
Change Variable Type user : LeafQueue.User to user : UsersManager.User in method private checkUserUsedResource(rm MockRM, queueName String, userName String, partition String, memory int) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestCapacitySchedulerNodeLabelUpdate	From	To
Change Variable Type fl : Float to usage : float in method private incUsageRatio(label String, delta float) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager.UsageRatios	From	To
Extract Method	1
Extract Method public getUser(userName String) : User extracted from private getUserAndAddIfAbsent(userName String) : User in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Rename Method	5
Rename Method public getActiveUsersManager() : ActiveUsersManager renamed to public getAbstractUsersManager() : ActiveUsersManager in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSParentQueue	From	To
Rename Method public getActiveUsersManager() : ActiveUsersManager renamed to public getAbstractUsersManager() : ActiveUsersManager in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue	From	To
Rename Method public getActiveUsersManager() : ActiveUsersManager renamed to public getAbstractUsersManager() : ActiveUsersManager in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.ParentQueue	From	To
Rename Method public resetAndUpdateUsageRatio(resourceCalculator ResourceCalculator, resource Resource, nodePartition String) : float renamed to public setAndUpdateUsageRatio(resourceCalculator ResourceCalculator, resource Resource, nodePartition String) : float in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager.User	From	To
Rename Method public getActiveUsersManager() : ActiveUsersManager renamed to public getUsersManager() : UsersManager in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue	From	To
Rename Variable	2
Rename Variable user : String to userName : String in method private mockApplications(appsConfig String) : void in class org.apache.hadoop.yarn.server.resourcemanager.monitor.capacity.ProportionalCapacityPreemptionPolicyMockFramework	From	To
Rename Variable fl : Float to usage : float in method private incUsageRatio(label String, delta float) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager.UsageRatios	From	To
Change Return Type	2
Change Return Type ActiveUsersManager to UsersManager in method public getUsersManager() : UsersManager in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue	From	To
Change Return Type float to void in method public updateUsageRatio(partition String, clusterResource Resource) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Rename Attribute	1
Rename Attribute activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo	From	To
Extract Interface	1
Extract Interface org.apache.hadoop.yarn.server.resourcemanager.scheduler.AbstractUsersManager from classes [org.apache.hadoop.yarn.server.resourcemanager.scheduler.ActiveUsersManager]	From	To
Change Attribute Type	4
Change Attribute Type user : LeafQueue.User to user : UsersManager.User in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.CapacityHeadroomProvider	From	To
Change Attribute Type activeApplications : int to activeApplications : AtomicInteger in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager.User	From	To
Change Attribute Type activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo	From	To
Change Attribute Type pendingApplications : int to pendingApplications : AtomicInteger in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager.User	From	To
Rename Parameter	6
Rename Parameter activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public FiCaSchedulerApp(applicationAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, rmContext RMContext, appPriority Priority, isAttemptRecovering boolean) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Rename Parameter activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public FiCaSchedulerApp(applicationAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, rmContext RMContext, appPriority Priority, isAttemptRecovering boolean, activitiesManager ActivitiesManager) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Rename Parameter activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public SchedulerApplicationAttempt(applicationAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, rmContext RMContext) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt	From	To
Rename Parameter nodePartition : String to partition : String in method public updateUsageRatio(partition String, clusterResource Resource) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.UsersManager	From	To
Rename Parameter activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public FiCaSchedulerApp(applicationAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, rmContext RMContext) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Rename Parameter activeUsersManager : ActiveUsersManager to abstractUsersManager : AbstractUsersManager in method public AppSchedulingInfo(appAttemptId ApplicationAttemptId, user String, queue Queue, abstractUsersManager AbstractUsersManager, epoch long, appResourceUsage ResourceUsage) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo	From	To

5fb723bb77722d41df6959eee23e1b0cfeb5584e

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: