hadoop 603f3ef1386048111940b66f3a0750ab84d0588f

603f3ef1386048111940b66f3a0750ab84d0588f

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 22

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Variable	5
Rename Variable future : ListenableFuture<VolumeCheckResult> to olf : Optional<ListenableFuture<VolumeCheckResult>> in method public checkVolume(volume FsVolumeSpi, callback Callback) : boolean in class org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker	From	To
Rename Variable lf1 : ListenableFuture<Boolean> to olf1 : Optional<ListenableFuture<Boolean>> in method public testConcurrentChecks() : void in class org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker	From	To
Rename Variable future : ListenableFuture<VolumeCheckResult> to olf : Optional<ListenableFuture<VolumeCheckResult>> in method public checkAllVolumesAsync(dataset FsDatasetSpi<? extends FsVolumeSpi>, callback Callback) : boolean in class org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker	From	To
Rename Variable lf : ListenableFuture<Boolean> to olf : Optional<ListenableFuture<Boolean>> in method public testCancellation() : void in class org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker	From	To
Rename Variable future : ListenableFuture<VolumeCheckResult> to olf : Optional<ListenableFuture<VolumeCheckResult>> in method public checkAllVolumes(dataset FsDatasetSpi<? extends FsVolumeSpi>) : Set<FsVolumeSpi> in class org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker	From	To
Pull Up Attribute	2
Pull Up Attribute private numChecks : AtomicLong from class org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.NoOpCheckable to protected numChecks : AtomicLong from class org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.TestCheckableBase	From	To
Pull Up Attribute private numChecks : AtomicLong from class org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.ThrowingCheckable to protected numChecks : AtomicLong from class org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.TestCheckableBase	From	To
Change Return Type	3
Change Return Type ListenableFuture<VolumeCheckResult> to Optional<ListenableFuture<VolumeCheckResult>> in method public schedule(target Checkable<VolumeCheckContext,VolumeCheckResult>, context VolumeCheckContext) : Optional<ListenableFuture<VolumeCheckResult>> in class org.apache.hadoop.hdfs.server.datanode.checker.TestDatasetVolumeChecker.DummyChecker	From	To
Change Return Type ListenableFuture<V> to Optional<ListenableFuture<V>> in method public schedule(target Checkable<K,V>, context K) : Optional<ListenableFuture<V>> in class org.apache.hadoop.hdfs.server.datanode.checker.AsyncChecker	From	To
Change Return Type ListenableFuture<V> to Optional<ListenableFuture<V>> in method public schedule(target Checkable<K,V>, context K) : Optional<ListenableFuture<V>> in class org.apache.hadoop.hdfs.server.datanode.checker.ThrottledAsyncChecker	From	To
Extract Superclass	1
Extract Superclass org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.TestCheckableBase from classes [org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.NoOpCheckable, org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker.ThrowingCheckable]	From	To
Extract Variable	1
Extract Variable added : boolean in method public checkAllVolumesAsync(dataset FsDatasetSpi<? extends FsVolumeSpi>, callback Callback) : boolean from class org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker	From	To
Change Variable Type	5
Change Variable Type lf1 : ListenableFuture<Boolean> to olf1 : Optional<ListenableFuture<Boolean>> in method public testConcurrentChecks() : void in class org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker	From	To
Change Variable Type future : ListenableFuture<VolumeCheckResult> to olf : Optional<ListenableFuture<VolumeCheckResult>> in method public checkAllVolumesAsync(dataset FsDatasetSpi<? extends FsVolumeSpi>, callback Callback) : boolean in class org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker	From	To
Change Variable Type lf : ListenableFuture<Boolean> to olf : Optional<ListenableFuture<Boolean>> in method public testCancellation() : void in class org.apache.hadoop.hdfs.server.datanode.checker.TestThrottledAsyncChecker	From	To
Change Variable Type future : ListenableFuture<VolumeCheckResult> to olf : Optional<ListenableFuture<VolumeCheckResult>> in method public checkAllVolumes(dataset FsDatasetSpi<? extends FsVolumeSpi>) : Set<FsVolumeSpi> in class org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker	From	To
Change Variable Type future : ListenableFuture<VolumeCheckResult> to olf : Optional<ListenableFuture<VolumeCheckResult>> in method public checkVolume(volume FsVolumeSpi, callback Callback) : boolean in class org.apache.hadoop.hdfs.server.datanode.checker.DatasetVolumeChecker	From	To
Extract And Move Method	38
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public flush(volume FsVolumeSpi, f Flushable) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public sync(volume FsVolumeSpi, fos FileOutputStream) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public read(b byte[]) : int in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedFileInputStream & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public mkdirsWithExistsCheck(volume FsVolumeSpi, dir File) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public exists(volume FsVolumeSpi, f File) : boolean in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public read(b byte[], off int, len int) : int in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedFileInputStream & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public replaceFile(volume FsVolumeSpi, src File, target File) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public write(b byte[]) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedFileOutputStream & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public read(b byte[]) : int in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedRandomAccessFile & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public deleteWithExistsCheck(volume FsVolumeSpi, f File) : boolean in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public getRandomAccessFile(volume FsVolumeSpi, f File, mode String) : RandomAccessFile in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public write(b int) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedRandomAccessFile & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public mkdirs(volume FsVolumeSpi, dir File) : boolean in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public posixFadvise(volume FsVolumeSpi, identifier String, outFd FileDescriptor, offset long, length long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public list(volume FsVolumeSpi, dir File) : String[] in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public getShareDeleteFileInputStream(volume FsVolumeSpi, f File, offset long) : FileInputStream in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public write(b byte[], off int, len int) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedFileOutputStream & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public listDirectory(volume FsVolumeSpi, dir File, filter FilenameFilter) : List<String> in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public fullyDelete(volume FsVolumeSpi, dir File) : boolean in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public read(b byte[], off int, len int) : int in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedRandomAccessFile & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public delete(volume FsVolumeSpi, f File) : boolean in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public createFile(volume FsVolumeSpi, f File) : boolean in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public read() : int in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedRandomAccessFile & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public read() : int in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedFileInputStream & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public moveFile(volume FsVolumeSpi, src File, target File) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public listFiles(volume FsVolumeSpi, dir File) : File[] in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public write(b int) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedFileOutputStream & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public syncFileRange(volume FsVolumeSpi, outFd FileDescriptor, offset long, numBytes long, flags int) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public getFileOutputStream(volume FsVolumeSpi, f File, append boolean) : FileOutputStream in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public move(volume FsVolumeSpi, src Path, target Path, options CopyOption...) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public write(b byte[]) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedRandomAccessFile & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public getFileInputStream(volume FsVolumeSpi, f File) : FileInputStream in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public nativeCopyFileUnbuffered(volume FsVolumeSpi, src File, target File, preserveFileDate boolean) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public openAndSeek(volume FsVolumeSpi, f File, offset long) : FileInputStream in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public getHardLinkCount(volume FsVolumeSpi, f File) : int in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public write(b byte[], off int, len int) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider.WrappedRandomAccessFile & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public rename(volume FsVolumeSpi, src File, target File) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Extract And Move Method package onFailure(datanode DataNode, volume FsVolumeSpi, op OPERATION, e Exception, begin long) : void extracted from public transferToSocketFully(volume FsVolumeSpi, sockOut SocketOutputStream, fileCh FileChannel, position long, count int, waitTime LongWritable, transferTime LongWritable) : void in class org.apache.hadoop.hdfs.server.datanode.FileIoProvider & moved to class org.apache.hadoop.hdfs.server.datanode.FileIoEvents	From	To
Rename Parameter	1
Rename Parameter errMsgr : String to failedVolumes : String in method private handleDiskError(failedVolumes String) : void in class org.apache.hadoop.hdfs.server.datanode.DataNode	From	To

603f3ef1386048111940b66f3a0750ab84d0588f

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: