hadoop 620325e81696fca140195b74929ed9eda2d5eb16

620325e81696fca140195b74929ed9eda2d5eb16

Files Diff

Added: 1
Removed: 4
Renamed: 0
Modified: 35

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	8
Rename Method public getAMBlacklist() : BlacklistManager renamed to public getAMBlacklistManager() : BlacklistManager in class org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttempt	From	To
Rename Method private sendAMContainerToNM(appAttempt RMAppAttemptImpl, containerFinishedEvent RMAppAttemptContainerFinishedEvent) : void renamed to private amContainerFinished(appAttempt RMAppAttemptImpl, containerFinishedEvent RMAppAttemptContainerFinishedEvent) : void in class org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl	From	To
Rename Method public updateBlacklist(blacklistAdditions List<String>, blacklistRemovals List<String>) : void renamed to public updatePlacesBlacklistedByApp(blacklistAdditions List<String>, blacklistRemovals List<String>) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo	From	To
Rename Method public getAMBlacklist() : BlacklistManager renamed to public getAMBlacklistManager() : BlacklistManager in class org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl	From	To
Rename Method public isBlacklisted(resourceName String, useAMBlacklist boolean) : boolean renamed to public isPlaceBlacklisted(resourceName String, blacklistedBySystem boolean) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo	From	To
Rename Method package updateUserOrAMBlacklist(blacklist Set<String>, blacklistAdditions List<String>, blacklistRemovals List<String>) : boolean renamed to private updateBlacklistedPlaces(blacklist Set<String>, blacklistAdditions List<String>, blacklistRemovals List<String>) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo	From	To
Rename Method public isBlacklisted(application SchedulerApplicationAttempt, node SchedulerNode, LOG Log) : boolean renamed to public isPlaceBlacklisted(application SchedulerApplicationAttempt, node SchedulerNode, log Log) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerAppUtils	From	To
Rename Method public isBlacklisted(resourceName String) : boolean renamed to public isPlaceBlacklisted(resourceName String) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt	From	To
Move And Rename Method	1
Move And Rename Method private testAMBlacklistPreventRestartOnSameNode(singleNode boolean, conf YarnConfiguration) : void from class org.apache.hadoop.yarn.server.resourcemanager.applicationsmanager.TestAMRestart to public testNodeBlacklistingOnAMFailure() : void from class org.apache.hadoop.yarn.server.resourcemanager.TestNodeBlacklistingOnAMFailures	From	To
Rename Variable	2
Rename Variable useAMBlacklist : boolean to forAMContainer : boolean in method public isPlaceBlacklisted(resourceName String) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt	From	To
Rename Variable currentAMBlacklist : BlacklistManager to currentAMBlacklistManager : BlacklistManager in method private createNewAttempt(appAttemptId ApplicationAttemptId) : void in class org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl	From	To
Change Return Type	3
Change Return Type BlacklistUpdates to ResourceBlacklistRequest in method public getBlacklistUpdates() : ResourceBlacklistRequest in class org.apache.hadoop.yarn.server.resourcemanager.blacklist.BlacklistManager	From	To
Change Return Type BlacklistUpdates to ResourceBlacklistRequest in method public getBlacklistUpdates() : ResourceBlacklistRequest in class org.apache.hadoop.yarn.server.resourcemanager.blacklist.DisabledBlacklistManager	From	To
Change Return Type BlacklistUpdates to ResourceBlacklistRequest in method public getBlacklistUpdates() : ResourceBlacklistRequest in class org.apache.hadoop.yarn.server.resourcemanager.blacklist.SimpleBlacklistManager	From	To
Rename Attribute	4
Rename Attribute MINIMUM_THRESHOLD_VALUE : float to MINIMUM_AM_BLACKLIST_THRESHOLD_VALUE : float in class org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl	From	To
Rename Attribute rmBlacklistedNodesForAMLaunches : String to nodesBlacklistedBySystem : String in class org.apache.hadoop.yarn.server.resourcemanager.webapp.dao.AppAttemptInfo	From	To
Rename Attribute MAXIMUM_THRESHOLD_VALUE : float to MAXIMUM_AM_BLACKLIST_THRESHOLD_VALUE : float in class org.apache.hadoop.yarn.server.resourcemanager.rmapp.RMAppImpl	From	To
Rename Attribute AM_BLACKLISTING_DISABLE_THRESHOLD : String to AM_SCHEDULING_NODE_BLACKLISTING_DISABLE_THRESHOLD : String in class org.apache.hadoop.yarn.conf.YarnConfiguration	From	To
Extract Variable	2
Extract Variable containerStatus : ContainerStatus in method private amContainerFinished(appAttempt RMAppAttemptImpl, containerFinishedEvent RMAppAttemptContainerFinishedEvent) : void from class org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl	From	To
Extract Variable exitStatus : int in method private amContainerFinished(appAttempt RMAppAttemptImpl, containerFinishedEvent RMAppAttemptContainerFinishedEvent) : void from class org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl	From	To
Change Variable Type	5
Change Variable Type blacklist : BlacklistUpdates to blacklist : ResourceBlacklistRequest in method public testSimpleBlacklistBelowFailureThreshold() : void in class org.apache.hadoop.yarn.server.resourcemanager.blacklist.TestBlacklistManager	From	To
Change Variable Type ret : BlacklistUpdates to ret : ResourceBlacklistRequest in method public getBlacklistUpdates() : ResourceBlacklistRequest in class org.apache.hadoop.yarn.server.resourcemanager.blacklist.SimpleBlacklistManager	From	To
Change Variable Type amBlacklist : BlacklistUpdates to amBlacklist : ResourceBlacklistRequest in method public transition(appAttempt RMAppAttemptImpl, event RMAppAttemptEvent) : RMAppAttemptState in class org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl.ScheduleTransition	From	To
Change Variable Type blacklist : BlacklistUpdates to blacklist : ResourceBlacklistRequest in method public testSimpleBlacklistAboveFailureThreshold() : void in class org.apache.hadoop.yarn.server.resourcemanager.blacklist.TestBlacklistManager	From	To
Change Variable Type blacklist : BlacklistUpdates to blacklist : ResourceBlacklistRequest in method public testDisabledBlacklist() : void in class org.apache.hadoop.yarn.server.resourcemanager.blacklist.TestBlacklistManager	From	To
Extract Method	2
Extract Method private startRM(conf YarnConfiguration, dispatcher DrainDispatcher) : MockRM extracted from private testAMBlacklistPreventRestartOnSameNode(singleNode boolean, conf YarnConfiguration) : void in class org.apache.hadoop.yarn.server.resourcemanager.TestNodeBlacklistingOnAMFailures	From	To
Extract Method private makeAMContainerExit(rm MockRM, amContainer ContainerId, node MockNM, exitStatus int) : void extracted from private testAMBlacklistPreventRestartOnSameNode(singleNode boolean, conf YarnConfiguration) : void in class org.apache.hadoop.yarn.server.resourcemanager.TestNodeBlacklistingOnAMFailures	From	To
Change Attribute Type	1
Change Attribute Type noBlacklist : BlacklistUpdates to noBlacklist : ResourceBlacklistRequest in class org.apache.hadoop.yarn.server.resourcemanager.blacklist.DisabledBlacklistManager	From	To
Rename Parameter	3
Rename Parameter useAMBlacklist : boolean to blacklistedBySystem : boolean in method public isPlaceBlacklisted(resourceName String, blacklistedBySystem boolean) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo	From	To
Rename Parameter amBlacklist : BlacklistManager to amBlacklistManager : BlacklistManager in method public RMAppAttemptImpl(appAttemptId ApplicationAttemptId, rmContext RMContext, scheduler YarnScheduler, masterService ApplicationMasterService, submissionContext ApplicationSubmissionContext, conf Configuration, maybeLastAttempt boolean, amReq ResourceRequest, amBlacklistManager BlacklistManager) in class org.apache.hadoop.yarn.server.resourcemanager.rmapp.attempt.RMAppAttemptImpl	From	To
Rename Parameter LOG : Log to log : Log in method public isPlaceBlacklisted(application SchedulerApplicationAttempt, node SchedulerNode, log Log) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerAppUtils	From	To

620325e81696fca140195b74929ed9eda2d5eb16

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: