621b43e254afaff708cd6fc4698b29628f6abc33
Files Diff
- Added: 46
- Removed: 0
- Renamed: 0
- Modified: 55
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 6 | ||
| Rename Variable upload : Upload to info : UploadInfo in method private createEmptyObject(objectName String) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Variable nestedDirectory : Path to pathABC : Path in method public testListStatusEncryptedFile() : void in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC | From | To | |
| Rename Variable request : ListObjectsRequest to dstMetas : List<PathMetadata> in method private innerRename(source Path, dest Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Variable nestedDirectory : Path to pathABC : Path in method public testDeleteEncryptedObjectWithDifferentKey() : void in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC | From | To | |
| Rename Variable upload : Upload to info : UploadInfo in method public close() : void in class org.apache.hadoop.fs.s3a.S3AOutputStream | From | To | |
| Rename Variable nestedDirectory : Path to pathABC : Path in method public testListStatusEncryptedDir() : void in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC | From | To | |
| Change Return Type | 4 | ||
| Change Return Type boolean to Tristate in method public isEmptyDirectory() : Tristate in class org.apache.hadoop.fs.s3a.S3AFileStatus | From | To | |
| Change Return Type Upload to UploadInfo in method public putObject(putObjectRequest PutObjectRequest) : UploadInfo in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Return Type S3AFileStatus to FileStatus in method public getFileStatus(f Path) : FileStatus in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Return Type void to int in method private putObject() : int in class org.apache.hadoop.fs.s3a.S3ABlockOutputStream | From | To | |
| Extract Attribute | 4 | ||
| Extract Attribute private KEY_1 : String in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC | From | To | |
| Extract Attribute private TEST_FILE_LEN : int in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC | From | To | |
| Extract Attribute private KEY_2 : String in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC | From | To | |
| Extract Attribute private KEY_4 : String in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.hadoop.fs.s3a.S3ClientFactory.DefaultS3ClientFactory moved to org.apache.hadoop.fs.s3a.DefaultS3ClientFactory | From | To | |
| Change Variable Type | 15 | ||
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public testCostOfGetFileStatusOnFile() : void in class org.apache.hadoop.fs.s3a.ITestS3AFileOperationCost | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public testCopyFile() : void in class org.apache.hadoop.fs.s3a.ITestS3ACopyFromLocalFile | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public test_100_renameHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public testCostOfGetFileStatusOnMissingFile() : void in class org.apache.hadoop.fs.s3a.ITestS3AFileOperationCost | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public create(f Path, permission FsPermission, overwrite boolean, bufferSize int, replication short, blockSize long, progress Progressable) : FSDataOutputStream in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Variable Type destFileStatus : S3AFileStatus to destFileStatus : FileStatus in method public test_100_renameHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public testInvalidCredentialsFail() : void in class org.apache.hadoop.fs.s3a.ITestS3ACredentialsInURL | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public test_040_PositionedReadHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public test_010_CreateHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Change Variable Type upload : Upload to info : UploadInfo in method public close() : void in class org.apache.hadoop.fs.s3a.S3AOutputStream | From | To | |
| Change Variable Type upload : Upload to info : UploadInfo in method private createEmptyObject(objectName String) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public testUsernameFromUGI() : void in class org.apache.hadoop.fs.s3a.ITestS3AConfiguration | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public test_050_readHugeFile() : void in class org.apache.hadoop.fs.s3a.scale.AbstractSTestS3AHugeFiles | From | To | |
| Change Variable Type status : S3AFileStatus to status : FileStatus in method public testCostOfGetFileStatusOnMissingSubPath() : void in class org.apache.hadoop.fs.s3a.ITestS3AFileOperationCost | From | To | |
| Change Variable Type request : ListObjectsRequest to dstMetas : List<PathMetadata> in method private innerRename(source Path, dest Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Variable | 4 | ||
| Extract Variable prefixes : Collection<String> in method private s3GetFileStatus(path Path, key String, tombstones Set<Path>) : S3AFileStatus from class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Variable summaries : Collection<S3ObjectSummary> in method private s3GetFileStatus(path Path, key String, tombstones Set<Path>) : S3AFileStatus from class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Variable length : long in method private innerRename(source Path, dest Path) : boolean from class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Variable acceptor : Listing.FileStatusAcceptor in method public listLocatedStatus(f Path, filter PathFilter) : RemoteIterator<LocatedFileStatus> from class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type isEmptyDirectory : boolean to isEmptyDirectory : Tristate in class org.apache.hadoop.fs.s3a.S3AFileStatus | From | To | |
| Change Attribute Type testDataStatus : S3AFileStatus to testDataStatus : FileStatus in class org.apache.hadoop.fs.s3a.scale.ITestS3AInputStreamPerformance | From | To | |
| Extract Method | 8 | ||
| Extract Method private createFileStatus(keyPath Path, isDir boolean, size long, modified Date, blockSize long, owner String) : S3AFileStatus extracted from public createFileStatus(keyPath Path, summary S3ObjectSummary, blockSize long, owner String) : S3AFileStatus in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Extract Method package createFileStatusListingIterator(listPath Path, request ListObjectsRequest, filter PathFilter, acceptor Listing.FileStatusAcceptor, providedStatus RemoteIterator<FileStatus>) : FileStatusListingIterator extracted from package createFileStatusListingIterator(listPath Path, request ListObjectsRequest, filter PathFilter, acceptor Listing.FileStatusAcceptor) : FileStatusListingIterator in class org.apache.hadoop.fs.s3a.Listing | From | To | |
| Extract Method public createAwsConf(conf Configuration) : ClientConfiguration extracted from public createS3Client(name URI) : AmazonS3 in class org.apache.hadoop.fs.s3a.DefaultS3ClientFactory | From | To | |
| Extract Method protected writeThenReadFile(path Path, len int) : void extracted from protected writeThenReadFile(name String, len int) : Path in class org.apache.hadoop.fs.s3a.AbstractS3ATestBase | From | To | |
| Extract Method private getPutRequestLength(putObjectRequest PutObjectRequest) : long extracted from public putObjectDirect(putObjectRequest PutObjectRequest) : PutObjectResult in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private innerListFiles(f Path, recursive boolean, acceptor Listing.FileStatusAcceptor) : RemoteIterator<LocatedFileStatus> extracted from public listFiles(f Path, recursive boolean) : RemoteIterator<LocatedFileStatus> in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method package innerGetFileStatus(f Path, needEmptyDirectoryFlag boolean) : S3AFileStatus extracted from public getFileStatus(f Path) : S3AFileStatus in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract Method private s3GetFileStatus(path Path, key String, tombstones Set<Path>) : S3AFileStatus extracted from public getFileStatus(f Path) : S3AFileStatus in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected writeThenReadFile(path Path, len int) : void extracted from public testRenameFile() : void in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC & moved to class org.apache.hadoop.fs.s3a.AbstractS3ATestBase | From | To | |
| Extract And Move Method protected writeThenReadFile(path Path, len int) : void extracted from public testCreateFileAndReadWithDifferentEncryptionKey() : void in class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSEC & moved to class org.apache.hadoop.fs.s3a.AbstractS3ATestBase | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter src : Path to source : Path in method private innerRename(source Path, dest Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Parameter dst : Path to dest : Path in method private innerRename(source Path, dest Path) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Parameter f : Path to p : Path in method private innerMkdirs(p Path, permission FsPermission) : boolean in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To |