6419900ac24a5493827abf9b5d90373bc1043e0b
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 18
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method package verifyParity(conf Configuration, size long, cellSize int, dataBytes byte[][], parityBytes byte[][], killedDnIndex int) : void from class org.apache.hadoop.hdfs.TestDFSStripedOutputStream to package verifyParityBlocks(conf Configuration, size long, cellSize int, dataBytes byte[][], parityBytes byte[][], killedDnIndex int[]) : void from class org.apache.hadoop.hdfs.StripedFileTestUtil | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type killedDnIndex : int to killedDnIndex : int[] in method package checkData(dfs DistributedFileSystem, srcPath Path, length int, killedDnIndex int[], oldGS long) : void in class org.apache.hadoop.hdfs.StripedFileTestUtil | From | To | |
| Change Parameter Type killedDnIndex : int to killedDnIndex : int[] in method package verifyParityBlocks(conf Configuration, size long, cellSize int, dataBytes byte[][], parityBytes byte[][], killedDnIndex int[]) : void in class org.apache.hadoop.hdfs.StripedFileTestUtil | From | To | |
| Change Parameter Type killPos : int to killPos : int[] in method private runTest(length int, killPos int[], dnIndex int[], tokenExpire boolean) : void in class org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure | From | To | |
| Change Parameter Type dnIndex : int to dnIndex : int[] in method private runTest(length int, killPos int[], dnIndex int[], tokenExpire boolean) : void in class org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure | From | To | |
| Move Method | 3 | ||
| Move Method public verifyLocatedStripedBlocks(lbs LocatedBlocks, groupSize int) : void from class org.apache.hadoop.hdfs.DFSTestUtil to public verifyLocatedStripedBlocks(lbs LocatedBlocks, groupSize int) : void from class org.apache.hadoop.hdfs.StripedFileTestUtil | From | To | |
| Move Method package checkData(dfs DistributedFileSystem, src String, length int, killedDnIndex int, oldGS long) : void from class org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure to package checkData(dfs DistributedFileSystem, srcPath Path, length int, killedDnIndex int[], oldGS long) : void from class org.apache.hadoop.hdfs.StripedFileTestUtil | From | To | |
| Move Method private sleep(ms long, op String) : void from class org.apache.hadoop.hdfs.StripedDataStreamer to package sleep(ms long, op String) : void from class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Extract Variable | 1 | ||
| Extract Variable firstGS : long in method private runTest(length int, killPos int[], dnIndex int[], tokenExpire boolean) : void from class org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type firstCellSize : int to lastStripeSize : long in method private generateParityCellsForLastStripe() : boolean in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Change Variable Type parityCellSize : int to parityCellSize : long in method private generateParityCellsForLastStripe() : boolean in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Inline Variable | 1 | ||
| Inline Variable numLocations : int in method public setExpectedLocations(block Block, targets DatanodeStorageInfo[], isStriped boolean) : void from class org.apache.hadoop.hdfs.server.blockmanagement.BlockUnderConstructionFeature | From | To | |
| Extract Method | 2 | ||
| Extract Method protected setupPipelineInternal(datanodes DatanodeInfo[], nodeStorageTypes StorageType[]) : void extracted from private setupPipelineForAppendOrRecovery() : boolean in class org.apache.hadoop.hdfs.DataStreamer | From | To | |
| Extract Method private shouldHandleExternalError() : boolean extracted from private processDatanodeError() : boolean in class org.apache.hadoop.hdfs.DataStreamer | From | To | |
| Rename Method | 2 | ||
| Rename Method package takeEndBlock(i int) : ExtendedBlock renamed to package takeStreamerUpdateResult(i int) : boolean in class org.apache.hadoop.hdfs.DFSStripedOutputStream.Coordinator | From | To | |
| Rename Method private processDatanodeError() : boolean renamed to private processDatanodeOrExternalError() : boolean in class org.apache.hadoop.hdfs.DataStreamer | From | To | |
| Rename Variable | 1 | ||
| Rename Variable firstCellSize : int to lastStripeSize : long in method private generateParityCellsForLastStripe() : boolean in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Inline Method | 3 | ||
| Inline Method package callUpdateBlockForPipeline(newBlock ExtendedBlock) : LocatedBlock inlined to private updateBlockForPipeline() : LocatedBlock in class org.apache.hadoop.hdfs.DataStreamer | From | To | |
| Inline Method package callUpdatePipeline(oldBlock ExtendedBlock, newBlock ExtendedBlock, newNodes DatanodeInfo[], newStorageIDs String[]) : ExtendedBlock inlined to package updatePipeline(newGS long) : ExtendedBlock in class org.apache.hadoop.hdfs.DataStreamer | From | To | |
| Inline Method private handleStreamerFailure(err String, e Exception, setExternalError boolean) : void inlined to private handleStreamerFailure(err String, e Exception) : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Change Return Type | 2 | ||
| Change Return Type boolean to void in method private setupPipelineForAppendOrRecovery() : void in class org.apache.hadoop.hdfs.DataStreamer | From | To | |
| Change Return Type ExtendedBlock to boolean in method package takeStreamerUpdateResult(i int) : boolean in class org.apache.hadoop.hdfs.DFSStripedOutputStream.Coordinator | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute lastBlock : ExtendedBlock to currentBlockGroup : ExtendedBlock in method protected closeImpl() : void in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Replace Variable With Attribute s : List<StripedDataStreamer> to streamers : List<StripedDataStreamer> in method package DFSStripedOutputStream(dfsClient DFSClient, src String, stat HdfsFileStatus, flag EnumSet<CreateFlag>, progress Progressable, checksum DataChecksum, favoredNodes String[]) in class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type error : boolean to error : ErrorType in class org.apache.hadoop.hdfs.DataStreamer.ErrorState | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method package addBlock(excludedNodes DatanodeInfo[], dfsClient DFSClient, src String, prevBlock ExtendedBlock, fileId long, favoredNodes String[]) : LocatedBlock extracted from package locateFollowingBlock(excludedNodes DatanodeInfo[]) : LocatedBlock in class org.apache.hadoop.hdfs.DataStreamer & moved to class org.apache.hadoop.hdfs.DFSOutputStream | From | To | |
| Extract And Move Method package flushAllInternals() : void extracted from public flushInternal(out DFSStripedOutputStream) : ExtendedBlock in class org.apache.hadoop.hdfs.DFSTestUtil & moved to class org.apache.hadoop.hdfs.DFSStripedOutputStream | From | To |