662e17b46a0f41ade6a304e12925b70b5d09fc2f
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 11
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type datanode : DataNode to fromDir : File in method private linkAllBlocks(fromDir File, toDir File, diskLayoutVersion int, conf Configuration) : void in class org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceStorage | From | To | |
| Rename Variable | 1 | ||
| Rename Variable successVolumes : List<StorageLocation> to success : List<StorageLocation> in method private loadDataStorage(datanode DataNode, nsInfo NamespaceInfo, dataDirs Collection<StorageLocation>, startOpt StartupOption) : List<StorageLocation> in class org.apache.hadoop.hdfs.server.datanode.DataStorage | From | To | |
| Change Return Type | 4 | ||
| Change Return Type void to List<StorageDirectory> in method package recoverTransitionRead(nsInfo NamespaceInfo, dataDirs Collection<File>, startOpt StartupOption, conf Configuration) : List<StorageDirectory> in class org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceStorage | From | To | |
| Change Return Type void to boolean in method private doTransition(sd StorageDirectory, nsInfo NamespaceInfo, startOpt StartupOption, conf Configuration) : boolean in class org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceStorage | From | To | |
| Change Return Type List<StorageLocation> to List<StorageDirectory> in method package addStorageLocations(datanode DataNode, nsInfo NamespaceInfo, dataDirs Collection<StorageLocation>, startOpt StartupOption) : List<StorageDirectory> in class org.apache.hadoop.hdfs.server.datanode.DataStorage | From | To | |
| Change Return Type void to boolean in method private doTransition(sd StorageDirectory, nsInfo NamespaceInfo, startOpt StartupOption, conf Configuration) : boolean in class org.apache.hadoop.hdfs.server.datanode.DataStorage | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type addedLocation : List<StorageLocation> to addedLocation : List<StorageDirectory> in method public testAddStorageDirectories() : void in class org.apache.hadoop.hdfs.server.datanode.TestDataStorage | From | To | |
| Extract Variable | 1 | ||
| Extract Variable loaded : List<StorageDirectory> in method package recoverTransitionRead(nsInfo NamespaceInfo, dataDirs Collection<File>, startOpt StartupOption, conf Configuration) : List<StorageDirectory> from class org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceStorage | From | To | |
| Inline Variable | 1 | ||
| Inline Variable bpid : String in method public prepareVolume(datanode DataNode, volume File, nsInfos List<NamespaceInfo>) : VolumeBuilder from class org.apache.hadoop.hdfs.server.datanode.DataStorage | From | To | |
| Extract Method | 5 | ||
| Extract Method private createStorageID(sd StorageDirectory, lv int) : boolean extracted from private doTransition(datanode DataNode, sd StorageDirectory, nsInfo NamespaceInfo, startOpt StartupOption) : void in class org.apache.hadoop.hdfs.server.datanode.DataStorage | From | To | |
| Extract Method package getBlockPoolSliceStorage(nsInfo NamespaceInfo) : BlockPoolSliceStorage extracted from public prepareVolume(datanode DataNode, volume File, nsInfos List<NamespaceInfo>) : VolumeBuilder in class org.apache.hadoop.hdfs.server.datanode.DataStorage | From | To | |
| Extract Method private loadDataStorage(datanode DataNode, nsInfo NamespaceInfo, dataDirs Collection<StorageLocation>, startOpt StartupOption) : List<StorageLocation> extracted from package addStorageLocations(datanode DataNode, nsInfo NamespaceInfo, dataDirs Collection<StorageLocation>, startOpt StartupOption) : List<StorageLocation> in class org.apache.hadoop.hdfs.server.datanode.DataStorage | From | To | |
| Extract Method private doUgrade(name String, bpSd StorageDirectory, nsInfo NamespaceInfo, bpPrevDir File, bpTmpDir File, bpCurDir File, oldLV int, conf Configuration) : void extracted from package doUpgrade(datanode DataNode, bpSd StorageDirectory, nsInfo NamespaceInfo) : void in class org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceStorage | From | To | |
| Extract Method private doUgrade(sd StorageDirectory, nsInfo NamespaceInfo, prevDir File, tmpDir File, bbwDir File, toDir File, oldLV int, conf Configuration) : void extracted from package doUpgrade(datanode DataNode, sd StorageDirectory, nsInfo NamespaceInfo) : void in class org.apache.hadoop.hdfs.server.datanode.DataStorage | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter datanode : DataNode to fromDir : File in method private linkAllBlocks(fromDir File, toDir File, diskLayoutVersion int, conf Configuration) : void in class org.apache.hadoop.hdfs.server.datanode.BlockPoolSliceStorage | From | To |