671fd6524b2640474de2bc3b8dbaa0a3cf7fcf01
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method package getBuffer() : ByteBuffer renamed to package getLastSuccessfulFlushIndex() : int in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To | |
| Rename Method private handleCloseContainerException(streamEntry ChunkOutputStreamEntry, streamIndex int) : void renamed to private handleException(streamEntry ChunkOutputStreamEntry, streamIndex int) : void in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method private fixedLengthString(string String, length int) : String from class org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient to public getFixedLengthString(string String, length int) : String from class org.apache.hadoop.ozone.container.ContainerTestHelper | From | To | |
| Change Return Type | 5 | ||
| Change Return Type CompletableFuture<ContainerCommandResponseProto> to XceiverClientAsyncReply in method public abstract sendCommandAsync(request ContainerCommandRequestProto) : XceiverClientAsyncReply in class org.apache.hadoop.hdds.scm.XceiverClientSpi | From | To | |
| Change Return Type CompletableFuture<ContainerCommandResponseProto> to XceiverClientAsyncReply in method public sendCommandAsync(request ContainerCommandRequestProto) : XceiverClientAsyncReply in class org.apache.hadoop.hdds.scm.XceiverClientGrpc | From | To | |
| Change Return Type CompletableFuture<ContainerCommandResponseProto> to XceiverClientAsyncReply in method private sendCommandAsync(request ContainerCommandRequestProto, dn DatanodeDetails) : XceiverClientAsyncReply in class org.apache.hadoop.hdds.scm.XceiverClientGrpc | From | To | |
| Change Return Type ByteBuffer to int in method package getLastSuccessfulFlushIndex() : int in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.ChunkOutputStreamEntry | From | To | |
| Change Return Type CompletableFuture<ContainerCommandResponseProto> to XceiverClientAsyncReply in method public sendCommandAsync(request ContainerCommandRequestProto) : XceiverClientAsyncReply in class org.apache.hadoop.hdds.scm.XceiverClientRatis | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private maxRetries : int from class org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient to private maxRetries : int from class org.apache.hadoop.ozone.client.rpc.TestFailureHandlingByClient | From | To | |
| Replace Variable With Attribute | 2 | ||
| Replace Variable With Attribute rollbackPosition : int to lastFlushPos : int in method public flush() : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Replace Variable With Attribute rollbackPosition : int to lastFlushPos : int in method public write(b byte[], off int, len int) : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Rename Attribute | 7 | ||
| Rename Attribute retryPolicy : RetryPolicy to watchTimeout : long in class org.apache.hadoop.ozone.client.rpc.RpcClient | From | To | |
| Rename Attribute factor : HddsProtos.ReplicationFactor to watchTimeout : long in class org.apache.hadoop.ozone.web.storage.DistributedStorageHandler | From | To | |
| Rename Attribute retryPolicy : RetryPolicy to streamBufferMaxSize : long in class org.apache.hadoop.ozone.web.storage.DistributedStorageHandler | From | To | |
| Rename Attribute type : HddsProtos.ReplicationType to blockSize : long in class org.apache.hadoop.ozone.web.storage.DistributedStorageHandler | From | To | |
| Rename Attribute OZONE_CLIENT_RETRY_INTERVAL : String to OZONE_CLIENT_WATCH_REQUEST_TIMEOUT : String in class org.apache.hadoop.ozone.OzoneConfigKeys | From | To | |
| Rename Attribute retryPolicy : RetryPolicy to streamBufferFlushSize : long in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.Builder | From | To | |
| Rename Attribute useRatis : boolean to streamBufferFlushSize : long in class org.apache.hadoop.ozone.web.storage.DistributedStorageHandler | From | To | |
| Extract Variable | 1 | ||
| Extract Variable replyFuture : CompletableFuture<RaftClientReply> in method public watchForCommit(index long, timeout long) : void from class org.apache.hadoop.hdds.scm.XceiverClientRatis | From | To | |
| Change Attribute Type | 6 | ||
| Change Attribute Type type : HddsProtos.ReplicationType to blockSize : long in class org.apache.hadoop.ozone.web.storage.DistributedStorageHandler | From | To | |
| Change Attribute Type retryPolicy : RetryPolicy to streamBufferFlushSize : long in class org.apache.hadoop.ozone.client.io.ChunkGroupOutputStream.Builder | From | To | |
| Change Attribute Type useRatis : boolean to streamBufferFlushSize : long in class org.apache.hadoop.ozone.web.storage.DistributedStorageHandler | From | To | |
| Change Attribute Type retryPolicy : RetryPolicy to watchTimeout : long in class org.apache.hadoop.ozone.client.rpc.RpcClient | From | To | |
| Change Attribute Type factor : HddsProtos.ReplicationFactor to watchTimeout : long in class org.apache.hadoop.ozone.web.storage.DistributedStorageHandler | From | To | |
| Change Attribute Type retryPolicy : RetryPolicy to streamBufferMaxSize : long in class org.apache.hadoop.ozone.web.storage.DistributedStorageHandler | From | To | |
| Extract Method | 1 | ||
| Extract Method private handlePartialFlush() : CompletableFuture<ContainerProtos.ContainerCommandResponseProto> extracted from public close() : void in class org.apache.hadoop.hdds.scm.storage.ChunkOutputStream | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public createKey(keyName String, type ReplicationType, size long, objectStore ObjectStore, volumeName String, bucketName String) : OzoneOutputStream extracted from private createKey(keyName String, type ReplicationType, size long) : OzoneOutputStream in class org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient & moved to class org.apache.hadoop.ozone.container.ContainerTestHelper | From | To | |
| Extract And Move Method public validateData(keyName String, data byte[], objectStore ObjectStore, volumeName String, bucketName String) : void extracted from private validateData(keyName String, data byte[]) : void in class org.apache.hadoop.ozone.client.rpc.TestCloseContainerHandlingByClient & moved to class org.apache.hadoop.ozone.container.ContainerTestHelper | From | To |