6c25dbcdc0517a825b92fb16444aa1d3761e160c
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 10
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private takeAllResource(queueName String) : void renamed to private takeAllResources(queueName String) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption | From | To | |
Change Parameter Type | 1 | ||
Change Parameter Type fairshare : Boolean to fairshare : boolean in method public TestFairSchedulerPreemption(name String, fairshare boolean) in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption | From | To | |
Rename Variable | 1 | ||
Rename Variable appPendingDemand : Resource to appMinShare : Resource in method private updateStarvedAppsMinshare(appsWithDemand TreeSet<FSAppAttempt>, minShareStarvation Resource) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue | From | To | |
Change Return Type | 2 | ||
Change Return Type Collection<Boolean[]> to Collection<Object[]> in method public getParameters() : Collection<Object[]> in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.TestFairSchedulerPreemption | From | To | |
Change Return Type PreemptableContainers to List<RMContainer> in method private identifyContainersToPreempt(starvedApp FSAppAttempt) : List<RMContainer> in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSPreemptionThread | From | To | |
Extract Method | 3 | ||
Extract Method private isNodeAlreadyReserved(node FSSchedulerNode, app FSAppAttempt) : boolean extracted from private identifyContainersToPreempt(starvedApp FSAppAttempt) : PreemptableContainers in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSPreemptionThread | From | To | |
Extract Method private updateStarvedAppsFairshare(appsWithDemand TreeSet<FSAppAttempt>) : Resource extracted from private updateStarvedApps() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue | From | To | |
Extract Method private updateStarvedAppsMinshare(appsWithDemand TreeSet<FSAppAttempt>, minShareStarvation Resource) : void extracted from private updateStarvedApps() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue | From | To | |
Extract And Move Method | 2 | ||
Extract And Move Method public subtractFromNonNegative(lhs Resource, rhs Resource) : Resource extracted from private subtractResourcesOnBlacklistedNodes(availableResources Resource) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSAppAttempt & moved to class org.apache.hadoop.yarn.util.resource.Resources | From | To | |
Extract And Move Method public subtractFromNonNegative(lhs Resource, rhs Resource) : Resource extracted from private updateStarvedApps() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FSLeafQueue & moved to class org.apache.hadoop.yarn.util.resource.Resources | From | To |