6c348c56918973fd988b110e79231324a8befe12
Files Diff
- Added: 14
- Removed: 3
- Renamed: 0
- Modified: 21
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Attribute | 6 | ||
| Pull Up Attribute public KEY_DIRECTORY_COUNT : String from class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase to public KEY_DIRECTORY_COUNT : String from class org.apache.hadoop.fs.s3a.S3ATestConstants | From | To | |
| Pull Up Attribute private queueingPermits : Semaphore from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to private queueingPermits : Semaphore from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Attribute public DEFAULT_CSVTEST_ENDPOINT : String from class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase to public DEFAULT_CSVTEST_ENDPOINT : String from class org.apache.hadoop.fs.s3a.S3ATestConstants | From | To | |
| Pull Up Attribute public KEY_CSVTEST_ENDPOINT : String from class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase to public KEY_CSVTEST_ENDPOINT : String from class org.apache.hadoop.fs.s3a.S3ATestConstants | From | To | |
| Pull Up Attribute private executorDelegatee : ListeningExecutorService from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to private executorDelegatee : ListeningExecutorService from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Attribute public DEFAULT_DIRECTORY_COUNT : int from class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase to public DEFAULT_DIRECTORY_COUNT : int from class org.apache.hadoop.fs.s3a.S3ATestConstants | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private LOG : Logger from class org.apache.hadoop.fs.s3a.S3AFastOutputStream to private LOG : Logger from class org.apache.hadoop.fs.s3a.S3AInstrumentation | From | To | |
| Move Attribute public testTimeout : Timeout from class org.apache.hadoop.fs.s3a.ITestS3AFastOutputStream to public testTimeout : Timeout from class org.apache.hadoop.fs.s3a.ITestBlockingThreadPoolExecutorService | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.hadoop.fs.s3a.ITestS3AEncryptionFastOutputStream renamed to org.apache.hadoop.fs.s3a.ITestS3AEncryptionBlockOutputStream | From | To | |
| Move Class | 4 | ||
| Move Class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService.CallableWithPermitRelease moved to org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor.CallableWithPermitRelease | From | To | |
| Move Class org.apache.hadoop.fs.s3a.S3AFastOutputStream.ProgressableListener moved to org.apache.hadoop.fs.s3a.S3ABlockOutputStream.ProgressableListener | From | To | |
| Move Class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService.RunnableWithPermitRelease moved to org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor.RunnableWithPermitRelease | From | To | |
| Move Class org.apache.hadoop.fs.s3a.S3AFastOutputStream.MultiPartUpload moved to org.apache.hadoop.fs.s3a.S3ABlockOutputStream.MultiPartUpload | From | To | |
| Extract Variable | 1 | ||
| Extract Variable len : long in method public uploadPart(request UploadPartRequest) : UploadPartResult from class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Inline Variable | 1 | ||
| Inline Variable totalTasks : int in method public testSubmitRunnable() : void from class org.apache.hadoop.fs.s3a.ITestBlockingThreadPoolExecutorService | From | To | |
| Extract Method | 3 | ||
| Extract Method protected verifyQueueSize(executorService ExecutorService, expectedQueueSize int) : void extracted from public testSubmitRunnable() : void in class org.apache.hadoop.fs.s3a.ITestBlockingThreadPoolExecutorService | From | To | |
| Extract Method private demandCreateConfiguration() : Configuration extracted from public setUp() : void in class org.apache.hadoop.fs.s3a.scale.S3AScaleTestBase | From | To | |
| Extract Method public createTestFileSystem(conf Configuration, purge boolean) : S3AFileSystem extracted from public createTestFileSystem(conf Configuration) : S3AFileSystem in class org.apache.hadoop.fs.s3a.S3ATestUtils | From | To | |
| Rename Method | 1 | ||
| Rename Method public BlockingThreadPoolExecutorService(activeTasks int, waitingTasks int, keepAliveTime long, unit TimeUnit, prefixName String) renamed to public newInstance(activeTasks int, waitingTasks int, keepAliveTime long, unit TimeUnit, prefixName String) : BlockingThreadPoolExecutorService in class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService | From | To | |
| Pull Up Method | 9 | ||
| Pull Up Method public invokeAny(tasks Collection<? extends Callable<T>>, timeout long, unit TimeUnit) : T from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to public invokeAny(tasks Collection<? extends Callable<T>>, timeout long, unit TimeUnit) : T from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Method public execute(command Runnable) : void from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to public execute(command Runnable) : void from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Method protected delegate() : ListeningExecutorService from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to protected delegate() : ListeningExecutorService from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Method public submit(task Runnable, result T) : ListenableFuture<T> from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to public submit(task Runnable, result T) : ListenableFuture<T> from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Method public submit(task Runnable) : ListenableFuture<?> from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to public submit(task Runnable) : ListenableFuture<?> from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Method public invokeAll(tasks Collection<? extends Callable<T>>, timeout long, unit TimeUnit) : List<Future<T>> from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to public invokeAll(tasks Collection<? extends Callable<T>>, timeout long, unit TimeUnit) : List<Future<T>> from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Method public invokeAny(tasks Collection<? extends Callable<T>>) : T from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to public invokeAny(tasks Collection<? extends Callable<T>>) : T from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Method public invokeAll(tasks Collection<? extends Callable<T>>) : List<Future<T>> from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to public invokeAll(tasks Collection<? extends Callable<T>>) : List<Future<T>> from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Pull Up Method public submit(task Callable<T>) : ListenableFuture<T> from class org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService to public submit(task Callable<T>) : ListenableFuture<T> from class org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor | From | To | |
| Rename Variable | 1 | ||
| Rename Variable dir : Path to srcDir : Path in method public testOpenCreate() : void in class org.apache.hadoop.fs.s3a.scale.ITestS3ADeleteManyFiles | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to CompleteMultipartUploadResult in method private complete(partETags List<PartETag>) : CompleteMultipartUploadResult in class org.apache.hadoop.fs.s3a.S3ABlockOutputStream.MultiPartUpload | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.fs.s3a.SemaphoredDelegatingExecutor from classes [org.apache.hadoop.fs.s3a.BlockingThreadPoolExecutorService] | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type threadPoolExecutor : ExecutorService to threadPoolExecutor : ListeningExecutorService in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Attribute Type closed : boolean to closed : AtomicBoolean in class org.apache.hadoop.fs.s3a.S3AOutputStream | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public getMultipartSizeProperty(conf Configuration, property String, defVal long) : long extracted from public initialize(name URI, conf Configuration) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem & moved to class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Extract And Move Method package createTmpFileForWrite(pathStr String, size long, conf Configuration) : File extracted from public S3AOutputStream(conf Configuration, fs S3AFileSystem, key String, progress Progressable) in class org.apache.hadoop.fs.s3a.S3AOutputStream & moved to class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To |