hadoop 6d522dc05d473d7e52f6e236c4b6bebdb91748eb

6d522dc05d473d7e52f6e236c4b6bebdb91748eb

Files Diff

Added: 5
Removed: 1
Renamed: 0
Modified: 3

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method private validateToken(identifier T, password byte[]) : boolean renamed to public verifySignature(identifier T, password byte[]) : boolean in class org.apache.hadoop.ozone.security.OzoneSecretManager	From	To
Push Down Method	13
Push Down Method private updateIdentifierDetails(identifier T) : void from class org.apache.hadoop.ozone.security.OzoneSecretManager to private updateIdentifierDetails(identifier T) : void from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method public createToken(owner Text, renewer Text, realUser Text) : Token<T> from class org.apache.hadoop.ozone.security.OzoneSecretManager to public createToken(owner Text, renewer Text, realUser Text) : Token<T> from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method public renewToken(token Token<T>, renewer String) : long from class org.apache.hadoop.ozone.security.OzoneSecretManager to public renewToken(token Token<T>, renewer String) : long from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method private removeExpiredKeys() : void from class org.apache.hadoop.ozone.security.OzoneSecretManager to private removeExpiredKeys() : void from class org.apache.hadoop.ozone.security.OzoneBlockTokenSecretManager	From	To
Push Down Method public createIdentifier() : T from class org.apache.hadoop.ozone.security.OzoneSecretManager to public createIdentifier() : T from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method public checkToken(identifier T) : TokenInfo from class org.apache.hadoop.ozone.security.OzoneSecretManager to public validateToken(identifier T) : TokenInfo from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method private addPersistedDelegationToken(identifier T, renewDate long) : void from class org.apache.hadoop.ozone.security.OzoneSecretManager to private addPersistedDelegationToken(identifier T, renewDate long) : void from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method private loadTokenSecretState(state OzoneManagerSecretState<T>) : void from class org.apache.hadoop.ozone.security.OzoneSecretManager to private loadTokenSecretState(state OzoneManagerSecretState<T>) : void from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method public createIdentifier(owner Text, renewer Text, realUser Text) : T from class org.apache.hadoop.ozone.security.OzoneSecretManager to public createIdentifier(owner Text, renewer Text, realUser Text) : T from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method private addToTokenStore(identifier T, password byte[]) : void from class org.apache.hadoop.ozone.security.OzoneSecretManager to private addToTokenStore(identifier T, password byte[]) : void from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method public cancelToken(token Token<T>, canceller String) : T from class org.apache.hadoop.ozone.security.OzoneSecretManager to public cancelToken(token Token<T>, canceller String) : T from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method private removeExpiredToken() : void from class org.apache.hadoop.ozone.security.OzoneSecretManager to private removeExpiredToken() : void from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Method public stopThreads() : void from class org.apache.hadoop.ozone.security.OzoneSecretManager to public stopThreads() : void from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Extract Subclass	2
Extract Subclass org.apache.hadoop.ozone.security.OzoneBlockTokenSecretManager from class org.apache.hadoop.ozone.security.OzoneSecretManager	From	To
Extract Subclass org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager from class org.apache.hadoop.ozone.security.OzoneSecretManager	From	To
Change Return Type	4
Change Return Type OzoneSecretManager<OzoneTokenIdentifier> to OzoneDelegationTokenSecretManager<OzoneTokenIdentifier> in method private createSecretManager(config OzoneConfiguration, tokenMaxLife long, expiry long, tokenRemoverScanTime long) : OzoneDelegationTokenSecretManager<OzoneTokenIdentifier> in class org.apache.hadoop.ozone.security.TestOzoneDelegationTokenSecretManager	From	To
Change Return Type int to AtomicInteger in method public getCurrentKeyId() : AtomicInteger in class org.apache.hadoop.ozone.security.OzoneSecretManager	From	To
Change Return Type void to OzoneSecretKey in method private updateCurrentKey(keyPair KeyPair) : OzoneSecretKey in class org.apache.hadoop.ozone.security.OzoneSecretManager	From	To
Change Return Type OzoneSecretManager to OzoneDelegationTokenSecretManager in method private createSecretManager(conf OzoneConfiguration) : OzoneDelegationTokenSecretManager in class org.apache.hadoop.ozone.om.OzoneManager	From	To
Push Down Attribute	6
Push Down Attribute private noInterruptsLock : Object from class org.apache.hadoop.ozone.security.OzoneSecretManager to private noInterruptsLock : Object from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Attribute private tokenRemoverThread : Thread from class org.apache.hadoop.ozone.security.OzoneSecretManager to private tokenRemoverThread : Thread from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Attribute private store : OzoneSecretStore from class org.apache.hadoop.ozone.security.OzoneSecretManager to private store : OzoneSecretStore from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Attribute private LOG : Logger from class org.apache.hadoop.ozone.security.OzoneSecretManager to private LOG : Logger from class org.apache.hadoop.ozone.security.OzoneBlockTokenSecretManager	From	To
Push Down Attribute private tokenRemoverScanInterval : long from class org.apache.hadoop.ozone.security.OzoneSecretManager to private tokenRemoverScanInterval : long from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Push Down Attribute private currentTokens : Map<T,TokenInfo> from class org.apache.hadoop.ozone.security.OzoneSecretManager to private currentTokens : Map<T,TokenInfo> from class org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager	From	To
Rename Class	1
Rename Class org.apache.hadoop.ozone.security.TestOzoneSecretManager renamed to org.apache.hadoop.ozone.security.TestOzoneDelegationTokenSecretManager	From	To
Move Class	1
Move Class org.apache.hadoop.ozone.security.OzoneSecretManager.ExpiredTokenRemover moved to org.apache.hadoop.ozone.security.OzoneDelegationTokenSecretManager.ExpiredTokenRemover	From	To
Change Attribute Type	2
Change Attribute Type secretManager : OzoneSecretManager to secretManager : OzoneDelegationTokenSecretManager<OzoneTokenIdentifier> in class org.apache.hadoop.ozone.om.OzoneManager	From	To
Change Attribute Type secretManager : OzoneSecretManager<OzoneTokenIdentifier> to secretManager : OzoneDelegationTokenSecretManager<OzoneTokenIdentifier> in class org.apache.hadoop.ozone.security.TestOzoneDelegationTokenSecretManager	From	To

6d522dc05d473d7e52f6e236c4b6bebdb91748eb

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: