6dea01f1ee5ea3bf6e146e1b68616c2f43ba4792
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 6
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 3 | ||
| Change Parameter Type readerStrategy : ReaderStrategy to readerStrategy : ByteBufferStrategy in method private readBuffer(blockReader BlockReader, currentNode DatanodeInfo, readerStrategy ByteBufferStrategy, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : int in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Change Parameter Type futures : Map<Future<Void>,Integer> to futures : Map<Future<T>,Integer> in method private waitNextCompletion(service CompletionService<T>, futures Map<Future<T>,Integer>) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Change Parameter Type stripedReadsService : CompletionService<Void> to service : CompletionService<T> in method private waitNextCompletion(service CompletionService<T>, futures Map<Future<T>,Integer>) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Rename Variable | 3 | ||
| Rename Variable corruptedBlockMap : Map<ExtendedBlock,Set<DatanodeInfo>> to futures : Map<Future<Integer>,Integer> in method private readOneStripe(corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Rename Variable tmpPos : long to stripeLen : long in method private readOneStripe(corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Rename Variable cellRet : int to ret : int in method public call() : Integer in class org.apache.hadoop.hdfs.DFSStripedInputStream.readCell | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type corruptedBlockMap : Map<ExtendedBlock,Set<DatanodeInfo>> to futures : Map<Future<Integer>,Integer> in method private readOneStripe(corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Change Variable Type future : Future<Void> to future : Future<T> in method private waitNextCompletion(service CompletionService<T>, futures Map<Future<T>,Integer>) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Extract Method | 2 | ||
| Extract Method private readOneStripe(corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : void extracted from protected readWithStrategy(strategy ReaderStrategy, off int, len int) : int in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Extract Method private readCell(reader BlockReader, datanode DatanodeInfo, strategy ByteBufferStrategy, targetLength int, corruptedBlockMap Map<ExtendedBlock,Set<DatanodeInfo>>) : Callable<Integer> extracted from protected readWithStrategy(strategy ReaderStrategy, off int, len int) : int in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public setStartOffsetInBlock(startOffsetInBlock long) : void extracted from public planReadPortions(dataBlkNum int, cellSize int, startInBlk long, len int, bufOffset int) : ReadPortion[] in class org.apache.hadoop.hdfs.util.StripedBlockUtil & moved to class org.apache.hadoop.hdfs.util.StripedBlockUtil.ReadPortion | From | To | |
| Extract And Move Method package addReadLength(extraLength int) : void extracted from public planReadPortions(dataBlkNum int, cellSize int, startInBlk long, len int, bufOffset int) : ReadPortion[] in class org.apache.hadoop.hdfs.util.StripedBlockUtil & moved to class org.apache.hadoop.hdfs.util.StripedBlockUtil.ReadPortion | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter stripedReadsService : CompletionService<Void> to service : CompletionService<T> in method private waitNextCompletion(service CompletionService<T>, futures Map<Future<T>,Integer>) : void in class org.apache.hadoop.hdfs.DFSStripedInputStream | From | To |