71df8c27c9a0e326232d3baf16414a63b5ea5a4b
Files Diff
- Added: 6
- Removed: 1
- Renamed: 0
- Modified: 24
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public sendHeartbeat(datanodeDetails DatanodeDetails, nodeReport NodeReportProto) : List<SCMCommand> renamed to public processHeartbeat(datanodeDetails DatanodeDetails) : List<SCMCommand> in class org.apache.hadoop.ozone.protocol.StorageContainerNodeProtocol | From | To | |
| Rename Method public sendHeartbeat(dd DatanodeDetails, nodeReport NodeReportProto) : List<SCMCommand> renamed to public processHeartbeat(dd DatanodeDetails) : List<SCMCommand> in class org.apache.hadoop.ozone.container.testutils.ReplicationNodeManagerMock | From | To | |
| Change Parameter Type | 4 | ||
| Change Parameter Type nodeStatuses : EnumSet<HddsProtos.NodeState> to nodeStatuses : HddsProtos.NodeState in method public queryNode(nodeStatuses HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.protocolPB.StorageContainerLocationProtocolClientSideTranslatorPB | From | To | |
| Change Parameter Type nodeStatuses : EnumSet<HddsProtos.NodeState> to state : HddsProtos.NodeState in method public queryNode(state HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.protocol.StorageContainerLocationProtocol | From | To | |
| Change Parameter Type nodeStatuses : EnumSet<HddsProtos.NodeState> to nodeStatuses : HddsProtos.NodeState in method public queryNode(nodeStatuses HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.client.ScmClient | From | To | |
| Change Parameter Type nodeStatuses : EnumSet<HddsProtos.NodeState> to nodeStatuses : HddsProtos.NodeState in method public queryNode(nodeStatuses HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.client.ContainerOperationClient | From | To | |
| Move Method | 2 | ||
| Move Method public run() : void from class org.apache.hadoop.hdds.scm.node.SCMNodeManager to public run() : void from class org.apache.hadoop.hdds.scm.node.NodeStateManager | From | To | |
| Move Method public removeNode(node DatanodeDetails) : void from class org.apache.hadoop.hdds.scm.node.SCMNodeManager to public removeNode(datanodeDetails DatanodeDetails) : void from class org.apache.hadoop.hdds.scm.node.NodeStateManager | From | To | |
| Inline Method | 1 | ||
| Inline Method private verifyDatanodeUUID(datanodeDetails DatanodeDetails) : RegisteredCommand inlined to public register(datanodeDetails DatanodeDetails, nodeReport NodeReportProto) : RegisteredCommand in class org.apache.hadoop.hdds.scm.node.SCMNodeManager | From | To | |
| Rename Variable | 2 | ||
| Rename Variable pool : HddsProtos.NodePool to nodes : List<HddsProtos.Node> in method public testHealthyNodesCount() : void in class org.apache.hadoop.ozone.scm.node.TestQueryNode | From | To | |
| Rename Variable nodeStateEnumSet : EnumSet<HddsProtos.NodeState> to nodeState : HddsProtos.NodeState in method public queryNode(controller RpcController, request StorageContainerLocationProtocolProtos.NodeQueryRequestProto) : StorageContainerLocationProtocolProtos.NodeQueryResponseProto in class org.apache.hadoop.ozone.protocolPB.StorageContainerLocationProtocolServerSideTranslatorPB | From | To | |
| Change Return Type | 4 | ||
| Change Return Type HddsProtos.NodePool to List<HddsProtos.Node> in method public queryNode(nodeStatuses HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.protocolPB.StorageContainerLocationProtocolClientSideTranslatorPB | From | To | |
| Change Return Type HddsProtos.NodePool to List<HddsProtos.Node> in method public queryNode(state HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.protocol.StorageContainerLocationProtocol | From | To | |
| Change Return Type HddsProtos.NodePool to List<HddsProtos.Node> in method public queryNode(nodeStatuses HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.client.ScmClient | From | To | |
| Change Return Type HddsProtos.NodePool to List<HddsProtos.Node> in method public queryNode(nodeStatuses HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.client.ContainerOperationClient | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private heartbeatCheckerIntervalMs : long from class org.apache.hadoop.hdds.scm.node.SCMNodeManager to private heartbeatCheckerIntervalMs : long from class org.apache.hadoop.hdds.scm.node.NodeStateManager | From | To | |
| Move Attribute private staleNodeIntervalMs : long from class org.apache.hadoop.hdds.scm.node.SCMNodeManager to private staleNodeIntervalMs : long from class org.apache.hadoop.hdds.scm.node.NodeStateManager | From | To | |
| Move Attribute private deadNodeIntervalMs : long from class org.apache.hadoop.hdds.scm.node.SCMNodeManager to private deadNodeIntervalMs : long from class org.apache.hadoop.hdds.scm.node.NodeStateManager | From | To | |
| Move Attribute private executorService : ScheduledExecutorService from class org.apache.hadoop.hdds.scm.node.SCMNodeManager to private executorService : ScheduledExecutorService from class org.apache.hadoop.hdds.scm.node.NodeStateManager | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.hdds.scm.node.NodeStateManager from class org.apache.hadoop.hdds.scm.node.SCMNodeManager | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type pool : HddsProtos.NodePool to nodes : List<HddsProtos.Node> in method public testHealthyNodesCount() : void in class org.apache.hadoop.ozone.scm.node.TestQueryNode | From | To | |
| Change Variable Type datanodes : HddsProtos.NodePool to datanodes : List<HddsProtos.Node> in method public queryNode(controller RpcController, request StorageContainerLocationProtocolProtos.NodeQueryRequestProto) : StorageContainerLocationProtocolProtos.NodeQueryResponseProto in class org.apache.hadoop.ozone.protocolPB.StorageContainerLocationProtocolServerSideTranslatorPB | From | To | |
| Change Variable Type nodeStateEnumSet : EnumSet<HddsProtos.NodeState> to nodeState : HddsProtos.NodeState in method public queryNode(controller RpcController, request StorageContainerLocationProtocolProtos.NodeQueryRequestProto) : StorageContainerLocationProtocolProtos.NodeQueryResponseProto in class org.apache.hadoop.ozone.protocolPB.StorageContainerLocationProtocolServerSideTranslatorPB | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter node : DatanodeDetails to datanodeDetails : DatanodeDetails in method public removeNode(datanodeDetails DatanodeDetails) : void in class org.apache.hadoop.hdds.scm.node.NodeStateManager | From | To | |
| Rename Parameter nodeStatuses : EnumSet<HddsProtos.NodeState> to state : HddsProtos.NodeState in method public queryNode(state HddsProtos.NodeState, queryScope HddsProtos.QueryScope, poolName String) : List<HddsProtos.Node> in class org.apache.hadoop.hdds.scm.protocol.StorageContainerLocationProtocol | From | To |