7594d1de7bbc34cd2e64202095a5e1757154d7d0
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 35
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public collectorAddr(collectorAddr String) : AllocateResponseBuilder renamed to public collectorInfo(collectorInfo CollectorInfo) : AllocateResponseBuilder in class org.apache.hadoop.yarn.api.protocolrecords.AllocateResponse.AllocateResponseBuilder | From | To | |
| Rename Method public setCollectorAddr(collectorAddr String) : void renamed to public setCollectorInfo(info CollectorInfo) : void in class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method private syncToken(token Token<AMRMTokenIdentifier>) : void from class org.apache.hadoop.yarn.client.TestApplicationMasterServiceProtocolOnHA to private syncToken(token Token<AMRMTokenIdentifier>) : void from class org.apache.hadoop.yarn.client.ApplicationMasterServiceProtoTestBase | From | To | |
| Pull Up Method public shutDown() : void from class org.apache.hadoop.yarn.client.TestApplicationMasterServiceProtocolOnHA to public shutDown() : void from class org.apache.hadoop.yarn.client.ApplicationMasterServiceProtoTestBase | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type collectorAddr : String to collectorInfo : CollectorInfo in method public collectorInfo(collectorInfo CollectorInfo) : AllocateResponseBuilder in class org.apache.hadoop.yarn.api.protocolrecords.AllocateResponse.AllocateResponseBuilder | From | To | |
| Change Parameter Type collectorAddr : String to info : CollectorInfo in method public setCollectorInfo(info CollectorInfo) : void in class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl | From | To | |
| Move Method | 3 | ||
| Move Method public abstract getCollectorAddr() : String from class org.apache.hadoop.yarn.api.protocolrecords.AllocateResponse to public abstract getCollectorAddr() : String from class org.apache.hadoop.yarn.api.records.CollectorInfo | From | To | |
| Move Method public getCollectorAddr() : String from class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl to public getCollectorAddr() : String from class org.apache.hadoop.yarn.api.records.impl.pb.CollectorInfoPBImpl | From | To | |
| Move Method public abstract setCollectorAddr(collectorAddr String) : void from class org.apache.hadoop.yarn.api.protocolrecords.AllocateResponse to public abstract setCollectorAddr(addr String) : void from class org.apache.hadoop.yarn.api.records.CollectorInfo | From | To | |
| Rename Variable | 1 | ||
| Rename Variable data : AppCollectorData to collectorInfo : CollectorInfo in method public allocate(appAttemptId ApplicationAttemptId, request AllocateRequest, response AllocateResponse) : void in class org.apache.hadoop.yarn.server.resourcemanager.DefaultAMSProcessor | From | To | |
| Pull Up Attribute | 2 | ||
| Pull Up Attribute private attemptId : ApplicationAttemptId from class org.apache.hadoop.yarn.client.TestApplicationMasterServiceProtocolOnHA to private attemptId : ApplicationAttemptId from class org.apache.hadoop.yarn.client.ApplicationMasterServiceProtoTestBase | From | To | |
| Pull Up Attribute private amClient : ApplicationMasterProtocol from class org.apache.hadoop.yarn.client.TestApplicationMasterServiceProtocolOnHA to private amClient : ApplicationMasterProtocol from class org.apache.hadoop.yarn.client.ApplicationMasterServiceProtoTestBase | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.yarn.api.records.CollectorInfo from class org.apache.hadoop.yarn.api.protocolrecords.AllocateResponse | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.yarn.client.ApplicationMasterServiceProtoTestBase from classes [org.apache.hadoop.yarn.client.TestApplicationMasterServiceProtocolOnHA] | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type data : AppCollectorData to collectorInfo : CollectorInfo in method public allocate(appAttemptId ApplicationAttemptId, request AllocateRequest, response AllocateResponse) : void in class org.apache.hadoop.yarn.server.resourcemanager.DefaultAMSProcessor | From | To | |
| Extract Variable | 1 | ||
| Extract Variable data : AppCollectorData in method private addRegisteringCollectorsToProto() : void from class org.apache.hadoop.yarn.server.api.protocolrecords.impl.pb.NodeHeartbeatRequestPBImpl | From | To | |
| Extract Method | 5 | ||
| Extract Method public newInstance(id ApplicationId, collectorAddr String, rmIdentifier long, version long, token Token) : AppCollectorData extracted from public newInstance(id ApplicationId, collectorAddr String, rmIdentifier long, version long) : AppCollectorData in class org.apache.hadoop.yarn.server.api.records.AppCollectorData | From | To | |
| Extract Method protected createTokenManagerService() : TimelineV2DelegationTokenSecretManagerService extracted from protected serviceInit(conf Configuration) : void in class org.apache.hadoop.yarn.server.timelineservice.collector.NodeTimelineCollectorManager | From | To | |
| Extract Method public newInstance(id ApplicationId, collectorAddr String, token Token) : AppCollectorData extracted from public newInstance(id ApplicationId, collectorAddr String) : AppCollectorData in class org.apache.hadoop.yarn.server.api.records.AppCollectorData | From | To | |
| Extract Method private publishAndVerifyEntity(appId ApplicationId, entityTypeDir File, entityType String) : void extracted from public testPutTimelineEntities() : void in class org.apache.hadoop.yarn.server.timelineservice.security.TestTimelineAuthFilterForV2 | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter collectorAddr : String to info : CollectorInfo in method public setCollectorInfo(info CollectorInfo) : void in class org.apache.hadoop.yarn.api.protocolrecords.impl.pb.AllocateResponsePBImpl | From | To | |
| Rename Parameter collectorAddr : String to collectorInfo : CollectorInfo in method public collectorInfo(collectorInfo CollectorInfo) : AllocateResponseBuilder in class org.apache.hadoop.yarn.api.protocolrecords.AllocateResponse.AllocateResponseBuilder | From | To | |
| Rename Parameter collectorAddr : String to addr : String in method public abstract setCollectorAddr(addr String) : void in class org.apache.hadoop.yarn.api.records.CollectorInfo | From | To |