77fe51e13666f7e10ce5fa7bf53b35cdcd4602b6
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type handler : RequestHandler to handler : OzoneManagerHARequestHandler in method public setHandler(handler OzoneManagerHARequestHandler) : void in class org.apache.hadoop.ozone.om.ratis.OzoneManagerStateMachine | From | To | |
| Rename Variable | 1 | ||
| Rename Variable dbVolumeKey : String to dbUserKey : String in method private deleteVolumeCommitToDB(newVolumeList VolumeList, volume String, owner String) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Return Type | 10 | ||
| Change Return Type void to OmDeleteVolumeResponse in method public deleteVolume(volume String) : OmDeleteVolumeResponse in class org.apache.hadoop.ozone.om.VolumeManager | From | To | |
| Change Return Type void to VolumeList in method public createVolume(omVolumeArgs OmVolumeArgs) : VolumeList in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Return Type void to VolumeList in method private addVolumeToOwnerList(volume String, owner String) : VolumeList in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Return Type void to OmVolumeOwnerChangeResponse in method public setOwner(volume String, owner String) : OmVolumeOwnerChangeResponse in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Return Type void to VolumeList in method private delVolumeFromOwnerList(volume String, owner String) : VolumeList in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Return Type void to OmDeleteVolumeResponse in method public deleteVolume(volume String) : OmDeleteVolumeResponse in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Return Type void to OmVolumeArgs in method public setQuota(volume String, quota long) : OmVolumeArgs in class org.apache.hadoop.ozone.om.VolumeManager | From | To | |
| Change Return Type void to VolumeList in method public createVolume(args OmVolumeArgs) : VolumeList in class org.apache.hadoop.ozone.om.VolumeManager | From | To | |
| Change Return Type void to OmVolumeArgs in method public setQuota(volume String, quota long) : OmVolumeArgs in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Return Type void to OmVolumeOwnerChangeResponse in method public setOwner(volume String, owner String) : OmVolumeOwnerChangeResponse in class org.apache.hadoop.ozone.om.VolumeManager | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable newVolumeArgs : OmVolumeArgs to newOwnerVolumeList : VolumeList in method private setOwnerCommitToDB(oldOwnerVolumeList VolumeList, newOwnerVolumeList VolumeList, newOwnerVolumeArgs OmVolumeArgs, oldOwner String) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type newVolumeArgs : OmVolumeArgs to newOwnerVolumeList : VolumeList in method private setOwnerCommitToDB(oldOwnerVolumeList VolumeList, newOwnerVolumeList VolumeList, newOwnerVolumeArgs OmVolumeArgs, oldOwner String) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type handler : RequestHandler to handler : OzoneManagerHARequestHandler in class org.apache.hadoop.ozone.om.ratis.OzoneManagerStateMachine | From | To | |
| Change Attribute Type requestHandler : RequestHandler to requestHandler : OzoneManagerHARequestHandler in class org.apache.hadoop.ozone.om.ratis.TestOzoneManagerStateMachine | From | To | |
| Extract Method | 3 | ||
| Extract Method private setOwnerCommitToDB(oldOwnerVolumeList VolumeList, newOwnerVolumeList VolumeList, newOwnerVolumeArgs OmVolumeArgs, oldOwner String) : void extracted from public setOwner(volume String, owner String) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Extract Method private createVolumeCommitToDB(omVolumeArgs OmVolumeArgs, volumeList VolumeList, dbVolumeKey String, dbUserKey String) : void extracted from public createVolume(args OmVolumeArgs) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Extract Method private deleteVolumeCommitToDB(newVolumeList VolumeList, volume String, owner String) : void extracted from public deleteVolume(volume String) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter args : OmVolumeArgs to omVolumeArgs : OmVolumeArgs in method private createVolumeCommitToDB(omVolumeArgs OmVolumeArgs, volumeList VolumeList, dbVolumeKey String, dbUserKey String) : void in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To | |
| Rename Parameter args : OmVolumeArgs to omVolumeArgs : OmVolumeArgs in method public createVolume(omVolumeArgs OmVolumeArgs) : VolumeList in class org.apache.hadoop.ozone.om.VolumeManagerImpl | From | To |