7c9cdad6d04c98db5a83e2108219bf6e6c903daf
Files Diff
- Added: 11
- Removed: 0
- Renamed: 0
- Modified: 23
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public testCopyFailOnBlockSizeDifference() : void renamed to public testCopyWithDifferentBlockSizes() : void in class org.apache.hadoop.tools.mapred.TestCopyMapper | From | To | |
| Rename Method package getMd5out() : DataOutputBuffer renamed to package getBlockChecksumBuf() : DataOutputBuffer in class org.apache.hadoop.hdfs.FileChecksumHelper.FileChecksumComputer | From | To | |
| Change Return Type | 2 | ||
| Change Return Type MD5MD5CRC32FileChecksum to FileChecksum in method package makeFinalResult() : FileChecksum in class org.apache.hadoop.hdfs.FileChecksumHelper.FileChecksumComputer | From | To | |
| Change Return Type MD5MD5CRC32FileChecksum to FileChecksum in method package getFileChecksum() : FileChecksum in class org.apache.hadoop.hdfs.FileChecksumHelper.FileChecksumComputer | From | To | |
| Push Down Attribute | 1 | ||
| Push Down Attribute private md5 : MD5Hash from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockChecksumReconstructor to private md5 : MD5Hash from class org.apache.hadoop.hdfs.server.datanode.erasurecode.StripedBlockChecksumMd5CrcReconstructor | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable toAppend : byte[] to bytes : byte[] in method public appendFileNewBlock(fs DistributedFileSystem, p Path, bytes byte[]) : void in class org.apache.hadoop.hdfs.DFSTestUtil | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute md5writer : DataOutputBuffer to blockChecksumBuf : DataOutputBuffer in class org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper.BlockGroupNonStripedChecksumComputer | From | To | |
| Rename Attribute md5out : DataOutputBuffer to blockChecksumBuf : DataOutputBuffer in class org.apache.hadoop.hdfs.FileChecksumHelper.FileChecksumComputer | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type fileChecksum : MD5MD5CRC32FileChecksum to fileChecksum : FileChecksum in class org.apache.hadoop.hdfs.FileChecksumHelper.FileChecksumComputer | From | To | |
| Extract Method | 4 | ||
| Extract Method private getFileChecksumInternal(src String, length long, combineMode ChecksumCombineMode) : FileChecksum extracted from public getFileChecksum(src String, length long) : MD5MD5CRC32FileChecksum in class org.apache.hadoop.hdfs.DFSClient | From | To | |
| Extract Method package makeMd5CrcResult() : FileChecksum extracted from package makeFinalResult() : MD5MD5CRC32FileChecksum in class org.apache.hadoop.hdfs.FileChecksumHelper.FileChecksumComputer | From | To | |
| Extract Method private computeMd5Crc() : void extracted from package compute() : void in class org.apache.hadoop.hdfs.server.datanode.BlockChecksumHelper.ReplicatedBlockChecksumComputer | From | To | |
| Extract Method public appendFileNewBlock(fs DistributedFileSystem, p Path, bytes byte[]) : void extracted from public appendFileNewBlock(fs DistributedFileSystem, p Path, length int) : void in class org.apache.hadoop.hdfs.DFSTestUtil | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method package extractChecksumProperties(checksumData OpBlockChecksumResponseProto, locatedBlock LocatedBlock, datanode DatanodeInfo, blockIdx int) : void extracted from private tryDatanode(locatedBlock LocatedBlock, datanode DatanodeInfo) : void in class org.apache.hadoop.hdfs.FileChecksumHelper.ReplicatedFileChecksumComputer & moved to class org.apache.hadoop.hdfs.FileChecksumHelper.FileChecksumComputer | From | To | |
| Extract And Move Method package extractChecksumProperties(checksumData OpBlockChecksumResponseProto, locatedBlock LocatedBlock, datanode DatanodeInfo, blockIdx int) : void extracted from private tryDatanode(blockGroup LocatedStripedBlock, stripedBlockInfo StripedBlockInfo, datanode DatanodeInfo, requestedNumBytes long) : void in class org.apache.hadoop.hdfs.FileChecksumHelper.StripedFileNonStripedChecksumComputer & moved to class org.apache.hadoop.hdfs.FileChecksumHelper.FileChecksumComputer | From | To |