7d831eca645f93d064975ebae35a7cbea3bbad31
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Pull Up Method | 2 | ||
Pull Up Method public initInternal(conf Configuration) : void from class org.apache.hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileControllerFactory.TestLogAggregationFileController to private extractRemoteRootLogDir() : void from class org.apache.hadoop.yarn.logaggregation.filecontroller.LogAggregationFileController | From | To | |
Pull Up Method public initInternal(conf Configuration) : void from class org.apache.hadoop.yarn.logaggregation.filecontroller.tfile.LogAggregationTFileController to private extractRemoteRootLogDir() : void from class org.apache.hadoop.yarn.logaggregation.filecontroller.LogAggregationFileController | From | To | |
Rename Variable | 2 | ||
Rename Variable list : LinkedList<LogAggregationFileController> to fileControllers : List<LogAggregationFileController> in method private verifyFileControllerInstance(factory LogAggregationFileControllerFactory, className Class<? extends LogAggregationFileController>) : void in class org.apache.hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileControllerFactory | From | To | |
Rename Variable remoteLogRootDir : String to controllerName : String in method private enableFileControllers(fileControllers List<Class<? extends LogAggregationFileController>>, fileControllerNames List<String>) : void in class org.apache.hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileControllerFactory | From | To | |
Change Variable Type | 2 | ||
Change Variable Type list : LinkedList<LogAggregationFileController> to list : List<LogAggregationFileController> in method public testLogAggregationFileControllerFactory() : void in class org.apache.hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileControllerFactory | From | To | |
Change Variable Type list : LinkedList<LogAggregationFileController> to fileControllers : List<LogAggregationFileController> in method private verifyFileControllerInstance(factory LogAggregationFileControllerFactory, className Class<? extends LogAggregationFileController>) : void in class org.apache.hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileControllerFactory | From | To | |
Extract Method | 2 | ||
Extract Method private enableFileControllers(fileControllers List<Class<? extends LogAggregationFileController>>, fileControllerNames List<String>) : void extracted from public testLogAggregationFileControllerFactory() : void in class org.apache.hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileControllerFactory | From | To | |
Extract Method private verifyFileControllerInstance(factory LogAggregationFileControllerFactory, className Class<? extends LogAggregationFileController>) : void extracted from public testLogAggregationFileControllerFactory() : void in class org.apache.hadoop.yarn.logaggregation.filecontroller.TestLogAggregationFileControllerFactory | From | To |