7ea24fc06c081e2ba6f5f66d212abb14b80c9064
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 14
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public testPartialBlockMovementShouldBeRetried3() : void renamed to public testPartialBlockMovementWithEmptyAttemptedQueue() : void in class org.apache.hadoop.hdfs.server.namenode.TestBlockStorageMovementAttemptedItems | From | To | |
| Move And Inline Method | 1 | ||
| Move And Inline Method public add(blockCollectionID Long) : void moved from class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementNeeded to class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems & inlined to package blocksStorageMovementUnReportedItemsCheck() : void | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type blockCollectionID : Long to itemInfo : ItemInfo in method public add(itemInfo ItemInfo, allBlockLocsAttemptedToSatisfy boolean) : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Change Parameter Type candidateNodes : List<INode> to inode : INode in method private inodeHasSatisfyXAttr(inode INode) : boolean in class org.apache.hadoop.hdfs.server.namenode.FSDirSatisfyStoragePolicyOp | From | To | |
| Inline Method | 1 | ||
| Inline Method package unprotectedSatisfyStoragePolicy(iip INodesInPath, bm BlockManager, fsd FSDirectory) : XAttr inlined to package satisfyStoragePolicy(fsd FSDirectory, bm BlockManager, src String, logRetryCache boolean) : FileStatus in class org.apache.hadoop.hdfs.server.namenode.FSDirSatisfyStoragePolicyOp | From | To | |
| Rename Variable | 3 | ||
| Rename Variable itemInfo : ItemInfo to attemptedItemInfo : AttemptedItemInfo in method public add(itemInfo ItemInfo, allBlockLocsAttemptedToSatisfy boolean) : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Rename Variable xattrs : List<XAttr> to xAttrs : List<XAttr> in method package satisfyStoragePolicy(fsd FSDirectory, bm BlockManager, src String, logRetryCache boolean) : FileStatus in class org.apache.hadoop.hdfs.server.namenode.FSDirSatisfyStoragePolicyOp | From | To | |
| Rename Variable itemInfo : ItemInfo to attemptedItemInfo : AttemptedItemInfo in method package blockStorageMovementResultCheck() : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Long to ItemInfo in method public get() : ItemInfo in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementNeeded | From | To | |
| Rename Class | 1 | ||
| Rename Class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems.ItemInfo renamed to org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems.AttemptedItemInfo | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type itemInfo : ItemInfo to attemptedItemInfo : AttemptedItemInfo in method public add(itemInfo ItemInfo, allBlockLocsAttemptedToSatisfy boolean) : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Change Variable Type entry : Entry<Long,ItemInfo> to entry : Entry<Long,AttemptedItemInfo> in method package blocksStorageMovementUnReportedItemsCheck() : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Change Variable Type itemInfo : ItemInfo to attemptedItemInfo : AttemptedItemInfo in method package blockStorageMovementResultCheck() : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Change Variable Type ele : Long to ele : ItemInfo in method private checkItemMovedForRetry(item Long, retryTimeout long) : boolean in class org.apache.hadoop.hdfs.server.namenode.TestBlockStorageMovementAttemptedItems | From | To | |
| Change Variable Type iter : Iterator<Entry<Long,ItemInfo>> to iter : Iterator<Entry<Long,AttemptedItemInfo>> in method package blocksStorageMovementUnReportedItemsCheck() : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Change Variable Type itemInfo : ItemInfo to itemInfo : AttemptedItemInfo in method package blocksStorageMovementUnReportedItemsCheck() : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type storageMovementNeeded : Queue<Long> to storageMovementNeeded : Queue<ItemInfo> in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementNeeded | From | To | |
| Change Attribute Type storageMovementAttemptedItems : Map<Long,ItemInfo> to storageMovementAttemptedItems : Map<Long,AttemptedItemInfo> in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter blockCollectionID : Long to itemInfo : ItemInfo in method public add(itemInfo ItemInfo, allBlockLocsAttemptedToSatisfy boolean) : void in class org.apache.hadoop.hdfs.server.namenode.BlockStorageMovementAttemptedItems | From | To | |
| Rename Parameter candidateNodes : List<INode> to inode : INode in method private inodeHasSatisfyXAttr(inode INode) : boolean in class org.apache.hadoop.hdfs.server.namenode.FSDirSatisfyStoragePolicyOp | From | To |