7f783970364930cc461d1a73833bc58cdd10553e
Files Diff
- Added: 3
- Removed: 43
- Renamed: 0
- Modified: 59
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Inline Method | 2 | ||
| Move And Inline Method public terminateService(service T) : T moved from class org.apache.hadoop.fs.s3a.S3ATestUtils to class org.apache.hadoop.fs.s3a.commit.AbstractITCommitMRJob & inlined to public teardownClusters() : void | From | To | |
| Move And Inline Method public buildAWSProviderList(binding URI, conf Configuration, key String, defaultValues List<Class<?>>, forbidden Set<Class<?>>) : AWSCredentialProviderList moved from class org.apache.hadoop.fs.s3a.S3AUtils to class org.apache.hadoop.fs.s3a.auth.AssumedRoleCredentialProvider & inlined to public AssumedRoleCredentialProvider(fsUri URI, conf Configuration) | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type expectedClasses : List<Class<?>> to expectedClasses : List<Class<? extends AWSCredentialsProvider>> in method private assertCredentialProviders(expectedClasses List<Class<? extends AWSCredentialsProvider>>, list AWSCredentialProviderList) : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Change Parameter Type e : AWSServiceIOException to e : AWSS3IOException in method protected assertStatusCode(e AWSS3IOException, code int) : void in class org.apache.hadoop.fs.s3a.AbstractS3ATestBase | From | To | |
| Move Method | 2 | ||
| Move Method public toString() : String from class org.apache.hadoop.fs.s3a.auth.AbstractSessionCredentialsProvider to public toString() : String from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider | From | To | |
| Move Method protected createConfiguration() : Configuration from class org.apache.hadoop.fs.s3a.ITestS3ATemporaryCredentials to protected createConfiguration() : Configuration from class org.apache.hadoop.fs.s3a.ITestS3AEncryptionSSECBlockOutputStream | From | To | |
| Inline Method | 7 | ||
| Inline Method private bindAWSClient(name URI, dtEnabled boolean) : void inlined to public initialize(name URI, originalConf Configuration) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Inline Method public builder(credentials AWSCredentialsProvider, awsConf ClientConfiguration, stsEndpoint String, stsRegion String) : AWSSecurityTokenServiceClientBuilder inlined to public builder(conf Configuration, bucket String, credentials AWSCredentialsProvider, stsEndpoint String, stsRegion String) : AWSSecurityTokenServiceClientBuilder in class org.apache.hadoop.fs.s3a.auth.STSClientFactory | From | To | |
| Inline Method protected setEncryptionSecrets(secrets EncryptionSecrets) : void inlined to public initialize(name URI, originalConf Configuration) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Inline Method private createProviderConfiguration(providerOption String) : Configuration inlined to public testConfiguredChain() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Inline Method protected createValidRoleConf() : Configuration inlined to public testCreateCredentialProvider() : void in class org.apache.hadoop.fs.s3a.auth.ITestAssumeRole | From | To | |
| Change Return Type | 3 | ||
| Change Return Type Optional<SSEAwsKeyManagementParams> to SSEAwsKeyManagementParams in method private generateSSEAwsKeyParams() : SSEAwsKeyManagementParams in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Return Type Optional<SSECustomerKey> to SSECustomerKey in method private generateSSECustomerKey() : SSECustomerKey in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Change Return Type List<Class<?>> to Class<?>[] in method public loadAWSProviderClasses(conf Configuration, key String, defaultValue Class<?>...) : Class<?>[] in class org.apache.hadoop.fs.s3a.S3AUtils | From | To | |
| Move Attribute | 3 | ||
| Move Attribute private sessionToken : String from class org.apache.hadoop.fs.s3a.auth.MarshalledCredentials to private sessionToken : String from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider | From | To | |
| Move Attribute private secretKey : String from class org.apache.hadoop.fs.s3a.auth.MarshalledCredentials to private secretKey : String from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider | From | To | |
| Move Attribute private accessKey : String from class org.apache.hadoop.fs.s3a.auth.MarshalledCredentials to private accessKey : String from class org.apache.hadoop.fs.s3a.TemporaryAWSCredentialsProvider | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute uaSuffix : String to username : String in method public initialize(name URI, originalConf Configuration) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute RAW_BUCKET_URI : URI to OUTPUT_PATH_URI : URI in class org.apache.hadoop.fs.s3a.commit.staging.StagingTestBase | From | To | |
| Rename Attribute outputPath : Path to OUTPUT_PATH : Path in class org.apache.hadoop.fs.s3a.commit.staging.StagingTestBase | From | To | |
| Rename Attribute TEMPORARY_AWS_CREDENTIALS : String to PROVIDER_CLASS : String in class org.apache.hadoop.fs.s3a.ITestS3ATemporaryCredentials | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type expectedClasses : List<Class<?>> to expectedClasses : List<Class<? extends AWSCredentialsProvider>> in method public testInstantiationChain() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Change Variable Type expectedClasses : List<Class<?>> to expectedClasses : List<Class<? extends AWSCredentialsProvider>> in method public testConfiguredChain() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Change Variable Type expectedClasses : List<Class<?>> to expectedClasses : List<Class<? extends AWSCredentialsProvider>> in method public testConfiguredChainUsesSharedInstanceProfile() : void in class org.apache.hadoop.fs.s3a.TestS3AAWSCredentialsProvider | From | To | |
| Inline Variable | 2 | ||
| Inline Variable exists : Path in method public testDefault() : void from class org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedTaskCommit | From | To | |
| Inline Variable existsPath : Path in method public testFail() : void from class org.apache.hadoop.fs.s3a.commit.staging.TestStagingPartitionedTaskCommit | From | To | |
| Change Attribute Type | 3 | ||
| Change Attribute Type S3_PATH_RW_OPERATIONS : List<String> to S3_PATH_RW_OPERATIONS : String[] in class org.apache.hadoop.fs.s3a.auth.RolePolicies | From | To | |
| Change Attribute Type S3_PATH_WRITE_OPERATIONS : List<String> to S3_PATH_WRITE_OPERATIONS : String[] in class org.apache.hadoop.fs.s3a.auth.RolePolicies | From | To | |
| Change Attribute Type S3_ROOT_RW_OPERATIONS : List<String> to S3_ROOT_RW_OPERATIONS : String[] in class org.apache.hadoop.fs.s3a.auth.RolePolicies | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter request : InitiateMultipartUploadRequest to req : InitiateMultipartUploadRequest in method protected setOptionalMultipartUploadRequestParameters(req InitiateMultipartUploadRequest) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To | |
| Rename Parameter fsUri : URI to uri : URI in method protected setUri(uri URI) : void in class org.apache.hadoop.fs.s3a.S3AFileSystem | From | To |