82c9e061017c32e633e0b0cbb7978749a6df4fb2
Files Diff
- Added: 5
- Removed: 3
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Merge Attribute | 2 | ||
| Merge Attribute [nodeTokens : Map<NodeId,NMToken>, appParams : DistributedSchedulerParams, containerIdCounter : OpportunisticContainerAllocator.ContainerIdCounter, nodeList : Map<String,NodeId>] to oppContainerContext : OpportunisticContainerContext in class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler | From | To | |
| Merge Attribute [nodeTokens : Map<NodeId,NMToken>, containersAllocated : Set<ContainerId>] to oppContainerContext : OpportunisticContainerContext in class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type nodeStatusUpdater : NodeStatusUpdater to tokenSecretManager : BaseContainerTokenSecretManager in method public OpportunisticContainerAllocator(tokenSecretManager BaseContainerTokenSecretManager, webpagePort int) in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Change Parameter Type appParams : DistributedSchedulerParams to appParams : AllocationParams in method private normalizeCapability(appParams AllocationParams, ask ResourceRequest) : Resource in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Move Method | 2 | ||
| Move Method public addToOutstandingReqs(resourceAsks List<ResourceRequest>) : void from class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler to public addToOutstandingReqs(resourceAsks List<ResourceRequest>) : void from class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Move Method private matchAllocationToOutstandingRequest(capability Resource, allocatedContainers List<Container>) : void from class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler to public matchAllocationToOutstandingRequest(capability Resource, allocatedContainers List<Container>) : void from class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Move Attribute | 4 | ||
| Move Attribute package blacklist : Set<String> from class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler to private blacklist : Set<String> from class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Move Attribute private containersAllocated : Set<ContainerId> from class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler to private containersAllocated : Set<ContainerId> from class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Move Attribute private nodeTokens : Map<NodeId,NMToken> from class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler to private nodeTokens : Map<NodeId,NMToken> from class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Move Attribute package outstandingOpReqs : TreeMap<Priority,Map<Resource,ResourceRequest>> from class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler to private outstandingOpReqs : TreeMap<Priority,Map<Resource,ResourceRequest>> from class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext from class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler | From | To | |
| Rename Class | 2 | ||
| Rename Class org.apache.hadoop.yarn.server.resourcemanager.DistributedSchedulingAMService renamed to org.apache.hadoop.yarn.server.resourcemanager.OpportunisticContainerAllocatorAMService | From | To | |
| Rename Class org.apache.hadoop.yarn.server.resourcemanager.TestDistributedSchedulingAMService renamed to org.apache.hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService | From | To | |
| Move Class | 2 | ||
| Move Class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler.PartitionedResourceRequests moved to org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator.PartitionedResourceRequests | From | To | |
| Move Class org.apache.hadoop.yarn.server.nodemanager.scheduler.OpportunisticContainerAllocator moved to org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type distributedSchedulingService : DistributedSchedulingAMService to oppContainerAllocatingAMService : OpportunisticContainerAllocatorAMService in method protected createApplicationMasterService() : ApplicationMasterService in class org.apache.hadoop.yarn.server.resourcemanager.ResourceManager | From | To | |
| Change Variable Type service : DistributedSchedulingAMService to service : OpportunisticContainerAllocatorAMService in method public testRPCWrapping() : void in class org.apache.hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService | From | To | |
| Extract Method | 1 | ||
| Extract Method private createRMClient(appContext AMRMProxyApplicationContext, conf Configuration) : ApplicationMasterProtocol extracted from public init(appContext AMRMProxyApplicationContext) : void in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.DefaultRequestInterceptor | From | To | |
| Rename Variable | 2 | ||
| Rename Variable distSchedulerEventDispatcher : EventDispatcher to oppContainerAllocEventDispatcher : EventDispatcher in method protected createApplicationMasterService() : ApplicationMasterService in class org.apache.hadoop.yarn.server.resourcemanager.ResourceManager | From | To | |
| Rename Variable distributedSchedulingService : DistributedSchedulingAMService to oppContainerAllocatingAMService : OpportunisticContainerAllocatorAMService in method protected createApplicationMasterService() : ApplicationMasterService in class org.apache.hadoop.yarn.server.resourcemanager.ResourceManager | From | To | |
| Change Return Type | 1 | ||
| Change Return Type DistributedSchedulingAMService to OpportunisticContainerAllocatorAMService in method private createService(factory RecordFactory, rmContext RMContext, c Container) : OpportunisticContainerAllocatorAMService in class org.apache.hadoop.yarn.server.resourcemanager.TestOpportunisticContainerAllocatorAMService | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute nodeStatusUpdater : NodeStatusUpdater to tokenSecretManager : BaseContainerTokenSecretManager in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type nodeStatusUpdater : NodeStatusUpdater to tokenSecretManager : BaseContainerTokenSecretManager in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Change Attribute Type rmClient : DistributedSchedulingAMProtocol to rmClient : ApplicationMasterProtocol in class org.apache.hadoop.yarn.server.nodemanager.amrmproxy.DefaultRequestInterceptor | From | To | |
| Rename Parameter | 4 | ||
| Rename Parameter containerAllocator : OpportunisticContainerAllocator to oppContainerAllocator : OpportunisticContainerAllocator in method package initLocal(rmId long, appAttemptId ApplicationAttemptId, oppContainerAllocator OpportunisticContainerAllocator, nmSecretManager NMTokenSecretManagerInNM, appSubmitter String) : void in class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler | From | To | |
| Rename Parameter nodeStatusUpdater : NodeStatusUpdater to tokenSecretManager : BaseContainerTokenSecretManager in method public OpportunisticContainerAllocator(tokenSecretManager BaseContainerTokenSecretManager, webpagePort int) in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Rename Parameter appContext : AMRMProxyApplicationContext to applicationContext : AMRMProxyApplicationContext in method public init(applicationContext AMRMProxyApplicationContext) : void in class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler | From | To | |
| Rename Parameter applicationAttemptId : ApplicationAttemptId to appAttemptId : ApplicationAttemptId in method package initLocal(rmId long, appAttemptId ApplicationAttemptId, oppContainerAllocator OpportunisticContainerAllocator, nmSecretManager NMTokenSecretManagerInNM, appSubmitter String) : void in class org.apache.hadoop.yarn.server.nodemanager.scheduler.DistributedScheduler | From | To |