hadoop 83fe34ac0896cee0918bbfad7bd51231e4aec39b

83fe34ac0896cee0918bbfad7bd51231e4aec39b

Files Diff

Added: 0
Removed: 0
Renamed: 0
Modified: 16

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Move Method	14
Move Method package shouldAllocOrReserveNewContainer(application FiCaSchedulerApp, priority Priority, required Resource) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to package shouldAllocOrReserveNewContainer(priority Priority, required Resource) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private assignRackLocalContainers(clusterResource Resource, rackLocalResourceRequest ResourceRequest, node FiCaSchedulerNode, application FiCaSchedulerApp, priority Priority, reservedContainer RMContainer, allocatedContainer MutableObject, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private assignRackLocalContainers(clusterResource Resource, rackLocalResourceRequest ResourceRequest, node FiCaSchedulerNode, priority Priority, reservedContainer RMContainer, allocatedContainer MutableObject, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method package canAssign(application FiCaSchedulerApp, priority Priority, node FiCaSchedulerNode, type NodeType, reservedContainer RMContainer) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private canAssign(priority Priority, node FiCaSchedulerNode, type NodeType, reservedContainer RMContainer) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private unreserve(application FiCaSchedulerApp, priority Priority, node FiCaSchedulerNode, rmContainer RMContainer) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public unreserve(priority Priority, node FiCaSchedulerNode, rmContainer RMContainer) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private assignContainer(clusterResource Resource, node FiCaSchedulerNode, application FiCaSchedulerApp, priority Priority, request ResourceRequest, type NodeType, rmContainer RMContainer, createdContainer MutableObject, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private assignContainer(clusterResource Resource, node FiCaSchedulerNode, priority Priority, request ResourceRequest, type NodeType, rmContainer RMContainer, createdContainer MutableObject, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private reserve(application FiCaSchedulerApp, priority Priority, node FiCaSchedulerNode, rmContainer RMContainer, container Container) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public reserve(priority Priority, node FiCaSchedulerNode, rmContainer RMContainer, container Container) : void from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private getContainer(rmContainer RMContainer, application FiCaSchedulerApp, node FiCaSchedulerNode, capability Resource, priority Priority) : Container from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private getContainer(rmContainer RMContainer, node FiCaSchedulerNode, capability Resource, priority Priority) : Container from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private assignReservedContainer(application FiCaSchedulerApp, node FiCaSchedulerNode, rmContainer RMContainer, clusterResource Resource, schedulingMode SchedulingMode) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public assignReservedContainer(node FiCaSchedulerNode, rmContainer RMContainer, clusterResource Resource, schedulingMode SchedulingMode) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method protected findNodeToUnreserve(clusterResource Resource, node FiCaSchedulerNode, application FiCaSchedulerApp, priority Priority, minimumUnreservedResource Resource) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to public findNodeToUnreserve(clusterResource Resource, node FiCaSchedulerNode, priority Priority, minimumUnreservedResource Resource) : RMContainer from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method package createContainer(application FiCaSchedulerApp, node FiCaSchedulerNode, capability Resource, priority Priority) : Container from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to package createContainer(node FiCaSchedulerNode, capability Resource, priority Priority) : Container from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private assignContainersOnNode(clusterResource Resource, node FiCaSchedulerNode, application FiCaSchedulerApp, priority Priority, reservedContainer RMContainer, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private assignContainersOnNode(clusterResource Resource, node FiCaSchedulerNode, priority Priority, reservedContainer RMContainer, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private getActualNodeLocalityDelay() : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private getActualNodeLocalityDelay() : int from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private assignNodeLocalContainers(clusterResource Resource, nodeLocalResourceRequest ResourceRequest, node FiCaSchedulerNode, application FiCaSchedulerApp, priority Priority, reservedContainer RMContainer, allocatedContainer MutableObject, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private assignNodeLocalContainers(clusterResource Resource, nodeLocalResourceRequest ResourceRequest, node FiCaSchedulerNode, priority Priority, reservedContainer RMContainer, allocatedContainer MutableObject, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Move Method private assignOffSwitchContainers(clusterResource Resource, offSwitchResourceRequest ResourceRequest, node FiCaSchedulerNode, application FiCaSchedulerApp, priority Priority, reservedContainer RMContainer, allocatedContainer MutableObject, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue to private assignOffSwitchContainers(clusterResource Resource, offSwitchResourceRequest ResourceRequest, node FiCaSchedulerNode, priority Priority, reservedContainer RMContainer, allocatedContainer MutableObject, schedulingMode SchedulingMode, currentResoureLimits ResourceLimits) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Rename Variable	2
Rename Variable newTotalResource : Resource to nowTotalUsed : Resource in method package canAssignToThisQueue(clusterResource Resource, nodePartition String, currentResourceLimits ResourceLimits, resourceCouldBeUnreserved Resource, schedulingMode SchedulingMode) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.AbstractCSQueue	From	To
Rename Variable res : boolean to toUnreserveContainer : RMContainer in method public testFindNodeToUnreserve() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestReservations	From	To
Change Return Type	1
Change Return Type boolean to RMContainer in method public findNodeToUnreserve(clusterResource Resource, node FiCaSchedulerNode, priority Priority, minimumUnreservedResource Resource) : RMContainer in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To
Change Variable Type	1
Change Variable Type res : boolean to toUnreserveContainer : RMContainer in method public testFindNodeToUnreserve() : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.TestReservations	From	To
Extract And Move Method	1
Extract And Move Method public assignContainers(clusterResource Resource, node FiCaSchedulerNode, currentResourceLimits ResourceLimits, schedulingMode SchedulingMode) : CSAssignment extracted from public assignContainers(clusterResource Resource, node FiCaSchedulerNode, currentResourceLimits ResourceLimits, schedulingMode SchedulingMode) : CSAssignment in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.LeafQueue & moved to class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp	From	To

83fe34ac0896cee0918bbfad7bd51231e4aec39b

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: