845764da146e98927e8ea5b2209f19f4fc3feda5
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 30
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 2 | ||
| Rename Method public validateApplicationPostPayload(application Application) : void renamed to public validateApplicationPayload(application Application, fs FileSystem) : void in class org.apache.slider.util.ServiceApiUtil | From | To | |
| Rename Method public addRoleHostTokens(tokens Map<String,String>, amState StateAccessForProviders) : void renamed to public addComponentHostTokens(tokens Map<String,String>, amState StateAccessForProviders) : void in class org.apache.slider.providers.ProviderUtils | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type amState : StateAccessForProviders to roleInstance : RoleInstance in method public createConfigFileAndAddLocalResource(launcher ContainerLauncher, fs SliderFileSystem, component Component, tokensForSubstitution Map<String,String>, roleInstance RoleInstance) : void in class org.apache.slider.providers.ProviderUtils | From | To | |
| Change Parameter Type id : ContainerId to roleInstance : RoleInstance in method public unregisterComponent(roleInstance RoleInstance) : void in class org.apache.slider.server.appmaster.SliderAppMaster | From | To | |
| Rename Variable | 2 | ||
| Rename Variable configFile : ConfigFile to entry : Map.Entry<String,String> in method public addEnvForSubstitution(env Map<String,String>, tokensForSubstitution Map<String,String>) : void in class org.apache.slider.providers.ProviderUtils | From | To | |
| Rename Variable id : ContainerId to containerId : ContainerId in method public unregisterComponent(roleInstance RoleInstance) : void in class org.apache.slider.server.appmaster.SliderAppMaster | From | To | |
| Change Return Type | 2 | ||
| Change Return Type List<ProviderRole> to void in method public updateComponents(requestProto Messages.FlexComponentsRequestProto) : void in class org.apache.slider.server.appmaster.state.AppState | From | To | |
| Change Return Type List<ProviderRole> to void in method public updateComponents(componentCounts Map<String,Long>) : void in class org.apache.slider.server.appmaster.state.AppState | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute containerId : ContainerId to roleInstance : RoleInstance in class org.apache.slider.server.appmaster.actions.UnregisterComponentInstance | From | To | |
| Extract Variable | 1 | ||
| Extract Variable count : long in method public updateComponents(componentCounts Map<String,Long>) : void from class org.apache.slider.server.appmaster.state.AppState | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type configFile : ConfigFile to entry : Map.Entry<String,String> in method public addEnvForSubstitution(env Map<String,String>, tokensForSubstitution Map<String,String>) : void in class org.apache.slider.providers.ProviderUtils | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type containerId : ContainerId to roleInstance : RoleInstance in class org.apache.slider.server.appmaster.actions.UnregisterComponentInstance | From | To | |
| Extract Method | 2 | ||
| Extract Method private resolveNonTemplateConfigsAndSaveOnHdfs(fs SliderFileSystem, tokensForSubstitution Map<String,String>, roleInstance RoleInstance, configFile ConfigFile, fileName String, remoteFile Path) : void extracted from public createConfigFileAndAddLocalResource(launcher ContainerLauncher, fs SliderFileSystem, component Component, tokensForSubstitution Map<String,String>, amState StateAccessForProviders) : void in class org.apache.slider.providers.ProviderUtils | From | To | |
| Extract Method public addEnvForSubstitution(env Map<String,String>, tokensForSubstitution Map<String,String>) : void extracted from public createConfigFileAndAddLocalResource(launcher ContainerLauncher, fs SliderFileSystem, component Component, tokensForSubstitution Map<String,String>, amState StateAccessForProviders) : void in class org.apache.slider.providers.ProviderUtils | From | To | |
| Extract And Move Method | 1 | ||
| Extract And Move Method public substituteStrWithTokens(content String, tokensForSubstitution Map<String,String>) : String extracted from public buildContainerLaunchContext(launcher ContainerLauncher, application Application, container Container, providerRole ProviderRole, fileSystem SliderFileSystem) : void in class org.apache.slider.providers.docker.DockerProviderService & moved to class org.apache.slider.providers.ProviderUtils | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter id : ContainerId to roleInstance : RoleInstance in method public unregisterComponent(roleInstance RoleInstance) : void in class org.apache.slider.server.appmaster.SliderAppMaster | From | To | |
| Rename Parameter amState : StateAccessForProviders to roleInstance : RoleInstance in method public createConfigFileAndAddLocalResource(launcher ContainerLauncher, fs SliderFileSystem, component Component, tokensForSubstitution Map<String,String>, roleInstance RoleInstance) : void in class org.apache.slider.providers.ProviderUtils | From | To |