846936698b2c8c50662e43534ac999df82066a8b
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 17
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 2 | ||
| Move Method private getNextIndex() : int from class org.apache.hadoop.hdds.scm.pipelines.PipelineManager to private getNextIndex() : int from class org.apache.hadoop.hdds.scm.pipelines.PipelineManager.ActivePipelines | From | To | |
| Move Method private initializeStateMachine() : void from class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector to private initializeStateMachine() : void from class org.apache.hadoop.hdds.scm.pipelines.PipelineStateManager | From | To | |
| Rename Variable | 1 | ||
| Rename Variable pipeline : Pipeline to id : PipelineID in method public getPipeline(replicationFactor ReplicationFactor, replicationType ReplicationType) : PipelineID in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager | From | To | |
| Change Return Type | 1 | ||
| Change Return Type Pipeline to PipelineID in method public getPipeline(replicationFactor ReplicationFactor, replicationType ReplicationType) : PipelineID in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private pipelineIndex : AtomicInteger from class org.apache.hadoop.hdds.scm.pipelines.PipelineManager to private pipelineIndex : AtomicInteger from class org.apache.hadoop.hdds.scm.pipelines.PipelineManager.ActivePipelines | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.hdds.scm.pipelines.PipelineStateManager from class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute finalStates : Set<HddsProtos.LifeCycleState> to pipeline2ContainerMap : Map<PipelineID,HashSet<ContainerID>> in method public PipelineSelector(nodeManager NodeManager, conf Configuration, eventPublisher EventPublisher, cacheSizeMB int) in class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector | From | To | |
| Change Variable Type | 7 | ||
| Change Variable Type set : NavigableSet<ContainerID> to set : Set<ContainerID> in method public testPipelineCloseWithClosedContainer() : void in class org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose | From | To | |
| Change Variable Type setOpen : NavigableSet<ContainerID> to setOpen : Set<ContainerID> in method public testPipelineCloseWithOpenContainer() : void in class org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose | From | To | |
| Change Variable Type set2 : NavigableSet<ContainerID> to set2 : Set<ContainerID> in method public testPipelineMap() : void in class org.apache.hadoop.hdds.scm.pipeline.TestNode2PipelineMap | From | To | |
| Change Variable Type setClosed : NavigableSet<ContainerID> to setClosed : Set<ContainerID> in method public testPipelineCloseWithClosedContainer() : void in class org.apache.hadoop.hdds.scm.pipeline.TestPipelineClose | From | To | |
| Change Variable Type pipeline : Pipeline to id : PipelineID in method public getPipeline(replicationFactor ReplicationFactor, replicationType ReplicationType) : PipelineID in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager | From | To | |
| Change Variable Type finalStates : Set<HddsProtos.LifeCycleState> to pipeline2ContainerMap : Map<PipelineID,HashSet<ContainerID>> in method public PipelineSelector(nodeManager NodeManager, conf Configuration, eventPublisher EventPublisher, cacheSizeMB int) in class org.apache.hadoop.hdds.scm.pipelines.PipelineSelector | From | To | |
| Change Variable Type set : NavigableSet<ContainerID> to set : Set<ContainerID> in method public testPipelineMap() : void in class org.apache.hadoop.hdds.scm.pipeline.TestNode2PipelineMap | From | To | |
| Extract Variable | 1 | ||
| Extract Variable containerID : long in method public allocateContainer(selector PipelineSelector, type HddsProtos.ReplicationType, replicationFactor HddsProtos.ReplicationFactor, owner String) : ContainerWithPipeline from class org.apache.hadoop.hdds.scm.container.ContainerStateManager | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type activePipelines : List<PipelineID> to activePipelines : ArrayList<ActivePipelines> in class org.apache.hadoop.hdds.scm.pipelines.PipelineManager | From | To | |
| Change Attribute Type scmContainerMapping : Mapping to scmContainerMapping : ContainerMapping in class org.apache.hadoop.hdds.scm.container.TestContainerStateManagerIntegration | From | To |