8528d85a68c0e6ea71026df4d3026e7edc206b2d
Files Diff
- Added: 6
- Removed: 1
- Renamed: 0
- Modified: 9
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 2 | ||
| Move Method private uploadContainerLogIntoRemoteDir(ugi UserGroupInformation, configuration Configuration, rootLogDirs List<String>, nodeId NodeId, containerId ContainerId, appDir Path, fs FileSystem) : void from class org.apache.hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices to private uploadContainerLogIntoRemoteDir(ugi UserGroupInformation, configuration Configuration, rootLogDirs List<String>, nodeId NodeId, containerId ContainerId, appDir Path, fs FileSystem) : void from class org.apache.hadoop.yarn.logaggregation.TestContainerLogsUtils | From | To | |
| Move Method private createContainerLogInLocalDir(appLogsDir Path, containerId ContainerId, fs FileSystem, fileName String, content String) : void from class org.apache.hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices to private createContainerLogInLocalDir(appLogsDir Path, containerId ContainerId, fs FileSystem, fileName String, content String) : void from class org.apache.hadoop.yarn.logaggregation.TestContainerLogsUtils | From | To | |
| Rename Variable | 1 | ||
| Rename Variable fileName : String to log : JSONObject in method private getContainerLogFiles(conf Configuration, containerIdStr String, nodeHttpAddress String) : List<PerContainerLogFileInfo> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Return Type | 2 | ||
| Change Return Type List<PerLogFileInfo> to List<PerContainerLogFileInfo> in method private getContainerLogFiles(conf Configuration, containerIdStr String, nodeHttpAddress String) : List<PerContainerLogFileInfo> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Return Type List<ContainerLogInfo> to List<PerContainerLogFileInfo> in method public getContainerLogsInfo() : List<PerContainerLogFileInfo> in class org.apache.hadoop.yarn.server.webapp.dao.ContainerLogsInfo | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.yarn.logaggregation.TestContainerLogsUtils from class org.apache.hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.hadoop.yarn.server.webapp.dao.ContainerLogsInfo.ContainerLogInfo moved and renamed to org.apache.hadoop.yarn.logaggregation.PerContainerLogFileInfo | From | To | |
| Extract Variable | 1 | ||
| Extract Variable logMeta : List<PerContainerLogFileInfo> in method public testContainerLogsMetaForFinishedApps() : void from class org.apache.hadoop.yarn.server.applicationhistoryservice.webapp.TestAHSWebServices | From | To | |
| Change Variable Type | 6 | ||
| Change Variable Type fileInfo : PerLogFileInfo to fileInfo : PerContainerLogFileInfo in method public getMatchedContainerLogFiles(request ContainerLogsRequest, useRegex boolean) : Set<String> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Variable Type fileName : String to log : JSONObject in method private getContainerLogFiles(conf Configuration, containerIdStr String, nodeHttpAddress String) : List<PerContainerLogFileInfo> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Variable Type infos : List<PerLogFileInfo> to infos : List<PerContainerLogFileInfo> in method private printContainerInfoFromRunningApplication(options ContainerLogsRequest) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Variable Type allLogFileInfos : List<PerLogFileInfo> to allLogFileInfos : List<PerContainerLogFileInfo> in method public getMatchedContainerLogFiles(request ContainerLogsRequest, useRegex boolean) : Set<String> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Variable Type logFileInfos : List<PerLogFileInfo> to logFileInfos : List<PerContainerLogFileInfo> in method private getContainerLogFiles(conf Configuration, containerIdStr String, nodeHttpAddress String) : List<PerContainerLogFileInfo> in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Variable Type info : PerLogFileInfo to info : PerContainerLogFileInfo in method private printContainerInfoFromRunningApplication(options ContainerLogsRequest) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type containerLogsInfo : List<ContainerLogInfo> to containerLogsInfo : List<PerContainerLogFileInfo> in class org.apache.hadoop.yarn.server.webapp.dao.ContainerLogsInfo | From | To |