8650cc84f20e7d8c32dcdcd91c94372d476e2276
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 10
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method private getRenameAndDeleteDiffs(targetDir Path) : DiffInfo[] renamed to private getRenameAndDeleteDiffsForSync(targetDir Path) : DiffInfo[] in class org.apache.hadoop.tools.DistCpSync | From | To | |
| Rename Method private getTargetPath(sourcePath Path, renameItem DiffInfo) : Path renamed to private translateRenamedPath(sourcePath Path, renameItem DiffInfo) : Path in class org.apache.hadoop.tools.DistCpSync | From | To | |
| Rename Method public prepareDiffList() : ArrayList<DiffInfo> renamed to public prepareDiffListForCopyListing() : ArrayList<DiffInfo> in class org.apache.hadoop.tools.DistCpSync | From | To | |
| Rename Method private getSourceSnapshotPath(sourceDir Path, snapshotName String) : Path renamed to private getSnapshotPath(inputDir Path, snapshotName String) : Path in class org.apache.hadoop.tools.DistCpSync | From | To | |
| Rename Variable | 1 | ||
| Rename Variable tfs : FileSystem to tgtFs : FileSystem in method private preSyncCheck() : boolean in class org.apache.hadoop.tools.DistCpSync | From | To | |
| Extract Variable | 3 | ||
| Extract Variable dt : SnapshotDiffReport.DiffType in method private getAllDiffs() : boolean from class org.apache.hadoop.tools.DistCpSync | From | To | |
| Extract Variable optionLabel : String in method private testSnapshotDiffOption(isDiff boolean) : void from class org.apache.hadoop.tools.TestOptionsParser | From | To | |
| Extract Variable optionStr : String in method private testSnapshotDiffOption(isDiff boolean) : void from class org.apache.hadoop.tools.TestOptionsParser | From | To | |
| Extract Method | 5 | ||
| Extract Method private prepareFileListing(job Job) : void extracted from public createAndSubmitJob() : Job in class org.apache.hadoop.tools.DistCp | From | To | |
| Extract Method private testSnapshotDiffOption(isDiff boolean) : void extracted from public testDiffOption() : void in class org.apache.hadoop.tools.TestOptionsParser | From | To | |
| Extract Method private isRdiff() : boolean extracted from private getAllDiffs() : boolean in class org.apache.hadoop.tools.DistCpSync | From | To | |
| Extract Method private checkSnapshotsArgs(snapshots String[]) : void extracted from public parse(args String[]) : DistCpOptions in class org.apache.hadoop.tools.OptionsParser | From | To | |
| Extract Method private getRenameAndDeleteDiffsRdiff(targetDir Path) : DiffInfo[] extracted from private getRenameAndDeleteDiffs(targetDir Path) : DiffInfo[] in class org.apache.hadoop.tools.DistCpSync | From | To | |
| Extract And Move Method | 3 | ||
| Extract And Move Method public shouldUseSnapshotDiff() : boolean extracted from protected doBuildListing(pathToListingFile Path, options DistCpOptions) : void in class org.apache.hadoop.tools.SimpleCopyListing & moved to class org.apache.hadoop.tools.DistCpOptions | From | To | |
| Extract And Move Method package getSource() : Path extracted from private getTargetPath(sourcePath Path, renameItem DiffInfo) : Path in class org.apache.hadoop.tools.DistCpSync & moved to class org.apache.hadoop.tools.DiffInfo | From | To | |
| Extract And Move Method package getSource() : Path extracted from public prepareDiffList() : ArrayList<DiffInfo> in class org.apache.hadoop.tools.DistCpSync & moved to class org.apache.hadoop.tools.DiffInfo | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter sourceDir : Path to inputDir : Path in method private getSnapshotPath(inputDir Path, snapshotName String) : Path in class org.apache.hadoop.tools.DistCpSync | From | To |