89cab1ba5f0671f8ef30dbe7432079c18362b434
Files Diff
- Added: 7
- Removed: 0
- Renamed: 0
- Modified: 65
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type containersToDecrease : List<Container> to containersToDecrease : Collection<Container> in method public addAllContainersToDecrease(containersToDecrease Collection<Container>) : void in class org.apache.hadoop.yarn.server.api.protocolrecords.impl.pb.NodeHeartbeatResponsePBImpl | From | To | |
| Change Parameter Type containersToDecrease : List<Container> to containersToDecrease : Collection<Container> in method public addAllContainersToDecrease(containersToDecrease Collection<Container>) : void in class org.apache.hadoop.yarn.server.api.protocolrecords.NodeHeartbeatResponse | From | To | |
| Move Method | 1 | ||
| Move Method protected checkHeadroom(clusterResource Resource, currentResourceLimits ResourceLimits, required Resource, node FiCaSchedulerNode) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.ContainerAllocator to private checkHeadroom(clusterResource Resource, currentResourceLimits ResourceLimits, required Resource, node FiCaSchedulerNode) : boolean from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.RegularContainerAllocator | From | To | |
| Pull Up Attribute | 4 | ||
| Pull Up Attribute package application : FiCaSchedulerApp from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.ContainerAllocator to package application : FiCaSchedulerApp from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.AbstractContainerAllocator | From | To | |
| Pull Up Attribute package rc : ResourceCalculator from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.ContainerAllocator to package rc : ResourceCalculator from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.AbstractContainerAllocator | From | To | |
| Pull Up Attribute private LOG : Log from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.ContainerAllocator to private LOG : Log from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.AbstractContainerAllocator | From | To | |
| Pull Up Attribute package rmContext : RMContext from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.ContainerAllocator to package rmContext : RMContext from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.AbstractContainerAllocator | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type allocation : ContainersAndNMTokensAllocation to newlyAllocatedContainers : List<Container> in method public allocate(appAttemptId ApplicationAttemptId, ask List<ResourceRequest>, release List<ContainerId>, blacklistAdditions List<String>, blacklistRemovals List<String>, increaseRequests List<ContainerResourceChangeRequest>, decreaseRequests List<ContainerResourceChangeRequest>) : Allocation in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler | From | To | |
| Change Variable Type nmTokens : List<NMToken> to updatedNMTokens : Set<NMToken> in method private updateContainerAndNMToken(rmContainer RMContainer, newContainer boolean, increasedContainer boolean) : Container in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt | From | To | |
| Change Variable Type allocation : ContainersAndNMTokensAllocation to newlyAllocatedContainers : List<Container> in method public getAllocation(rc ResourceCalculator, clusterResource Resource, minimumAllocation Resource) : Allocation in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp | From | To | |
| Extract Variable | 1 | ||
| Extract Variable maximumCapacity : Resource in method public allocate(request AllocateRequest) : AllocateResponse from class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Extract Method | 3 | ||
| Extract Method private commonReserve(node SchedulerNode, priority Priority, rmContainer RMContainer, reservedResource Resource) : boolean extracted from public reserve(node SchedulerNode, priority Priority, rmContainer RMContainer, container Container) : RMContainer in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt | From | To | |
| Extract Method private internalReleaseResource(clusterResource Resource, node FiCaSchedulerNode, releasedResource Resource, changeResource boolean, completedChildQueue CSQueue, sortQueues boolean) : void extracted from public completedContainer(clusterResource Resource, application FiCaSchedulerApp, node FiCaSchedulerNode, rmContainer RMContainer, containerStatus ContainerStatus, event RMContainerEventType, completedChildQueue CSQueue, sortQueues boolean) : void in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.ParentQueue | From | To | |
| Extract Method private updateContainerAndNMToken(rmContainer RMContainer, newContainer boolean, increasedContainer boolean) : Container extracted from public pullNewlyAllocatedContainersAndNMTokens() : ContainersAndNMTokensAllocation in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt | From | To | |
| Rename Method | 2 | ||
| Rename Method public unreserve(node FiCaSchedulerNode, priority Priority) : boolean renamed to private internalUnreserve(node FiCaSchedulerNode, priority Priority) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp | From | To | |
| Rename Method public pullNewlyAllocatedContainersAndNMTokens() : ContainersAndNMTokensAllocation renamed to public pullNewlyAllocatedContainers() : List<Container> in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt | From | To | |
| Pull Up Method | 2 | ||
| Pull Up Method public abstract assignContainers(clusterResource Resource, node FiCaSchedulerNode, schedulingMode SchedulingMode, resourceLimits ResourceLimits, reservedContainer RMContainer) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.ContainerAllocator to public abstract assignContainers(clusterResource Resource, node FiCaSchedulerNode, schedulingMode SchedulingMode, resourceLimits ResourceLimits, reservedContainer RMContainer) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.AbstractContainerAllocator | From | To | |
| Pull Up Method protected getCSAssignmentFromAllocateResult(clusterResource Resource, result ContainerAllocation, rmContainer RMContainer) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.ContainerAllocator to protected getCSAssignmentFromAllocateResult(clusterResource Resource, result ContainerAllocation, rmContainer RMContainer) : CSAssignment from class org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.AbstractContainerAllocator | From | To | |
| Rename Variable | 4 | ||
| Rename Variable allocation : ContainersAndNMTokensAllocation to newlyAllocatedContainers : List<Container> in method public getAllocation(rc ResourceCalculator, clusterResource Resource, minimumAllocation Resource) : Allocation in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp | From | To | |
| Rename Variable containerResource : Resource to reservedResource : Resource in method public getNodeIdToUnreserve(priority Priority, resourceNeedUnreserve Resource, rc ResourceCalculator, clusterResource Resource) : NodeId in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp | From | To | |
| Rename Variable allocation : ContainersAndNMTokensAllocation to newlyAllocatedContainers : List<Container> in method public allocate(appAttemptId ApplicationAttemptId, ask List<ResourceRequest>, release List<ContainerId>, blacklistAdditions List<String>, blacklistRemovals List<String>, increaseRequests List<ContainerResourceChangeRequest>, decreaseRequests List<ContainerResourceChangeRequest>) : Allocation in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.fair.FairScheduler | From | To | |
| Rename Variable container : Container to updatedContainer : Container in method public pullNewlyAllocatedContainers() : List<Container> in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt | From | To | |
| Change Return Type | 1 | ||
| Change Return Type ContainersAndNMTokensAllocation to List<Container> in method public pullNewlyAllocatedContainers() : List<Container> in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable askedNodePartition : String to requestedPartition : String in method public checkResourceRequestMatchingNodePartition(requestedPartition String, nodePartition String, schedulingMode SchedulingMode) : boolean in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerUtils | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute nmTokens : List<NMToken> to updatedNMTokens : Set<NMToken> in method private updateContainerAndNMToken(rmContainer RMContainer, newContainer boolean, increasedContainer boolean) : Container in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerApplicationAttempt | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.AbstractContainerAllocator from classes [org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.ContainerAllocator, org.apache.hadoop.yarn.server.resourcemanager.scheduler.capacity.allocator.RegularContainerAllocator] | From | To | |
| Rename Attribute | 1 | ||
| Rename Attribute requests : Map<Priority,Map<String,ResourceRequest>> to resourceRequestMap : Map<Priority,Map<String,ResourceRequest>> in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.AppSchedulingInfo | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type containerAllocator : ContainerAllocator to containerAllocator : AbstractContainerAllocator in class org.apache.hadoop.yarn.server.resourcemanager.scheduler.common.fica.FiCaSchedulerApp | From | To |