hadoop 8b281bce85474501868d68f8d5590a6086abb7b7

8b281bce85474501868d68f8d5590a6086abb7b7

Files Diff

Added: 0
Removed: 3
Renamed: 0
Modified: 7

Link to commit

Dependency Action

Refactorings reported:

Refactoring Name	Occurences
Rename Method	1
Rename Method public doTestShortCircuitReadWithRemoteBlockReader(ignoreChecksum boolean, size int, shortCircuitUser String, readOffset int, shortCircuitFails boolean) : void renamed to public doTestShortCircuitReadWithRemoteBlockReader2(size int, shortCircuitUser String, readOffset int, shortCircuitFails boolean) : void in class org.apache.hadoop.hdfs.shortcircuit.TestShortCircuitLocalRead	From	To
Move Method	12
Move Method package getBlockData() : byte[] from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderBase to package getBlockData() : byte[] from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderRemote	From	To
Move Method public getFileName(s InetSocketAddress, poolId String, blockId long) : String from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to public getFileName(s InetSocketAddress, poolId String, blockId long) : String from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Method private readNextPacket() : void from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to private readNextPacket() : void from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Method public setup() : void from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderBase to public setup() : void from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderRemote	From	To
Move Method package writeReadResult(out OutputStream, statusCode Status) : void from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to package writeReadResult(out OutputStream, statusCode Status) : void from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Method private readTrailingEmptyPacket() : void from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to private readTrailingEmptyPacket() : void from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Method public testSkip() : void from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderBase to public testSkip() : void from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderRemote	From	To
Move Method public getPeer() : Peer from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to public getPeer() : Peer from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Method private getBlockReader(block LocatedBlock) : BlockReader from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderBase to private getBlockReader(block LocatedBlock) : BlockReader from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderRemote	From	To
Move Method package checkSuccess(status BlockOpResponseProto, peer Peer, block ExtendedBlock, file String) : void from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to package checkSuccess(status BlockOpResponseProto, peer Peer, block ExtendedBlock, file String) : void from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Method public newBlockReader(file String, block ExtendedBlock, blockToken Token<BlockTokenIdentifier>, startOffset long, len long, verifyChecksum boolean, clientName String, peer Peer, datanodeID DatanodeID, peerCache PeerCache, cachingStrategy CachingStrategy, tracer Tracer, networkDistance int) : BlockReader from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to public newBlockReader(file String, block ExtendedBlock, blockToken Token<BlockTokenIdentifier>, startOffset long, len long, verifyChecksum boolean, clientName String, peer Peer, datanodeID DatanodeID, peerCache PeerCache, cachingStrategy CachingStrategy, tracer Tracer, networkDistance int) : BlockReader from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Method public shutdown() : void from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderBase to public shutdown() : void from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderRemote	From	To
Rename Variable	2
Rename Variable ret : int to skip : int in method public skip(n long) : long in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Rename Variable nSkipped : long to skipped : long in method public skip(n long) : long in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Attribute	8
Move Attribute package TCP_WINDOW_SIZE : int from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to package TCP_WINDOW_SIZE : int from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Attribute private filename : String from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to private filename : String from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Attribute private reader : BlockReader from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderBase to private reader : BlockReader from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderRemote	From	To
Move Attribute private curDataSlice : ByteBuffer from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to private curDataSlice : ByteBuffer from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Attribute private util : BlockReaderTestUtil from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderBase to private util : BlockReaderTestUtil from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderRemote	From	To
Move Attribute private blockData : byte[] from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderBase to private blockData : byte[] from class org.apache.hadoop.hdfs.client.impl.TestBlockReaderRemote	From	To
Move Attribute private packetReceiver : PacketReceiver from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to private packetReceiver : PacketReceiver from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Move Attribute private verifyChecksum : boolean from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote2 to private verifyChecksum : boolean from class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Rename Attribute	2
Rename Attribute firstChunkOffset : long to verifyChecksum : boolean in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Rename Attribute lastChunkOffset : long to filename : String in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Change Variable Type	4
Change Variable Type reader : BlockReaderRemote2 to reader : BlockReaderRemote in method public testIncompleteRead() : void in class org.apache.hadoop.hdfs.client.impl.TestClientBlockVerification	From	To
Change Variable Type reader : BlockReaderRemote2 to reader : BlockReaderRemote in method public testBlockVerification() : void in class org.apache.hadoop.hdfs.client.impl.TestClientBlockVerification	From	To
Change Variable Type reader : BlockReaderRemote2 to reader : BlockReaderRemote in method public testCompletePartialRead() : void in class org.apache.hadoop.hdfs.client.impl.TestClientBlockVerification	From	To
Change Variable Type reader : BlockReaderRemote2 to reader : BlockReaderRemote in method public testUnalignedReads() : void in class org.apache.hadoop.hdfs.client.impl.TestClientBlockVerification	From	To
Change Attribute Type	3
Change Attribute Type lastChunkOffset : long to filename : String in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Change Attribute Type firstChunkOffset : long to verifyChecksum : boolean in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Change Attribute Type in : DataInputStream to in : ReadableByteChannel in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Rename Parameter	2
Rename Parameter readOffset : int to off : int in method public readFully(buf byte[], off int, len int) : void in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To
Rename Parameter amtToRead : int to len : int in method public readFully(buf byte[], off int, len int) : void in class org.apache.hadoop.hdfs.client.impl.BlockReaderRemote	From	To

8b281bce85474501868d68f8d5590a6086abb7b7

Files Diff

Link to commit

Third party dependencies:

Refactorings reported: