8b7adf4ddf420a93c586c4b2eac27dd0f649682e
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
Refactoring Name | Occurences | ||
---|---|---|---|
Rename Method | 1 | ||
Rename Method private createChildrenDirectories(fsd FSDirectory, existing INodesInPath, children List<String>, perm PermissionStatus) : INodesInPath renamed to private createSingleDirectory(fsd FSDirectory, existing INodesInPath, localName byte[], perm PermissionStatus) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirMkdirOp | From | To | |
Change Parameter Type | 2 | ||
Change Parameter Type children : List<String> to localName : byte[] in method private createSingleDirectory(fsd FSDirectory, existing INodesInPath, localName byte[], perm PermissionStatus) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirMkdirOp | From | To | |
Change Parameter Type localName : String to localName : byte[] in method private addFile(fsd FSDirectory, existing INodesInPath, localName byte[], permissions PermissionStatus, replication short, preferredBlockSize long, clientName String, clientMachine String) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp | From | To | |
Rename Variable | 2 | ||
Rename Variable size : int to missing : int in method private createParentDirectories(fsd FSDirectory, iip INodesInPath, perm PermissionStatus, inheritPerms boolean) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirMkdirOp | From | To | |
Rename Variable e : Map.Entry<INodesInPath,String> to parent : INodesInPath in method private addSymlink(fsd FSDirectory, path String, iip INodesInPath, target String, dirPerms PermissionStatus, createParent boolean, logRetryCache boolean) : INodeSymlink in class org.apache.hadoop.hdfs.server.namenode.FSDirSymlinkOp | From | To | |
Inline Method | 1 | ||
Inline Method private createSingleDirectory(fsd FSDirectory, existing INodesInPath, localName String, perm PermissionStatus) : INodesInPath inlined to private createSingleDirectory(fsd FSDirectory, existing INodesInPath, localName byte[], perm PermissionStatus) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirMkdirOp | From | To | |
Change Return Type | 1 | ||
Change Return Type Map.Entry<INodesInPath,String> to INodesInPath in method package createAncestorDirectories(fsd FSDirectory, iip INodesInPath, permission PermissionStatus) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirMkdirOp | From | To | |
Change Variable Type | 2 | ||
Change Variable Type parent : Map.Entry<INodesInPath,String> to parent : INodesInPath in method package startFile(fsn FSNamesystem, pc FSPermissionChecker, src String, permissions PermissionStatus, holder String, clientMachine String, flag EnumSet<CreateFlag>, createParent boolean, replication short, blockSize long, ezInfo EncryptionKeyInfo, toRemoveBlocks INode.BlocksMapUpdateInfo, logRetryEntry boolean) : HdfsFileStatus in class org.apache.hadoop.hdfs.server.namenode.FSDirWriteFileOp | From | To | |
Change Variable Type e : Map.Entry<INodesInPath,String> to parent : INodesInPath in method private addSymlink(fsd FSDirectory, path String, iip INodesInPath, target String, dirPerms PermissionStatus, createParent boolean, logRetryCache boolean) : INodeSymlink in class org.apache.hadoop.hdfs.server.namenode.FSDirSymlinkOp | From | To | |
Inline Variable | 1 | ||
Inline Variable localName : byte[] in method private addSymlink(fsd FSDirectory, path String, iip INodesInPath, target String, dirPerms PermissionStatus, createParent boolean, logRetryCache boolean) : INodeSymlink from class org.apache.hadoop.hdfs.server.namenode.FSDirSymlinkOp | From | To | |
Extract Method | 1 | ||
Extract Method private createParentDirectories(fsd FSDirectory, iip INodesInPath, perm PermissionStatus, inheritPerms boolean) : INodesInPath extracted from package createAncestorDirectories(fsd FSDirectory, iip INodesInPath, permission PermissionStatus) : Map.Entry<INodesInPath,String> in class org.apache.hadoop.hdfs.server.namenode.FSDirMkdirOp | From | To | |
Rename Parameter | 2 | ||
Rename Parameter permission : PermissionStatus to perm : PermissionStatus in method private createParentDirectories(fsd FSDirectory, iip INodesInPath, perm PermissionStatus, inheritPerms boolean) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirMkdirOp | From | To | |
Rename Parameter children : List<String> to localName : byte[] in method private createSingleDirectory(fsd FSDirectory, existing INodesInPath, localName byte[], perm PermissionStatus) : INodesInPath in class org.apache.hadoop.hdfs.server.namenode.FSDirMkdirOp | From | To |