8bb26465956a37d7398818bc0919772e12953725
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 7 | ||
| Pull Up Method private createClient() : Client from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to protected createClient() : Client from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Method public init() : void from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to protected initialize() : void from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Method public stop() : void from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to public tearDown() : void from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Method private verifyHttpResponse(client Client, uri URI, status Status) : void from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to protected verifyHttpResponse(client Client, uri URI, status Status) : void from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Method public tearDown() : void from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to public tearDown() : void from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Method private getResponse(client Client, uri URI) : ClientResponse from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to protected getResponse(client Client, uri URI) : ClientResponse from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Method public setup() : void from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to public setup() : void from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Attribute | 3 | ||
| Pull Up Attribute private server : TimelineReaderServer from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to private server : TimelineReaderServer from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Attribute private serverPort : int from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to private serverPort : int from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Pull Up Attribute private util : HBaseTestingUtility from class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage to private util : HBaseTestingUtility from class org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to List<FlowActivityEntity> in method private verifyFlowEntites(client Client, uri URI, noOfEntities int, a int[], flowsInSequence String[]) : List<FlowActivityEntity> in class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage.DummyURLConnectionFactory moved to org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase.DummyURLConnectionFactory | From | To | |
| Extract Superclass | 1 | ||
| Extract Superclass org.apache.hadoop.yarn.server.timelineservice.reader.AbstractTimelineReaderHBaseTestBase from classes [org.apache.hadoop.yarn.server.timelineservice.reader.TestTimelineReaderWebServicesHBaseStorage] | From | To | |
| Extract Method | 1 | ||
| Extract Method public getFlows(req HttpServletRequest, res HttpServletResponse, clusterId String, limit String, dateRange String, fromId String) : Set<TimelineEntity> extracted from public getFlows(req HttpServletRequest, res HttpServletResponse, clusterId String, limit String, dateRange String) : Set<TimelineEntity> in class org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type flowActivityRowKeyConverter : KeyConverter<FlowActivityRowKey> to flowActivityRowKeyConverter : FlowActivityRowKeyConverter in class org.apache.hadoop.yarn.server.timelineservice.storage.flow.FlowActivityRowKey | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method public joinAndEscapeStrings(strs String[]) : String extracted from private joinAndEscapeUIDParts(parts String[]) : String in class org.apache.hadoop.yarn.server.timelineservice.reader.TimelineUIDConverter & moved to class org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderUtils | From | To | |
| Extract And Move Method public split(str String) : List<String> extracted from private splitUID(uid String) : List<String> in class org.apache.hadoop.yarn.server.timelineservice.reader.TimelineUIDConverter & moved to class org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderUtils | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter clusterId : String to fromId : String in method public getFlows(req HttpServletRequest, res HttpServletResponse, limit String, dateRange String, fromId String) : Set<TimelineEntity> in class org.apache.hadoop.yarn.server.timelineservice.reader.TimelineReaderWebServices | From | To |