8d4f74e7339abc77dc0daa162d7bd2814bd79b3d
Files Diff
- Added: 8
- Removed: 0
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 4 | ||
| Rename Method public init(fsd FSDirectory) : void renamed to public activate() : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded | From | To | |
| Rename Method public addReportedMovedBlocks(moveAttemptFinishedBlks Block[]) : void renamed to public notifyMovementTriedBlocks(moveAttemptFinishedBlks Block[]) : void in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems | From | To | |
| Rename Method public getTrackId() : long renamed to public getFileId() : long in class org.apache.hadoop.hdfs.server.namenode.sps.ItemInfo | From | To | |
| Rename Method public StoragePolicySatisfier(ctxt Context) renamed to public init(context Context, fileIDCollector FileIdCollector, blockMovementTaskHandler BlockMoveTaskHandler) : void in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier | From | To | |
| Move And Rename Method | 1 | ||
| Move And Rename Method public assignBlockMoveTaskToTargetNode(blkMovingInfo BlockMovingInfo) : void from class org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeContext to public submitMoveTask(blkMovingInfo BlockMovingInfo, blockMoveCompletionListener BlockMovementListener) : void from class org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeBlockMoveTaskHandler | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type conf : Configuration to service : SPSService in method public IntraSPSNameNodeContext(namesystem Namesystem, blockManager BlockManager, service SPSService) in class org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeContext | From | To | |
| Change Parameter Type context : Context to service : SPSService in method public BlockStorageMovementAttemptedItems(service SPSService, unsatisfiedStorageMovementFiles BlockStorageMovementNeeded) in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems | From | To | |
| Move Method | 3 | ||
| Move Method public getConf() : Configuration from class org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeContext to public getConf() : Configuration from class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier | From | To | |
| Move Method private cleanSpsStatus() : void from class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded.StorageMovementPendingInodeIdCollector to private cleanSpsStatus() : void from class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded.SPSPathIdProcessor | From | To | |
| Move Method public run() : void from class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded.StorageMovementPendingInodeIdCollector to public run() : void from class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded.SPSPathIdProcessor | From | To | |
| Change Return Type | 1 | ||
| Change Return Type BlockStorageMovementAttemptedItems to BlockMovementListener in method package getAttemptedItemsMonitor() : BlockMovementListener in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private conf : Configuration from class org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeContext to private conf : Configuration from class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier | From | To | |
| Move Attribute private spsDirsToBeTraveresed : Queue<Long> from class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded to private spsDirsToBeTraveresed : Queue<Long> from class org.apache.hadoop.hdfs.server.namenode.sps.SPSPathIds | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded.SPSPathIdProcessor from class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded.StorageMovementPendingInodeIdCollector | From | To | |
| Move And Rename Class | 1 | ||
| Move And Rename Class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded.StorageMovementPendingInodeIdCollector moved and renamed to org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeFileIdCollector | From | To | |
| Move Class | 2 | ||
| Move Class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded.SPSTraverseInfo moved to org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeFileIdCollector.SPSTraverseInfo | From | To | |
| Move Class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier.ItemInfo moved to org.apache.hadoop.hdfs.server.namenode.sps.ItemInfo | From | To | |
| Rename Attribute | 4 | ||
| Rename Attribute maxQueuedItem : int to fileIDCollector : FileIdCollector in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded | From | To | |
| Rename Attribute conf : Configuration to service : SPSService in class org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeContext | From | To | |
| Rename Attribute trackId : long to fileId : long in class org.apache.hadoop.hdfs.server.namenode.sps.ItemInfo | From | To | |
| Rename Attribute inodeIdCollector : Daemon to pathIdCollector : Daemon in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded | From | To | |
| Extract Interface | 1 | ||
| Extract Interface org.apache.hadoop.hdfs.server.namenode.sps.SPSService from classes [org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier] | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type maxQueuedItem : int to fileIDCollector : FileIdCollector in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementNeeded | From | To | |
| Change Attribute Type conf : Configuration to service : SPSService in class org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeContext | From | To | |
| Rename Parameter | 6 | ||
| Rename Parameter context : Context to service : SPSService in method public BlockStorageMovementAttemptedItems(service SPSService, unsatisfiedStorageMovementFiles BlockStorageMovementNeeded) in class org.apache.hadoop.hdfs.server.namenode.sps.BlockStorageMovementAttemptedItems | From | To | |
| Rename Parameter expectedMovementFinishedBlocksCount : long to expectedMoveFinishedBlks : long in method private waitForBlocksMovementAttemptReport(cluster MiniDFSCluster, expectedMoveFinishedBlks long, timeout int) : void in class org.apache.hadoop.hdfs.server.namenode.sps.TestStoragePolicySatisfierWithStripedFile | From | To | |
| Rename Parameter trackId : long to fileId : long in method public ItemInfo(startId long, fileId long, retryCount int) in class org.apache.hadoop.hdfs.server.namenode.sps.ItemInfo | From | To | |
| Rename Parameter ctxt : Context to context : Context in method public init(context Context, fileIDCollector FileIdCollector, blockMovementTaskHandler BlockMoveTaskHandler) : void in class org.apache.hadoop.hdfs.server.namenode.sps.StoragePolicySatisfier | From | To | |
| Rename Parameter conf : Configuration to service : SPSService in method public IntraSPSNameNodeContext(namesystem Namesystem, blockManager BlockManager, service SPSService) in class org.apache.hadoop.hdfs.server.namenode.sps.IntraSPSNameNodeContext | From | To | |
| Rename Parameter trackId : long to fileId : long in method public ItemInfo(startId long, fileId long) in class org.apache.hadoop.hdfs.server.namenode.sps.ItemInfo | From | To |