8e1539eca8175f58f836daa5b0ad598c890cbb02
Files Diff
- Added: 3
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 3 | ||
| Rename Method public downloadIP(id String, dstDir String, localizedResources Map<Path,List<String>>) : String renamed to public retrieveIPfilePath(id String, dstDir String, localizedResources Map<Path,List<String>>) : String in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin | From | To | |
| Rename Method public downloadIP(id String, dstDir String, localizedResources Map<Path,List<String>>) : String renamed to public retrieveIPfilePath(id String, dstDir String, localizedResources Map<Path,List<String>>) : String in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.AbstractFpgaVendorPlugin | From | To | |
| Rename Method public setShell(shell InnerShellExecutor) : void renamed to package setInnerShellExecutor(shellExecutor InnerShellExecutor) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin | From | To | |
| Move And Rename Method | 2 | ||
| Move And Rename Method public parseDiagnoseInfo(output String, list List<FpgaResourceAllocator.FpgaDevice>) : void from class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin to public parseDiagnosticOutput(output String, shellExecutor InnerShellExecutor, fpgaType String) : List<FpgaDevice> from class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.AoclDiagnosticOutputParser | From | To | |
| Move And Rename Method public testDiscoverPluginParser() : void from class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestFpgaDiscoverer to public testParsing() : void from class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.TestAoclOutputParser | From | To | |
| Rename Variable | 1 | ||
| Rename Variable r : String to ipFilePath : String in method public retrieveIPfilePath(id String, dstDir String, localizedResources Map<Path,List<String>>) : String in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin | From | To | |
| Inline Method | 3 | ||
| Inline Method public setPathToExecutable(pathToExecutable String) : void inlined to public initPlugin(config Configuration) : boolean in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin | From | To | |
| Inline Method public getDefaultBinaryName() : String inlined to public initPlugin(config Configuration) : boolean in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin | From | To | |
| Change Return Type | 1 | ||
| Change Return Type void to List<FpgaDevice> in method public parseDiagnosticOutput(output String, shellExecutor InnerShellExecutor, fpgaType String) : List<FpgaDevice> in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.AoclDiagnosticOutputParser | From | To | |
| Extract Variable | 1 | ||
| Extract Variable device : FpgaDevice in method public preStart(container Container) : List<PrivilegedOperation> from class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.fpga.FpgaResourceHandlerImpl | From | To | |
| Inline Variable | 1 | ||
| Inline Variable pathToExecutable : String in method public initPlugin(conf Configuration) : boolean from class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter conf : Configuration to config : Configuration in method public initPlugin(config Configuration) : boolean in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin | From | To | |
| Rename Parameter shell : InnerShellExecutor to shellExecutor : InnerShellExecutor in method package setInnerShellExecutor(shellExecutor InnerShellExecutor) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.resourceplugin.fpga.IntelFpgaOpenclPlugin | From | To |