913f87dada27776c539dfb352400ecf8d40e7943
Files Diff
- Added: 1
- Removed: 0
- Renamed: 0
- Modified: 35
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type compsToUpgradeInOrder : Queue<Component> to compsToUpgrade : List<Component> in method public setCompsToUpgrade(compsToUpgrade List<Component>) : ServiceEvent in class org.apache.hadoop.yarn.service.ServiceEvent | From | To | |
| Move Method | 1 | ||
| Move Method public decContainersThatNeedUpgrade() : void from class org.apache.hadoop.yarn.service.component.Component to public decContainersThatNeedUpgrade() : void from class org.apache.hadoop.yarn.service.component.Component.UpgradeStatus | From | To | |
| Move Attribute | 1 | ||
| Move Attribute private upgradeInProgress : AtomicBoolean from class org.apache.hadoop.yarn.service.component.Component to private upgradeInProgress : AtomicBoolean from class org.apache.hadoop.yarn.service.component.instance.ComponentInstance | From | To | |
| Extract Class | 1 | ||
| Extract Class org.apache.hadoop.yarn.service.component.Component.UpgradeStatus from class org.apache.hadoop.yarn.service.component.Component | From | To | |
| Rename Class | 2 | ||
| Rename Class org.apache.hadoop.yarn.service.component.Component.ComponentNeedsUpgradeTransition renamed to org.apache.hadoop.yarn.service.component.Component.CompletedAfterUpgradeTransition | From | To | |
| Rename Class org.apache.hadoop.yarn.service.component.instance.ComponentInstance.ContainerUpgradeTransition renamed to org.apache.hadoop.yarn.service.component.instance.ComponentInstance.CancelUpgradeTransition | From | To | |
| Extract Variable | 1 | ||
| Extract Variable status : ContainerStatus in method public transition(compInstance ComponentInstance, event ComponentInstanceEvent) : void from class org.apache.hadoop.yarn.service.component.instance.ComponentInstance.ContainerStoppedTransition | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type orderedCompUpgrade : Queue<org.apache.hadoop.yarn.service.api.records.Component> to orderedCompUpgrade : List<org.apache.hadoop.yarn.service.api.records.Component> in method package processUpgradeRequest(upgradeVersion String, autoFinalize boolean, expressUpgrade boolean) : void in class org.apache.hadoop.yarn.service.ServiceManager | From | To | |
| Extract Method | 7 | ||
| Extract Method private setComponentState(state ComponentState) : void extracted from private checkAndUpdateComponentState(component Component, isIncrement boolean) : void in class org.apache.hadoop.yarn.service.component.Component | From | To | |
| Extract Method private upgradeAndReadyAllInstances(context ServiceContext) : void extracted from public testFinalize() : void in class org.apache.hadoop.yarn.service.TestServiceManager | From | To | |
| Extract Method private upgradeAndReadyAllInstances(context ServiceContext) : void extracted from public testAutoFinalizeNothingToUpgrade() : void in class org.apache.hadoop.yarn.service.TestServiceManager | From | To | |
| Extract Method private upgradeAndReadyAllInstances(context ServiceContext) : void extracted from public testRestartNothingToUpgrade() : void in class org.apache.hadoop.yarn.service.TestServiceManager | From | To | |
| Extract Method private resolveCompsToUpgrade(sourceSpec Service, targetSpec Service) : List<org.apache.hadoop.yarn.service.api.records.Component> extracted from package processUpgradeRequest(upgradeVersion String, autoFinalize boolean, expressUpgrade boolean) : void in class org.apache.hadoop.yarn.service.ServiceManager | From | To | |
| Extract Method private upgradeAndReadyAllInstances(context ServiceContext) : void extracted from public testAutoFinalize() : void in class org.apache.hadoop.yarn.service.TestServiceManager | From | To | |
| Rename Method | 3 | ||
| Rename Method public setCompsToUpgradeInOrder(compsToUpgradeInOrder Queue<Component>) : ServiceEvent renamed to public setCompsToUpgrade(compsToUpgrade List<Component>) : ServiceEvent in class org.apache.hadoop.yarn.service.ServiceEvent | From | To | |
| Rename Method public getUpgradeEvent() : ComponentEvent renamed to public getCancelUpgradeStatus() : UpgradeStatus in class org.apache.hadoop.yarn.service.component.Component | From | To | |
| Rename Method private upgradeInstancesOf(context ServiceContext, compName String) : void renamed to private upgradeInstances(context ServiceContext, compName String) : void in class org.apache.hadoop.yarn.service.TestServiceManager | From | To | |
| Rename Variable | 2 | ||
| Rename Variable comp1 : String to compA : String in method public testExpressUpgrade() : void in class org.apache.hadoop.yarn.service.TestServiceManager | From | To | |
| Rename Variable comp2 : String to compB : String in method public testExpressUpgrade() : void in class org.apache.hadoop.yarn.service.TestServiceManager | From | To | |
| Change Return Type | 2 | ||
| Change Return Type void to ComponentInstanceState in method public transition(instance ComponentInstance, event ComponentInstanceEvent) : ComponentInstanceState in class org.apache.hadoop.yarn.service.component.instance.ComponentInstance.CancelUpgradeTransition | From | To | |
| Change Return Type ComponentEvent to UpgradeStatus in method public getCancelUpgradeStatus() : UpgradeStatus in class org.apache.hadoop.yarn.service.component.Component | From | To | |
| Rename Attribute | 2 | ||
| Rename Attribute compsToUpgradeInOrder : Queue<org.apache.hadoop.yarn.service.api.records.Component> to componentsToUpgrade : List<org.apache.hadoop.yarn.service.api.records.Component> in class org.apache.hadoop.yarn.service.ServiceManager | From | To | |
| Rename Attribute compsToUpgradeInOrder : Queue<Component> to compsToUpgrade : List<Component> in class org.apache.hadoop.yarn.service.ServiceEvent | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type compsToUpgradeInOrder : Queue<org.apache.hadoop.yarn.service.api.records.Component> to componentsToUpgrade : List<org.apache.hadoop.yarn.service.api.records.Component> in class org.apache.hadoop.yarn.service.ServiceManager | From | To | |
| Change Attribute Type compsToUpgradeInOrder : Queue<Component> to compsToUpgrade : List<Component> in class org.apache.hadoop.yarn.service.ServiceEvent | From | To | |
| Extract And Move Method | 6 | ||
| Extract And Move Method public setContainerState(state ContainerState) : void extracted from public transition(compInstance ComponentInstance, event ComponentInstanceEvent) : void in class org.apache.hadoop.yarn.service.component.instance.ComponentInstance.ContainerBecomeNotReadyTransition & moved to class org.apache.hadoop.yarn.service.component.instance.ComponentInstance | From | To | |
| Extract And Move Method public getComponentDir(serviceVersion String, compName String) : Path extracted from public initCompInstanceDir(fs SliderFileSystem, compLaunchContext ContainerLaunchService.ComponentLaunchContext, instance ComponentInstance) : Path in class org.apache.hadoop.yarn.service.provider.ProviderUtils & moved to class org.apache.hadoop.yarn.service.utils.SliderFileSystem | From | To | |
| Extract And Move Method private setComponentState(state ComponentState) : void extracted from public transition(component Component, event ComponentEvent) : ComponentState in class org.apache.hadoop.yarn.service.component.Component.FlexComponentTransition & moved to class org.apache.hadoop.yarn.service.component.Component | From | To | |
| Extract And Move Method private setServiceState(state ServiceState) : void extracted from public transition(serviceManager ServiceManager, event ServiceEvent) : State in class org.apache.hadoop.yarn.service.ServiceManager.StartUpgradeTransition & moved to class org.apache.hadoop.yarn.service.ServiceManager | From | To | |
| Extract And Move Method public setContainerState(state ContainerState) : void extracted from public transition(compInstance ComponentInstance, event ComponentInstanceEvent) : void in class org.apache.hadoop.yarn.service.component.instance.ComponentInstance.ContainerBecomeReadyTransition & moved to class org.apache.hadoop.yarn.service.component.instance.ComponentInstance | From | To | |
| Extract And Move Method private postContainerReady() : void extracted from public transition(compInstance ComponentInstance, event ComponentInstanceEvent) : void in class org.apache.hadoop.yarn.service.component.instance.ComponentInstance.ContainerBecomeReadyTransition & moved to class org.apache.hadoop.yarn.service.component.instance.ComponentInstance | From | To | |
| Rename Parameter | 2 | ||
| Rename Parameter compsToUpgradeInOrder : Queue<Component> to compsToUpgrade : List<Component> in method public setCompsToUpgrade(compsToUpgrade List<Component>) : ServiceEvent in class org.apache.hadoop.yarn.service.ServiceEvent | From | To | |
| Rename Parameter compInstance : ComponentInstance to instance : ComponentInstance in method public transition(instance ComponentInstance, event ComponentInstanceEvent) : ComponentInstanceState in class org.apache.hadoop.yarn.service.component.instance.ComponentInstance.CancelUpgradeTransition | From | To |