91cc070d67533ebb3325b982eba2135e0d175a82
Files Diff
- Added: 5
- Removed: 1
- Renamed: 0
- Modified: 13
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move Method | 4 | ||
| Move Method private verifyAndGetNodeId(html Block) : NodeId from class org.apache.hadoop.yarn.webapp.log.AggregatedLogsBlock to public verifyAndGetNodeId(html Block, nodeIdStr String) : NodeId from class org.apache.hadoop.yarn.logaggregation.LogAggregationWebUtils | From | To | |
| Move Method private verifyAndGetContainerId(html Block) : ContainerId from class org.apache.hadoop.yarn.webapp.log.AggregatedLogsBlock to public verifyAndGetContainerId(html Block, containerIdStr String) : ContainerId from class org.apache.hadoop.yarn.logaggregation.LogAggregationWebUtils | From | To | |
| Move Method private readContainerLogs(html Block, logReader AggregatedLogFormat.ContainerLogsReader, logLimits LogLimits, desiredLogType String, logUpLoadTime long) : boolean from class org.apache.hadoop.yarn.webapp.log.AggregatedLogsBlock to private readContainerLogs(html Block, logReader AggregatedLogFormat.ContainerLogsReader, startIndex long, endIndex long, desiredLogType String, logUpLoadTime long) : boolean from class org.apache.hadoop.yarn.logaggregation.filecontroller.tfile.TFileAggregatedLogsBlock | From | To | |
| Move Method private verifyAndGetAppOwner(html Block) : String from class org.apache.hadoop.yarn.webapp.log.AggregatedLogsBlock to public verifyAndGetAppOwner(html Block, appOwner String) : String from class org.apache.hadoop.yarn.logaggregation.LogAggregationWebUtils | From | To | |
| Rename Variable | 3 | ||
| Rename Variable foundContainerLogs : boolean to foundAnyLogs : boolean in method public dumpAContainerLogsForLogTypeWithoutNodeId(options ContainerLogsRequest) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Rename Variable foundContainerLogs : boolean to foundAnyLogs : boolean in method public dumpAContainerLogsForLogType(options ContainerLogsRequest, outputFailure boolean) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Rename Variable foundLog : boolean to isValid : boolean in method protected render(html Block) : void in class org.apache.hadoop.yarn.webapp.log.AggregatedLogsBlock | From | To | |
| Inline Method | 1 | ||
| Inline Method private getRemoteNodeFileDir(appId ApplicationId, appOwner String) : RemoteIterator<FileStatus> inlined to public printNodesList(options ContainerLogsRequest, out PrintStream, err PrintStream) : void in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.hadoop.yarn.logaggregation.filecontroller.LogAggregationTFileController moved to org.apache.hadoop.yarn.logaggregation.filecontroller.tfile.LogAggregationTFileController | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type aggregatedBlock : AggregatedLogsBlockForTest to aggregatedBlock : TFileAggregatedLogsBlockForTest in method public testAggregatedLogsBlockHar() : void in class org.apache.hadoop.yarn.logaggregation.TestAggregatedLogsBlock | From | To | |
| Inline Variable | 4 | ||
| Inline Variable containerId : String in method public dumpAContainerLogsForLogTypeWithoutNodeId(options ContainerLogsRequest) : int from class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Inline Variable appId : ApplicationId in method public dumpAllContainersLogs(options ContainerLogsRequest) : int from class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Inline Variable containerId : String in method public dumpAContainerLogsForLogType(options ContainerLogsRequest, outputFailure boolean) : int from class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Inline Variable appOwner : String in method public dumpAllContainersLogs(options ContainerLogsRequest) : int from class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To |