9875325d5c63f343809907d06bf48a298035a611
Files Diff
- Added: 9
- Removed: 0
- Renamed: 0
- Modified: 34
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public testSubmitReservationDoesnotExist() : void renamed to public testSubmitReservationDoesNotExist() : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.TestReservationInputValidator | From | To | |
| Rename Variable | 5 | ||
| Rename Variable queueName : String to queue : String in method private validateReservation(reservationSystem ReservationSystem, reservationId ReservationId, auditConstant String) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Rename Variable queueName : String to queue : String in method public validateReservationSubmissionRequest(reservationSystem ReservationSystem, request ReservationSubmissionRequest, reservationId ReservationId) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Rename Variable errMsg : String to nullQueueErrorMessage : String in method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Rename Variable errMsg : String to nullPlanErrorMessage : String in method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Rename Variable reservation : InMemoryReservationAllocation to res : InMemoryReservationAllocation in method public getReservations(reservationID ReservationId, interval ReservationInterval, user String) : Set<ReservationAllocation> in class org.apache.hadoop.yarn.server.resourcemanager.reservation.InMemoryPlan | From | To | |
| Parameterize Variable | 5 | ||
| Parameterize Variable errMsg : String to nullPlanErrorMessage : String in method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String, nullQueueErrorMessage String, nullPlanErrorMessage String) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Parameterize Variable queueName : String to queue : String in method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Parameterize Variable errMsg : String to nullQueueErrorMessage : String in method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String, nullQueueErrorMessage String, nullPlanErrorMessage String) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Parameterize Variable queueName : String to queue : String in method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String, nullQueueErrorMessage String, nullPlanErrorMessage String) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Extract Method | 11 | ||
| Extract Method private createReservationAllocation(reservationID ReservationId, start int, alloc int[]) : ReservationAllocation extracted from public testAddReservation() : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.TestInMemoryPlan | From | To | |
| Extract Method private createReservationAllocation(reservationID ReservationId, start int, alloc int[]) : ReservationAllocation extracted from public testUpdateReservation() : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.TestInMemoryPlan | From | To | |
| Extract Method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String) : Plan extracted from public validateReservationSubmissionRequest(reservationSystem ReservationSystem, request ReservationSubmissionRequest, reservationId ReservationId) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Extract Method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String, nullQueueErrorMessage String, nullPlanErrorMessage String) : Plan extracted from private validateReservation(reservationSystem ReservationSystem, reservationId ReservationId, auditConstant String) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Extract Method private createReservationAllocation(reservationID ReservationId, start int, alloc int[]) : ReservationAllocation extracted from public testAddReservationAlreadyExists() : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.TestInMemoryPlan | From | To | |
| Extract Method private createReservationAllocation(reservationID ReservationId, start int, alloc int[], isStep boolean) : ReservationAllocation extracted from public testDeleteReservation() : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.TestInMemoryPlan | From | To | |
| Extract Method private getPlanFromQueue(reservationSystem ReservationSystem, queue String, auditConstant String, nullQueueErrorMessage String, nullPlanErrorMessage String) : Plan extracted from public validateReservationSubmissionRequest(reservationSystem ReservationSystem, request ReservationSubmissionRequest, reservationId ReservationId) : Plan in class org.apache.hadoop.yarn.server.resourcemanager.reservation.ReservationInputValidator | From | To | |
| Extract Method public getReservations(reservationID ReservationId, interval ReservationInterval, user String) : Set<ReservationAllocation> extracted from public getReservationsAtTime(tick long) : Set<ReservationAllocation> in class org.apache.hadoop.yarn.server.resourcemanager.reservation.InMemoryPlan | From | To | |
| Extract Method private createReservationAllocation(reservationID ReservationId, start int, alloc int[], isStep boolean) : ReservationAllocation extracted from public testUpdateReservation() : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.TestInMemoryPlan | From | To | |
| Extract Method private createReservationAllocation(reservationID ReservationId, start int, alloc int[]) : ReservationAllocation extracted from public testAddEmptyReservation() : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.TestInMemoryPlan | From | To | |
| Extract Method private createReservationAllocation(reservationID ReservationId, start int, alloc int[]) : ReservationAllocation extracted from public testUpdateNonExistingReservation() : void in class org.apache.hadoop.yarn.server.resourcemanager.reservation.TestInMemoryPlan | From | To |