999c8fcbefc876d9c26c23c5b87a64a81e4f113e
Files Diff
- Added: 4
- Removed: 0
- Renamed: 0
- Modified: 31
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 6 | ||
| Rename Method public getUnderReplicatedBlocksCount() : long renamed to public getLowRedundancyBlocksCount() : long in class org.apache.hadoop.hdfs.server.blockmanagement.BlockManager | From | To | |
| Rename Method public getUnderReplicatedBlocksCount() : long renamed to public getLowRedundancyBlocksCount() : long in class org.apache.hadoop.hdfs.DistributedFileSystem | From | To | |
| Rename Method public testSetrepIncWithUnderReplicatedBlocks() : void renamed to public testSetRepIncWithUnderReplicatedBlocks() : void in class org.apache.hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks | From | To | |
| Rename Method private getBlock(block_id Long) : Block renamed to private getReplica(blockId Long) : Block in class org.apache.hadoop.hdfs.server.blockmanagement.TestCorruptReplicaInfo | From | To | |
| Rename Method public getUnderReplicatedBlocksCount() : long renamed to public getLowRedundancyBlocksCount() : long in class org.apache.hadoop.hdfs.DFSClient | From | To | |
| Rename Method public testCompInvalidate() : void renamed to public testComputeInvalidateReplicas() : void in class org.apache.hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork | From | To | |
| Rename Variable | 4 | ||
| Rename Variable mxbeanName : ObjectName to namenodeMXBeanName : ObjectName in method public testVerifyMissingBlockGroupsMetrics() : void in class org.apache.hadoop.hdfs.server.namenode.TestNameNodeMXBean | From | To | |
| Rename Variable blocks : LightWeightHashSet<Block> to replicaBlockSets : LightWeightHashSet<Block> in method package remove(dn DatanodeInfo) : void in class org.apache.hadoop.hdfs.server.blockmanagement.InvalidateBlocks | From | To | |
| Rename Variable limit : int to remainingLimit : int in method package invalidateWork(dn DatanodeDescriptor) : List<Block> in class org.apache.hadoop.hdfs.server.blockmanagement.InvalidateBlocks | From | To | |
| Rename Variable bean : StandardMBean to namesystemBean : StandardMBean in method private registerMBean() : void in class org.apache.hadoop.hdfs.server.namenode.FSNamesystem | From | To | |
| Parameterize Variable | 2 | ||
| Parameterize Variable curPri : int to priLevel : int in method private add(blockInfo BlockInfo, priLevel int, expectedReplicas int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks | From | To | |
| Parameterize Variable crm : CorruptReplicasMap to corruptReplicasMap : CorruptReplicasMap in method private verifyCorruptBlocksCount(corruptReplicasMap CorruptReplicasMap, expectedReplicaCount long, expectedStripedBlockCount long) : void in class org.apache.hadoop.hdfs.server.blockmanagement.TestCorruptReplicaInfo | From | To | |
| Rename Attribute | 3 | ||
| Rename Attribute node2blocks : Map<DatanodeInfo,LightWeightHashSet<Block>> to nodeToBlocks : Map<DatanodeInfo,LightWeightHashSet<Block>> in class org.apache.hadoop.hdfs.server.blockmanagement.InvalidateBlocks | From | To | |
| Rename Attribute block_map : Map<Long,Block> to replicaMap : Map<Long,Block> in class org.apache.hadoop.hdfs.server.blockmanagement.TestCorruptReplicaInfo | From | To | |
| Rename Attribute mxbeanName : ObjectName to namenodeMXBeanName : ObjectName in class org.apache.hadoop.hdfs.server.namenode.FSNamesystem | From | To | |
| Extract Variable | 1 | ||
| Extract Variable expectedMissingBlockCount : long in method public testVerifyMissingBlockGroupsMetrics() : void from class org.apache.hadoop.hdfs.server.namenode.TestNameNodeMXBean | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type entry : Map.Entry<DatanodeInfo,LightWeightHashSet<Block>> to entry : Entry<DatanodeInfo,LightWeightHashSet<Block>> in method private dumpBlockSet(nodeToBlocksMap Map<DatanodeInfo,LightWeightHashSet<Block>>, out PrintWriter) : void in class org.apache.hadoop.hdfs.server.blockmanagement.InvalidateBlocks | From | To | |
| Extract Method | 10 | ||
| Extract Method private verifyCorruptBlocksCount(corruptReplicasMap CorruptReplicasMap, expectedReplicaCount long, expectedStripedBlockCount long) : void extracted from public testCorruptReplicaInfo() : void in class org.apache.hadoop.hdfs.server.blockmanagement.TestCorruptReplicaInfo | From | To | |
| Extract Method private waitForDnMetricValue(source String, name String, expected long, sleepInterval long) : MetricsRecordBuilder extracted from public testCorruptBlock() : void in class org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics | From | To | |
| Extract Method private getBlocksSet(dn DatanodeInfo, block Block) : LightWeightHashSet<Block> extracted from package remove(dn DatanodeInfo, block Block) : void in class org.apache.hadoop.hdfs.server.blockmanagement.InvalidateBlocks | From | To | |
| Extract Method private verifyBlockStats(queues LowRedundancyBlocks, lowRedundancyReplicaCount int, corruptReplicaCount int, corruptReplicationOneCount int, lowRedundancyStripedCount int, corruptStripedCount int) : void extracted from public testBlockPriorities() : void in class org.apache.hadoop.hdfs.server.blockmanagement.TestLowRedundancyBlockQueues | From | To | |
| Extract Method private add(blockInfo BlockInfo, priLevel int, expectedReplicas int) : boolean extracted from package update(block BlockInfo, curReplicas int, readOnlyReplicas int, outOfServiceReplicas int, curExpectedReplicas int, curReplicasDelta int, expectedReplicasDelta int) : void in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks | From | To | |
| Extract Method private waitForDnMetricValue(source String, name String, expected long, sleepInterval long) : MetricsRecordBuilder extracted from private waitForDnMetricValue(source String, name String, expected long) : MetricsRecordBuilder in class org.apache.hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics | From | To | |
| Extract Method private verifyInvalidationWorkCounts(blockInvalidateLimit int) : void extracted from public testCompInvalidate() : void in class org.apache.hadoop.hdfs.server.blockmanagement.TestComputeInvalidateWork | From | To | |
| Extract Method private add(blockInfo BlockInfo, priLevel int, expectedReplicas int) : boolean extracted from package add(block BlockInfo, curReplicas int, readOnlyReplicas int, outOfServiceReplicas int, expectedReplicas int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks | From | To | |
| Extract Method package remove(block BlockInfo, priLevel int, oldExpectedReplicas int) : boolean extracted from package remove(block BlockInfo, priLevel int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks | From | To | |
| Extract Method private dumpBlockSet(nodeToBlocksMap Map<DatanodeInfo,LightWeightHashSet<Block>>, out PrintWriter) : void extracted from package dump(out PrintWriter) : void in class org.apache.hadoop.hdfs.server.blockmanagement.InvalidateBlocks | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type numBlocks : long to numBlocks : LongAdder in class org.apache.hadoop.hdfs.server.blockmanagement.InvalidateBlocks | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter block_id : Long to blockId : Long in method private getReplica(blockId Long) : Block in class org.apache.hadoop.hdfs.server.blockmanagement.TestCorruptReplicaInfo | From | To | |
| Rename Parameter block : BlockInfo to blockInfo : BlockInfo in method private add(blockInfo BlockInfo, priLevel int, expectedReplicas int) : boolean in class org.apache.hadoop.hdfs.server.blockmanagement.LowRedundancyBlocks | From | To |