9e37fe3b7a3b5f0a193d228bb5e065f41acd2835
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Variable | 1 | ||
| Rename Variable suffix : String to logDirSuffix : String in method private getRemoteAppLogDir(appId ApplicationId, appOwner String) : Path in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable appStateKnown : boolean to appStateObtainedSuccessfully : boolean in method private fetchContainerLogs(appState YarnApplicationState, appStateObtainedSuccessfully boolean, logFiles String[], appOwner String, nodeAddress String, containerId ContainerId, logCliHelper LogCLIHelpers) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method | 12 | ||
| Extract Method private fetchContainerLogs(appState YarnApplicationState, appStateObtainedSuccessfully boolean, logFiles String[], appOwner String, nodeAddress String, containerId ContainerId, logCliHelper LogCLIHelpers) : int extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method private getRemoteAppLogDir(appId ApplicationId, appOwner String) : Path extracted from public dumpAContainersLogsForALogTypeWithoutNodeId(appId String, containerId String, jobOwner String, logType List<String>) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Extract Method private getRemoteAppLogDir(appId ApplicationId, appOwner String) : Path extracted from public dumpAllContainersLogs(appId ApplicationId, appOwner String, out PrintStream) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Extract Method private showMetaInfo(appState YarnApplicationState, appStateObtainedSuccessfully boolean, logCliHelper LogCLIHelpers, appId ApplicationId, containerIdStr String, nodeAddress String, appOwner String) : int extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method private createCommandOpts() : Options extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method private createPrintOpts(commandOpts Options) : Options extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method private getRemoteNodeFileDir(appId ApplicationId, appOwner String) : RemoteIterator<FileStatus> extracted from public dumpAContainersLogsForALogTypeWithoutNodeId(appId String, containerId String, jobOwner String, logType List<String>) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Extract Method private getRemoteNodeFileDir(appId ApplicationId, appOwner String) : RemoteIterator<FileStatus> extracted from public dumpAContainersLogsForALogType(appId String, containerId String, nodeId String, jobOwner String, logType List<String>, outputFailure boolean) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Extract Method private getRemoteNodeFileDir(appId ApplicationId, appOwner String) : RemoteIterator<FileStatus> extracted from public dumpAllContainersLogs(appId ApplicationId, appOwner String, out PrintStream) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Extract Method private fetchAMContainerLogs(logFiles String[], appState YarnApplicationState, appId ApplicationId, appOwner String, amContainersList List<String>, logCliHelper LogCLIHelpers) : int extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method private parseAMContainer(commandLine CommandLine, printOpts Options) : List<String> extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method private getRemoteAppLogDir(appId ApplicationId, appOwner String) : Path extracted from public dumpAContainersLogsForALogType(appId String, containerId String, nodeId String, jobOwner String, logType List<String>, outputFailure boolean) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To |