9fea5c9ee76bd36f273ae93afef5f3ef3c477a53
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 12
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 2 | ||
| Change Parameter Type nodes : Set<? extends String> to nodes : Set<NodeDetails> in method private getNumRack(nodes Set<NodeDetails>) : int in class org.apache.hadoop.yarn.sls.utils.TestSLSUtils | From | To | |
| Change Parameter Type nodeSet : Set<String> to nodeSet : Set<NodeDetails> in method private addNodes(nodeSet Set<NodeDetails>, jsonEntry Map) : void in class org.apache.hadoop.yarn.sls.utils.SLSUtils | From | To | |
| Move Method | 1 | ||
| Move Method private buildNodeLabelsFromStr(args String) : List<NodeLabel> from class org.apache.hadoop.yarn.client.cli.RMAdminCLI to public buildNodeLabelsFromStr(args String) : List<NodeLabel> from class org.apache.hadoop.yarn.client.util.YarnClientUtils | From | To | |
| Rename Variable | 2 | ||
| Rename Variable nodeResourceMap : Map<String,Resource> to nodeDetails : Set<NodeDetails> in method public testParseNodesFromNodeFile() : void in class org.apache.hadoop.yarn.sls.utils.TestSLSUtils | From | To | |
| Rename Variable entry : Map.Entry<String,Resource> to nodeDetails : NodeDetails in method private startNM() : void in class org.apache.hadoop.yarn.sls.SLSRunner | From | To | |
| Change Return Type | 4 | ||
| Change Return Type Set<String> to Set<NodeDetails> in method public parseNodesFromRumenTrace(jobTrace String) : Set<NodeDetails> in class org.apache.hadoop.yarn.sls.utils.SLSUtils | From | To | |
| Change Return Type Set<? extends String> to Set<NodeDetails> in method public generateNodes(numNodes int, numRacks int) : Set<NodeDetails> in class org.apache.hadoop.yarn.sls.utils.SLSUtils | From | To | |
| Change Return Type Map<String,Resource> to Set<NodeDetails> in method public parseNodesFromNodeFile(nodeFile String, nmDefaultResource Resource) : Set<NodeDetails> in class org.apache.hadoop.yarn.sls.utils.SLSUtils | From | To | |
| Change Return Type Set<String> to Set<NodeDetails> in method public parseNodesFromSLSTrace(jobTrace String) : Set<NodeDetails> in class org.apache.hadoop.yarn.sls.utils.SLSUtils | From | To | |
| Move Attribute | 2 | ||
| Move Attribute private ADD_LABEL_FORMAT_ERR_MSG : String from class org.apache.hadoop.yarn.client.cli.RMAdminCLI to private ADD_LABEL_FORMAT_ERR_MSG : String from class org.apache.hadoop.yarn.client.util.YarnClientUtils | From | To | |
| Move Attribute private NO_LABEL_ERR_MSG : String from class org.apache.hadoop.yarn.client.cli.RMAdminCLI to public NO_LABEL_ERR_MSG : String from class org.apache.hadoop.yarn.client.util.YarnClientUtils | From | To | |
| Parameterize Variable | 4 | ||
| Parameterize Variable queue : String to jobQueue : String in method private runNewAM(jobType String, user String, jobQueue String, oldJobId String, jobStartTimeMS long, jobFinishTimeMS long, containerList List<ContainerSimulator>, amContainerResource Resource, labelExpr String) : void in class org.apache.hadoop.yarn.sls.SLSRunner | From | To | |
| Parameterize Variable amType : String to jobType : String in method private runNewAM(jobType String, user String, jobQueue String, oldJobId String, jobStartTimeMS long, jobFinishTimeMS long, containerList List<ContainerSimulator>, amContainerResource Resource, labelExpr String) : void in class org.apache.hadoop.yarn.sls.SLSRunner | From | To | |
| Parameterize Variable jobStartTime : long to jobStartTimeMS : long in method private runNewAM(jobType String, user String, jobQueue String, oldJobId String, jobStartTimeMS long, jobFinishTimeMS long, containerList List<ContainerSimulator>, amContainerResource Resource, labelExpr String) : void in class org.apache.hadoop.yarn.sls.SLSRunner | From | To | |
| Parameterize Variable oldAppId : String to oldJobId : String in method private runNewAM(jobType String, user String, jobQueue String, oldJobId String, jobStartTimeMS long, jobFinishTimeMS long, containerList List<ContainerSimulator>, amContainerResource Resource, labelExpr String) : void in class org.apache.hadoop.yarn.sls.SLSRunner | From | To | |
| Change Variable Type | 7 | ||
| Change Variable Type entry : Map.Entry<String,Resource> to nodeDetails : NodeDetails in method private startNM() : void in class org.apache.hadoop.yarn.sls.SLSRunner | From | To | |
| Change Variable Type node : String to node : NodeDetails in method private getNumRack(nodes Set<NodeDetails>) : int in class org.apache.hadoop.yarn.sls.utils.TestSLSUtils | From | To | |
| Change Variable Type nodeResourceMap : Map<String,Resource> to nodeDetails : Set<NodeDetails> in method public testParseNodesFromNodeFile() : void in class org.apache.hadoop.yarn.sls.utils.TestSLSUtils | From | To | |
| Change Variable Type nodes : Set<? extends String> to nodes : Set<NodeDetails> in method public testGenerateNodes() : void in class org.apache.hadoop.yarn.sls.utils.TestSLSUtils | From | To | |
| Change Variable Type nodeSet : Set<String> to nodeSet : Set<NodeDetails> in method public parseNodesFromSLSTrace(jobTrace String) : Set<NodeDetails> in class org.apache.hadoop.yarn.sls.utils.SLSUtils | From | To | |
| Change Variable Type nodeSet : Set<String> to nodeSet : Set<NodeDetails> in method public generateNodes(numNodes int, numRacks int) : Set<NodeDetails> in class org.apache.hadoop.yarn.sls.utils.SLSUtils | From | To | |
| Change Variable Type nodeSet : Set<String> to nodeSet : Set<NodeDetails> in method public parseNodesFromRumenTrace(jobTrace String) : Set<NodeDetails> in class org.apache.hadoop.yarn.sls.utils.SLSUtils | From | To | |
| Extract Method | 2 | ||
| Extract Method public init(nodeIdStr String, nodeResource Resource, dispatchTime int, heartBeatInterval int, pRm ResourceManager, pResourceUtilizationRatio float, labels Set<NodeLabel>) : void extracted from public init(nodeIdStr String, nodeResource Resource, dispatchTime int, heartBeatInterval int, pRm ResourceManager, pResourceUtilizationRatio float) : void in class org.apache.hadoop.yarn.sls.nodemanager.NMSimulator | From | To | |
| Extract Method private runNewAM(jobType String, user String, jobQueue String, oldJobId String, jobStartTimeMS long, jobFinishTimeMS long, containerList List<ContainerSimulator>, amContainerResource Resource, labelExpr String) : void extracted from private createAMForJob(jsonJob Map) : void in class org.apache.hadoop.yarn.sls.SLSRunner | From | To |