a2f680493f040704e2b85108e286731ee3860a52
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 7
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method public createMockMTab(parentDir File) : File renamed to public createPremountedCgroups(parentDir File, cpuAcct boolean) : File in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestCGroupsHandlerImpl | From | To | |
| Change Parameter Type | 2 | ||
| Change Parameter Type entries : Map<String,List<String>> to entries : Map<String,Set<String>> in method package findControllerInMtab(controller String, entries Map<String,Set<String>>) : String in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Change Parameter Type entries : Map<String,List<String>> to entries : Map<String,Set<String>> in method package findControllerInMtab(controller String, entries Map<String,Set<String>>) : String in class org.apache.hadoop.yarn.server.nodemanager.util.CgroupsLCEResourcesHandler | From | To | |
| Move Method | 1 | ||
| Move Method private createMockCgroupMount(parentDir File, type String, hierarchy String) : File from class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestCGroupsHandlerImpl to private createMockCgroupMount(parentDir File, type String) : File from class org.apache.hadoop.yarn.server.nodemanager.util.TestCgroupsLCEResourcesHandler | From | To | |
| Rename Variable | 3 | ||
| Rename Variable value : List<String> to cgroupList : Set<String> in method package parseMtab(mtab String) : Map<String,Set<String>> in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Rename Variable controllerPath : StringBuffer to requestedMountPath : String in method private mountCGroupController(controller CGroupController) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Rename Variable path : String to existingMountPath : String in method private mountCGroupController(controller CGroupController) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Change Return Type | 2 | ||
| Change Return Type Map<String,List<String>> to Map<String,Set<String>> in method private parseMtab() : Map<String,Set<String>> in class org.apache.hadoop.yarn.server.nodemanager.util.CgroupsLCEResourcesHandler | From | To | |
| Change Return Type Map<String,List<String>> to Map<String,Set<String>> in method package parseMtab(mtab String) : Map<String,Set<String>> in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Extract Variable | 1 | ||
| Extract Variable controllerPath : String in method private initializePreMountedCGroupController(controller CGroupController) : void from class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Change Variable Type | 9 | ||
| Change Variable Type value : List<String> to cgroupList : Set<String> in method package parseMtab(mtab String) : Map<String,Set<String>> in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Change Variable Type parsedMtab : Map<String,List<String>> to parsedMtab : Map<String,Set<String>> in method private initializeControllerPaths() : void in class org.apache.hadoop.yarn.server.nodemanager.util.CgroupsLCEResourcesHandler | From | To | |
| Change Variable Type ret : Map<String,List<String>> to ret : Map<String,Set<String>> in method private parseMtab() : Map<String,Set<String>> in class org.apache.hadoop.yarn.server.nodemanager.util.CgroupsLCEResourcesHandler | From | To | |
| Change Variable Type e : Map.Entry<String,List<String>> to e : Map.Entry<String,Set<String>> in method package findControllerInMtab(controller String, entries Map<String,Set<String>>) : String in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Change Variable Type cgroups : Map<String,List<String>> to cgroups : Map<String,Set<String>> in method public testSelectCgroup() : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestCGroupsHandlerImpl | From | To | |
| Change Variable Type e : Entry<String,List<String>> to e : Entry<String,Set<String>> in method package findControllerInMtab(controller String, entries Map<String,Set<String>>) : String in class org.apache.hadoop.yarn.server.nodemanager.util.CgroupsLCEResourcesHandler | From | To | |
| Change Variable Type ret : Map<String,List<String>> to ret : Map<String,Set<String>> in method package parseMtab(mtab String) : Map<String,Set<String>> in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Change Variable Type cgroups : Map<String,List<String>> to cgroups : Map<String,Set<String>> in method public testSelectCgroup() : void in class org.apache.hadoop.yarn.server.nodemanager.util.TestCgroupsLCEResourcesHandler | From | To | |
| Change Variable Type controllerPath : StringBuffer to requestedMountPath : String in method private mountCGroupController(controller CGroupController) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To | |
| Extract Method | 1 | ||
| Extract Method private createNoMountConfiguration(myHierarchy String) : Configuration extracted from private testPreMountedControllerInitialization(myHierarchy String) : void in class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.TestCGroupsHandlerImpl | From | To | |
| Inline Variable | 1 | ||
| Inline Variable hierarchy : String in method private mountCGroupController(controller CGroupController) : void from class org.apache.hadoop.yarn.server.nodemanager.containermanager.linux.resources.CGroupsHandlerImpl | From | To |