a4121c71c29d13866a605d9c0d013e5de9c147c3
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 4
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Pull Up Method | 3 | ||
| Pull Up Method public getInterface() : Class<T> from class org.apache.hadoop.hdfs.server.namenode.ha.IPFailoverProxyProvider to public getInterface() : Class<T> from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Method public getInterface() : Class<T> from class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider to public getInterface() : Class<T> from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Method private getRandomOrder(conf Configuration, nameNodeUri URI) : boolean from class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider to public getRandomOrder(conf Configuration, nameNodeUri URI) : boolean from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Attribute | 7 | ||
| Pull Up Attribute protected ugi : UserGroupInformation from class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider to protected ugi : UserGroupInformation from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Attribute protected conf : Configuration from class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider to protected conf : Configuration from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Attribute protected factory : HAProxyFactory<T> from class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider to protected factory : HAProxyFactory<T> from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Attribute private xface : Class<T> from class org.apache.hadoop.hdfs.server.namenode.ha.IPFailoverProxyProvider to protected xface : Class<T> from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Attribute protected xface : Class<T> from class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider to protected xface : Class<T> from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Attribute private factory : HAProxyFactory<T> from class org.apache.hadoop.hdfs.server.namenode.ha.IPFailoverProxyProvider to protected factory : HAProxyFactory<T> from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Pull Up Attribute private LOG : Logger from class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider to protected LOG : Logger from class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Change Return Type | 1 | ||
| Change Return Type ProxyInfo<T> to NNProxyInfo<T> in method public getProxy() : NNProxyInfo<T> in class org.apache.hadoop.hdfs.server.namenode.ha.IPFailoverProxyProvider | From | To | |
| Change Variable Type | 2 | ||
| Change Variable Type current : AddressRpcProxyPair<T> to current : NNProxyInfo<T> in method public getProxy() : ProxyInfo<T> in class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider | From | To | |
| Change Variable Type proxy : AddressRpcProxyPair<T> to proxy : ProxyInfo<T> in method public close() : void in class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type proxies : List<AddressRpcProxyPair<T>> to proxies : List<NNProxyInfo<T>> in class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider | From | To | |
| Change Attribute Type nnProxyInfo : ProxyInfo<T> to nnProxyInfo : NNProxyInfo<T> in class org.apache.hadoop.hdfs.server.namenode.ha.IPFailoverProxyProvider | From | To | |
| Extract Method | 2 | ||
| Extract Method private proxyName() : String extracted from public toString() : String in class org.apache.hadoop.io.retry.FailoverProxyProvider.ProxyInfo | From | To | |
| Extract Method private proxyName() : String extracted from public getString(methodName String) : String in class org.apache.hadoop.io.retry.FailoverProxyProvider.ProxyInfo | From | To | |
| Extract And Move Method | 2 | ||
| Extract And Move Method protected getProxyAddresses(uri URI, addressKey String) : List<NNProxyInfo<T>> extracted from public ConfiguredFailoverProxyProvider(conf Configuration, uri URI, xface Class<T>, factory HAProxyFactory<T>, addressKey String) in class org.apache.hadoop.hdfs.server.namenode.ha.ConfiguredFailoverProxyProvider & moved to class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To | |
| Extract And Move Method protected createProxyIfNeeded(pi NNProxyInfo<T>) : NNProxyInfo<T> extracted from public getProxy() : ProxyInfo<T> in class org.apache.hadoop.hdfs.server.namenode.ha.IPFailoverProxyProvider & moved to class org.apache.hadoop.hdfs.server.namenode.ha.AbstractNNFailoverProxyProvider | From | To |