a77d628339afaf2f5a085c73fd81a805b18348c9
Files Diff
- Added: 0
- Removed: 0
- Renamed: 0
- Modified: 5
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Rename Method | 1 | ||
| Rename Method private verifyApplicationState(appId ApplicationId) : int renamed to private getApplicationState(appId ApplicationId) : YarnApplicationState in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Return Type | 1 | ||
| Change Return Type int to YarnApplicationState in method private getApplicationState(appId ApplicationId) : YarnApplicationState in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Parameterize Variable | 3 | ||
| Parameterize Variable appIdStr : String to appId : String in method private printContainerLogsForFinishedApplication(appId String, containerId String, nodeAddress String, logFiles String[], logCliHelper LogCLIHelpers, appOwner String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Parameterize Variable containerIdStr : String to containerId : String in method private printContainerLogsForFinishedApplication(appId String, containerId String, nodeAddress String, logFiles String[], logCliHelper LogCLIHelpers, appOwner String) : void in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Parameterize Variable resultCode : int to appState : YarnApplicationState in method private isApplicationFinished(appState YarnApplicationState) : boolean in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type resultCode : int to appState : YarnApplicationState in method private isApplicationFinished(appState YarnApplicationState) : boolean in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method | 3 | ||
| Extract Method public dumpAContainersLogsForALogType(appId String, containerId String, nodeId String, jobOwner String, logType List<String>) : int extracted from public dumpAContainersLogs(appId String, containerId String, nodeId String, jobOwner String) : int in class org.apache.hadoop.yarn.logaggregation.LogCLIHelpers | From | To | |
| Extract Method private printContainerLogsForFinishedApplication(appId String, containerId String, nodeAddress String, logFiles String[], logCliHelper LogCLIHelpers, appOwner String) : void extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To | |
| Extract Method private isApplicationFinished(appState YarnApplicationState) : boolean extracted from public run(args String[]) : int in class org.apache.hadoop.yarn.client.cli.LogsCLI | From | To |