a91d24fea45c2d269fabe46d43d5d4156ba47e1c
Files Diff
- Added: 2
- Removed: 0
- Renamed: 0
- Modified: 8
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Move And Rename Method | 1 | ||
| Move And Rename Method private adjustBufferIndex() : void from class org.apache.hadoop.hdds.scm.storage.BlockInputStream to private adjustBufferPosition(bufferPosition long) : void from class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Move Method | 5 | ||
| Move Method private buffersHaveData() : boolean from class org.apache.hadoop.hdds.scm.storage.BlockInputStream to private buffersHaveData() : boolean from class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Move Method private releaseBuffers() : void from class org.apache.hadoop.hdds.scm.storage.BlockInputStream to private releaseBuffers() : void from class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Move Method package getRemaining() : long from class org.apache.hadoop.ozone.client.io.KeyInputStream.ChunkInputStreamEntry to public getRemaining() : long from class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Move Method private buffersRemaining() : boolean from class org.apache.hadoop.hdds.scm.storage.BlockInputStream to private buffersRemaining() : boolean from class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Move Method protected readChunk(chunkInfo ChunkInfo) : ByteString from class org.apache.hadoop.hdds.scm.storage.BlockInputStream to protected readChunk(readChunkInfo ChunkInfo) : ByteString from class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Move Attribute | 4 | ||
| Move Attribute private length : long from class org.apache.hadoop.ozone.client.io.KeyInputStream.ChunkInputStreamEntry to private length : long from class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Move Attribute private validator : CheckedBiFunction<ContainerCommandRequestProto,ContainerCommandResponseProto,IOException> from class org.apache.hadoop.hdds.scm.storage.BlockInputStream to private validator : CheckedBiFunction<ContainerCommandRequestProto,ContainerCommandResponseProto,IOException> from class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Move Attribute private buffers : List<ByteBuffer> from class org.apache.hadoop.hdds.scm.storage.BlockInputStream to private buffers : List<ByteBuffer> from class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Move Attribute private bufferIndex : int from class org.apache.hadoop.hdds.scm.storage.BlockInputStream to private bufferIndex : int from class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Extract Variable | 1 | ||
| Extract Variable numChecksums : int in method public verifyChecksumDataMatches(that ChecksumData, startIndex int) : boolean from class org.apache.hadoop.ozone.common.ChecksumData | From | To | |
| Change Variable Type | 1 | ||
| Change Variable Type bb : ByteBuffer to current : ChunkInputStream in method public read(b byte[], off int, len int) : int in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Extract Method | 2 | ||
| Extract Method public getRemaining() : long extracted from public read(b byte[], off int, len int) : int in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Extract Method public verifyChecksum(data byte[], checksumData ChecksumData, startIndex int) : boolean extracted from public verifyChecksum(data byte[], checksumData ChecksumData) : boolean in class org.apache.hadoop.ozone.common.Checksum | From | To | |
| Rename Method | 1 | ||
| Rename Method private checkNotClosed() : void renamed to private checkOpen() : void in class org.apache.hadoop.ozone.client.io.KeyInputStream | From | To | |
| Rename Variable | 3 | ||
| Rename Variable available : int to numBytesRead : int in method public read(b byte[], off int, len int) : int in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Rename Variable total : int to totalReadLen : int in method public read(b byte[], off int, len int) : int in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Rename Variable bb : ByteBuffer to current : ChunkInputStream in method public read(b byte[], off int, len int) : int in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Inline Method | 4 | ||
| Inline Method private prepareRead(len int) : int inlined to public read(b byte[], off int, len int) : int in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Inline Method private prepareRead(len int) : int inlined to public read() : int in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Change Return Type | 1 | ||
| Change Return Type List<ChunkInfo> to void in method private createChunkList(numChunks int) : void in class org.apache.hadoop.hdds.scm.storage.TestBlockInputStream | From | To | |
| Replace Variable With Attribute | 1 | ||
| Replace Variable With Attribute chunkList : List<ChunkInfo> to chunks : List<ChunkInfo> in method private createChunkList(numChunks int) : void in class org.apache.hadoop.hdds.scm.storage.TestBlockInputStream | From | To | |
| Rename Attribute | 6 | ||
| Rename Attribute chunkOffset : long[] to chunkOffsets : long[] in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Rename Attribute blockInputStream : BlockInputStream to blockStream : BlockInputStream in class org.apache.hadoop.hdds.scm.storage.TestBlockInputStream | From | To | |
| Rename Attribute buffers : List<ByteBuffer> to chunkStreams : List<ChunkInputStream> in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Rename Attribute streamOffset : long[] to blockOffsets : long[] in class org.apache.hadoop.ozone.client.io.KeyInputStream | From | To | |
| Rename Attribute streamEntries : ArrayList<ChunkInputStreamEntry> to blockStreams : List<BlockInputStream> in class org.apache.hadoop.ozone.client.io.KeyInputStream | From | To | |
| Rename Attribute currentStreamIndex : int to blockIndex : int in class org.apache.hadoop.ozone.client.io.KeyInputStream | From | To | |
| Change Attribute Type | 2 | ||
| Change Attribute Type buffers : List<ByteBuffer> to chunkStreams : List<ChunkInputStream> in class org.apache.hadoop.hdds.scm.storage.BlockInputStream | From | To | |
| Change Attribute Type streamEntries : ArrayList<ChunkInputStreamEntry> to blockStreams : List<BlockInputStream> in class org.apache.hadoop.ozone.client.io.KeyInputStream | From | To | |
| Rename Parameter | 3 | ||
| Rename Parameter chunkInfo : ChunkInfo to readChunkInfo : ChunkInfo in method protected readChunk(readChunkInfo ChunkInfo) : ByteString in class org.apache.hadoop.hdds.scm.storage.ChunkInputStream | From | To | |
| Rename Parameter omKeyLocationInfo : OmKeyLocationInfo to blockInfo : OmKeyLocationInfo in method private addStream(blockInfo OmKeyLocationInfo, xceiverClientMngr XceiverClientManager, clientRequestId String, verifyChecksum boolean) : void in class org.apache.hadoop.ozone.client.io.KeyInputStream | From | To | |
| Rename Parameter stream : BlockInputStream to blockInputStream : BlockInputStream in method public addStream(blockInputStream BlockInputStream) : void in class org.apache.hadoop.ozone.client.io.KeyInputStream | From | To |