ac1e5d4f77e3b9df8dcacb0b1f72eecc27931eb8
Files Diff
- Added: 1
- Removed: 1
- Renamed: 0
- Modified: 38
Refactorings reported:
| Refactoring Name | Occurences | ||
|---|---|---|---|
| Change Parameter Type | 1 | ||
| Change Parameter Type priority : Priority to schedKey : SchedulerRequestKey in method private allocate(rmIdentifier long, appContext OpportunisticContainerContext, schedKey SchedulerRequestKey, appAttId ApplicationAttemptId, userName String) : Map<Resource,List<Container>> in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Rename Variable | 5 | ||
| Rename Variable allocateResponse : AllocateResponse to response : AllocateResponse in method public allocate(request AllocateRequest) : AllocateResponse in class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Rename Variable c : Container to updatedContainer : Container in method protected addToUpdatedContainers(allocateResponse AllocateResponse, updateType ContainerUpdateType, updatedContainers List<Container>) : void in class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Rename Variable priority : Priority to schedulerKey : SchedulerRequestKey in method public allocateContainers(blackList ResourceBlacklistRequest, oppResourceReqs List<ResourceRequest>, applicationAttemptId ApplicationAttemptId, opportContext OpportunisticContainerContext, rmIdentifier long, appSubmitter String) : List<Container> in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Rename Variable priority : Priority to schedulerKey : SchedulerRequestKey in method public addToOutstandingReqs(resourceAsks List<ResourceRequest>) : void in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Rename Variable updatedContainers : List<UpdatedContainer> to containersToSet : ArrayList<UpdatedContainer> in method protected addToUpdatedContainers(allocateResponse AllocateResponse, updateType ContainerUpdateType, updatedContainers List<Container>) : void in class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Change Return Type | 1 | ||
| Change Return Type TreeMap<Priority,Map<Resource,ResourceRequest>> to TreeMap<SchedulerRequestKey,Map<Resource,ResourceRequest>> in method public getOutstandingOpReqs() : TreeMap<SchedulerRequestKey,Map<Resource,ResourceRequest>> in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Move Class | 1 | ||
| Move Class org.apache.hadoop.yarn.server.resourcemanager.scheduler.SchedulerRequestKey moved to org.apache.hadoop.yarn.server.scheduler.SchedulerRequestKey | From | To | |
| Parameterize Variable | 1 | ||
| Parameterize Variable rbr : ResourceBlacklistRequest to blackList : ResourceBlacklistRequest in method public allocateContainers(blackList ResourceBlacklistRequest, oppResourceReqs List<ResourceRequest>, applicationAttemptId ApplicationAttemptId, opportContext OpportunisticContainerContext, rmIdentifier long, appSubmitter String) : List<Container> in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Split Parameter | 1 | ||
| Split Parameter request : AllocateRequest to [blackList : ResourceBlacklistRequest, oppResourceReqs : List<ResourceRequest>] in method public allocateContainers(blackList ResourceBlacklistRequest, oppResourceReqs List<ResourceRequest>, applicationAttemptId ApplicationAttemptId, opportContext OpportunisticContainerContext, rmIdentifier long, appSubmitter String) : List<Container> in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Change Variable Type | 3 | ||
| Change Variable Type priority : Priority to schedulerKey : SchedulerRequestKey in method public allocateContainers(blackList ResourceBlacklistRequest, oppResourceReqs List<ResourceRequest>, applicationAttemptId ApplicationAttemptId, opportContext OpportunisticContainerContext, rmIdentifier long, appSubmitter String) : List<Container> in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To | |
| Change Variable Type priority : Priority to schedulerKey : SchedulerRequestKey in method public addToOutstandingReqs(resourceAsks List<ResourceRequest>) : void in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Change Variable Type updatedContainers : List<UpdatedContainer> to containersToSet : ArrayList<UpdatedContainer> in method protected addToUpdatedContainers(allocateResponse AllocateResponse, updateType ContainerUpdateType, updatedContainers List<Container>) : void in class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Inline Variable | 1 | ||
| Inline Variable applicationId : ApplicationId in method public allocate(request AllocateRequest) : AllocateResponse from class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Extract Method | 4 | ||
| Extract Method protected allocateInternal(appAttemptId ApplicationAttemptId, request AllocateRequest, allocateResponse AllocateResponse) : void extracted from public allocate(request AllocateRequest) : AllocateResponse in class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Extract Method protected addToAllocatedContainers(allocateResponse AllocateResponse, allocatedContainers List<Container>) : void extracted from public allocate(request AllocateRequest) : AllocateResponse in class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Extract Method protected addToUpdatedContainers(allocateResponse AllocateResponse, updateType ContainerUpdateType, updatedContainers List<Container>) : void extracted from public allocate(request AllocateRequest) : AllocateResponse in class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Extract Method protected addToUpdateContainerErrors(allocateResponse AllocateResponse, updateContainerErrors List<UpdateContainerError>) : void extracted from public allocate(request AllocateRequest) : AllocateResponse in class org.apache.hadoop.yarn.server.resourcemanager.ApplicationMasterService | From | To | |
| Change Attribute Type | 1 | ||
| Change Attribute Type outstandingOpReqs : TreeMap<Priority,Map<Resource,ResourceRequest>> to outstandingOpReqs : TreeMap<SchedulerRequestKey,Map<Resource,ResourceRequest>> in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerContext | From | To | |
| Rename Parameter | 1 | ||
| Rename Parameter priority : Priority to schedKey : SchedulerRequestKey in method private allocate(rmIdentifier long, appContext OpportunisticContainerContext, schedKey SchedulerRequestKey, appAttId ApplicationAttemptId, userName String) : Map<Resource,List<Container>> in class org.apache.hadoop.yarn.server.scheduler.OpportunisticContainerAllocator | From | To |